Re: [PATCH v4 10/12] drm/xe/lmtt: Report invalidation errors using structured xe_log API

[Dnyaneshwar Bhadane <dnyaneshwar.bhadane@Intel.com>]

On 28-Sep-26 3:06 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] xe_lmtt: missing newline in xe_log_err format string
> --
> 
> commit d8b97ea5041b192b44dac80a8e9209e9058d6519
> Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> 
> drm/xe/lmtt: Report invalidation errors using structured xe_log API
> 
> This commit replaces xe_tile_sriov_err() with xe_log_err() using the LMTT
> component tag for LMTT and MERT invalidation failures. It preserves the
> SR-IOV prefix in the newly structured log messages.
> 
>> diff --git a/drivers/gpu/drm/xe/xe_lmtt.c b/drivers/gpu/drm/xe/xe_lmtt.c
>> index 0c726eda93906..fe77b3ec06807 100644
>> --- a/drivers/gpu/drm/xe/xe_lmtt.c
>> +++ b/drivers/gpu/drm/xe/xe_lmtt.c
> 
> [ ... ]
> 
>> @@ -302,14 +303,15 @@ void xe_lmtt_invalidate_hw(struct xe_lmtt *lmtt)
>>   
>>   	err = lmtt_invalidate_hw(lmtt);
>>   	if (err)
>> -		xe_tile_sriov_err(tile, "LMTT invalidation failed (%pe)",
>> -				  ERR_PTR(err));
>> +		xe_log_err(tile, LMTT, err, "%s invalidation failed.",
>> +			   xe_sriov_printk_prefix(xe));
> 
> [Severity: Low]
> Does this format string need a trailing newline?
> 
> Without a trailing '\n' in xe_log_err(), the kernel printk system might leave
> the log line unterminated, potentially causing subsequent logs to be
> concatenated to this line.
Noted,I will update in the next patch. >
>>   	if (xe_device_has_mert(xe) && xe_tile_is_root(tile)) {
>>   		err = xe_mert_invalidate_lmtt(xe);
>>   		if (err)
>> -			xe_tile_sriov_err(tile, "MERT LMTT invalidation failed (%pe)",
>> -					  ERR_PTR(err));
>> +			xe_log_err(tile, LMTT, err,
>> +				   "%s MERT invalidation failed.\n",
>> +				   xe_sriov_printk_prefix(xe));
>>   	}
>>   }
>