Re: [PATCH v4 10/12] drm/xe/lmtt: Report invalidation errors using structured xe_log API

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1644 bytes --]


On 28-09-2026 02:51 pm, Dnyaneshwar Bhadane wrote:
> Replace xe_tile_sriov_err() with xe_log_err() using the LMTT component
> tag for LMTT and MERT invalidation failures, preserving the SR-IOV
> prefix in the log message.
>
> v2:
> - Drop logging error type in log (Mallesh)
>
> Signed-off-by: Dnyaneshwar Bhadane<dnyaneshwar.bhadane@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_lmtt.c | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_lmtt.c b/drivers/gpu/drm/xe/xe_lmtt.c
> index 0c726eda9390..fe77b3ec0680 100644
> --- a/drivers/gpu/drm/xe/xe_lmtt.c
> +++ b/drivers/gpu/drm/xe/xe_lmtt.c
> @@ -14,6 +14,7 @@
>   #include "xe_bo.h"
>   #include "xe_tlb_inval.h"
>   #include "xe_lmtt.h"
> +#include "xe_log.h"
>   #include "xe_map.h"
>   #include "xe_mert.h"
>   #include "xe_mmio.h"
> @@ -302,14 +303,15 @@ void xe_lmtt_invalidate_hw(struct xe_lmtt *lmtt)
>   
>   	err = lmtt_invalidate_hw(lmtt);
>   	if (err)
> -		xe_tile_sriov_err(tile, "LMTT invalidation failed (%pe)",
> -				  ERR_PTR(err));
> +		xe_log_err(tile, LMTT, err, "%s invalidation failed.",
Add trailing newline
> +			   xe_sriov_printk_prefix(xe));
hmm, We see lmtt_assert(lmtt, IS_SRIOV_PF(xe)); beginning of function, 
please check xe_sriov_printk_prefix? right.
>
>   	if (xe_device_has_mert(xe) && xe_tile_is_root(tile)) {
>   		err = xe_mert_invalidate_lmtt(xe);
>   		if (err)
> -			xe_tile_sriov_err(tile, "MERT LMTT invalidation failed (%pe)",
> -					  ERR_PTR(err));
> +			xe_log_err(tile, LMTT, err,
> +				   "%s MERT invalidation failed.\n",
> +				   xe_sriov_printk_prefix(xe));
ditto
>   	}
>   }
>   

[-- Attachment #2: Type: text/html, Size: 2674 bytes --]