Re: [PATCH v4 09/12] drm/xe/pci: Report unknown GMDID versions using structured xe_log API

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 28-09-2026 02:51 pm, Dnyaneshwar Bhadane wrote:
> Replace drm_err() with xe_log_err() using the REGS component tag when
> hardware reports unrecognized graphics or media IP versions during
> GMDID handling.
>
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
LGTM,
Reviewed-by: Mallesh Koujalagi <mallesh.koujalagi@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_pci.c | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 620f8a75086f..9089ded5fa44 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -719,8 +719,9 @@ static int handle_gmdid(struct xe_device *xe,
>   
>   	*graphics_ip = find_graphics_ip(ver);
>   	if (!*graphics_ip) {
> -		drm_err(&xe->drm, "Hardware reports unknown graphics version %u.%02u\n",
> -			ver / 100, ver % 100);
> +		xe_log_err(xe, REGS, -EINVAL,
> +			   "Hardware reports unknown graphics version %u.%02u\n",
> +			   ver / 100, ver % 100);
>   	}
>   
>   	ret = read_gmdid(xe, GMDID_MEDIA, &ver, media_revid);
> @@ -733,8 +734,9 @@ static int handle_gmdid(struct xe_device *xe,
>   
>   	*media_ip = find_media_ip(ver);
>   	if (!*media_ip) {
> -		drm_err(&xe->drm, "Hardware reports unknown media version %u.%02u\n",
> -			ver / 100, ver % 100);
> +		xe_log_err(xe, REGS, -EINVAL,
> +			   "Hardware reports unknown media version %u.%02u\n",
> +			   ver / 100, ver % 100);
>   	}
>   
>   	return 0;