Re: [PATCH v4 12/12] drm/xe/vram: Report VRAM errors using structured xe_log API

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] drm/xe: incomplete migration from drm_info() to xe_log_info()
--

commit 5e1a407ddc677420600cd04965b5a5fb8be4de13
Author: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>

drm/xe/vram: Report VRAM errors using structured xe_log API

This commit replaces drm_err() and drm_info() with structured
xe_log_err_fatal() and xe_log_info() APIs using the VRAM component tag.
The log locations for the "no CPU visible VRAM" error are also updated
to depend on the caller context.

> diff --git a/drivers/gpu/drm/xe/xe_vram.c b/drivers/gpu/drm/xe/xe_vram.c
> index fa06c7ae56b1c..6c8558042ad4b 100644
> --- a/drivers/gpu/drm/xe/xe_vram.c
> +++ b/drivers/gpu/drm/xe/xe_vram.c

[ ... ]

> @@ -320,7 +327,7 @@ int xe_vram_probe(struct xe_device *xe)
>  	err = determine_lmem_bar_size(xe, &lmem_bar);
>  	if (err)
>  		return err;
> -	drm_info(&xe->drm, "VISIBLE VRAM: %pa, %pa\n", &lmem_bar.io_start, &lmem_bar.io_size);
> +	xe_log_info(xe, VRAM, "VISIBLE VRAM: %pa, %pa\n", &lmem_bar.io_start, &lmem_bar.io_size);

[Severity: Medium]
The commit message states that drm_info() is replaced with xe_log_info() using
the VRAM component tag. Are there some unmodified drm_info() occurrences left
in the file that result in an incomplete refactoring?

For example, print_vram_region_info() still uses drm_info():

drivers/gpu/drm/xe/xe_vram.c:print_vram_region_info() {
    ...
	drm_info(drm,
		 "VRAM[%u]: Actual physical size %pa, usable size exclude stolen %pa, CPU accessible size %pa\n",
		 vram->id, &vram->actual_physical_size, &vram->usable_size, &vram->io_size);
    ...
}

Similarly, get_flat_ccs_offset() retains drm_info() without the component tag:

drivers/gpu/drm/xe/xe_vram.c:get_flat_ccs_offset() {
    ...
		drm_info(&xe->drm, "FLAT_CCS base:%llx, aligned:%s\n", offset,
			 str_yes_no(IS_ALIGNED(offset, SZ_128K)));
    ...
}

Should these instances also be converted to xe_log_info() to ensure a
consistent logging format during driver initialization?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260928092114.1610203-1-dnyaneshwar.bhadane@intel.com?part=12