public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH 00/12] Add support for Common SDP Transmission Line
@ 2026-04-13  3:53 Ankit Nautiyal
  2026-04-13  3:53 ` [PATCH 01/12] drm/i915/vrr: Add HAS_EMP_AS_SDP_TL macro Ankit Nautiyal
                   ` (15 more replies)
  0 siblings, 16 replies; 29+ messages in thread
From: Ankit Nautiyal @ 2026-04-13  3:53 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: ville.syrjala, arun.r.murthy, Ankit Nautiyal

Xe3p_lpd introduces new register bits to program a common SDP
Transmission line that will be used by the Hardware to position the
SDPs. Along with this, another new register is also added to stagger
the different SDPs.

This series adds support for programming the Common SDP Transmission Line
(CMN_SDP_TL) and its stagger control registers.

Rev2:
 - Add tracking for AS SDP Transmission line first. Instead of directly
   programming it in the register, compute the state during
   compute_config_late() and write the value from crtc_state.
   Readout from the register through a vrr helper, since the register is
   defined in context of VRR and will be used for both DP and HDMI VRR
   packets.
 - Add support to track other SDP transmission lines, instead of stagger
   values.
 - Compute the transmission lines in compute_config_late path and add
   readout.
 - Always write the Common SDP Transmission line and other stagger
   values, whether the packets are sent or not.
 - Dump SDP transmission lines in crtc_state.

Ankit Nautiyal (11):
  drm/i915/vrr: Add HAS_EMP_AS_SDP_TL macro
  drm/i915/vrr: Add helper to readback EMP_AS_SDP_TL
  drm/i915/vrr: Separate out helper to write EMP_AS_SDP_TL
  drm/i915/dp: Add helper to get AS SDP Transmission Line
  drm/i915/dp: Add crtc state for AS SDP transmission line
  drm/i915/dp: Store and use AS SDP transmission line from crtc state
  drm/i915/display: Add HAS_CMN_SDP_TL macro
  drm/i915/dp: Store SDP transmission lines in crtc_state
  drm/i915/dp: Introduce helpers to enable/disable CMN SDP Transmission
    line
  drm/i915/dp: Enable Common SDP Transmission line
  drm/i915/display: Dump SDP Transmission lines

Arun R Murthy (1):
  drm/i915/nvl: Add register definitions for common SDP Transmission
    Line

 .../drm/i915/display/intel_crtc_state_dump.c  |   8 +
 drivers/gpu/drm/i915/display/intel_ddi.c      |   4 +
 drivers/gpu/drm/i915/display/intel_display.c  |   7 +
 .../drm/i915/display/intel_display_device.h   |   2 +
 .../gpu/drm/i915/display/intel_display_regs.h |  19 ++
 .../drm/i915/display/intel_display_types.h    |  14 ++
 drivers/gpu/drm/i915/display/intel_dp.c       | 177 ++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_dp.h       |   5 +
 drivers/gpu/drm/i915/display/intel_vrr.c      |  48 +++--
 drivers/gpu/drm/i915/display/intel_vrr.h      |   1 +
 10 files changed, 274 insertions(+), 11 deletions(-)

-- 
2.45.2


^ permalink raw reply	[flat|nested] 29+ messages in thread
* [PATCH 00/12] Add support for Common SDP Transmission Line
@ 2026-04-16  2:44 Ankit Nautiyal
  2026-04-16  2:44 ` [PATCH 04/12] drm/i915/dp: Add helper to get AS " Ankit Nautiyal
  0 siblings, 1 reply; 29+ messages in thread
From: Ankit Nautiyal @ 2026-04-16  2:44 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: ville.syrjala, arun.r.murthy, jani.nikula, Ankit Nautiyal

Xe3p_lpd introduces new register bits to program a common SDP
Transmission line that will be used by the Hardware to position the
SDPs. Along with this, another new register is also added to stagger
the different SDPs.

This series adds support for programming the Common SDP Transmission Line
(CMN_SDP_TL) and its stagger control registers.

Rev2:
 - Add tracking for AS SDP Transmission line first. Instead of directly
   programming it in the register, compute the state during
   compute_config_late() and write the value from crtc_state.
   Readout from the register through a vrr helper, since the register is
   defined in context of VRR and will be used for both DP and HDMI VRR
   packets.
 - Add support to track other SDP transmission lines, instead of stagger
   values.
 - Compute the transmission lines in compute_config_late path and add
   readout.
 - Always write the Common SDP Transmission line and other stagger
   values, whether the packets are sent or not.
 - Dump SDP transmission lines in crtc_state.

Rev3:
 - Introduce new files for handling the Data Island Packets (DIPs)
   programming in one place. (Ville)
 - Extract the Transmission Line programming for
   HDMI Extended Metadata Packet (EMP) and Adaptive Sync SDP (AS SDP)
   i.e. EMP_AS_SDP_TL in the new file.
 - Add programming for Common Base SDP Transmission lines and other
   stagger offsets in the new file.
 - Add a #TODO to extract other helpers that deal with Data Island Packets
   and VIDEO_DIP registers.
 - Place the HAS_* Macros related to DIP in the intel_dip.h file
   instead of intel_display_devices.h (Jani) 
 - Make function names more descriptive and avoid overuse of multiple
   acronyms. (Jani)

Note:
 - Though I have fixed the naming as suggested in most places, I
   have retained HAS_EMP_AS_SDP_TL for the following reasons:
   1) Lack of an apt name that avoids the acronym for
      'Extended Metadata Packet Adaptive Sync Secondary Packet Transmission
      Line'.
   2) Keeping this name makes it easier to find and map with the exact name
      for such a complex register name.

   However, I am open to suggestions for a better name.

Ankit Nautiyal (11):
  drm/i915/dip: Add new file to handle Data Island Packet hardware
  drm/i915/vrr: Use the helper to write EMP_AS_SDP_TL register
  drm/i915/intel_dip: Add check for DP encoder
  drm/i915/dp: Add helper to get AS SDP Transmission Line
  drm/i915/display: Add crtc state for DIP transmission lines
  drm/i915/dip: Store and use AS SDP transmission line from crtc state
  drm/i915/display: Add HAS_COMMON_SDP_TL macro
  drm/i915/dp: Store SDP transmission lines in crtc_state
  drm/i915/dp: Introduce helpers to enable/disable CMN SDP Transmission
    line
  drm/i915/dip: Enable Common SDP Transmission line
  drm/i915/display: Dump DIP Transmission lines

Arun R Murthy (1):
  drm/i915/nvl: Add register definitions for common SDP Transmission
    Line

 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../drm/i915/display/intel_crtc_state_dump.c  |   9 +
 drivers/gpu/drm/i915/display/intel_ddi.c      |   5 +
 drivers/gpu/drm/i915/display/intel_dip.c      | 197 ++++++++++++++++++
 drivers/gpu/drm/i915/display/intel_dip.h      |  67 ++++++
 drivers/gpu/drm/i915/display/intel_dip_regs.h |  36 ++++
 drivers/gpu/drm/i915/display/intel_display.c  |   7 +
 .../drm/i915/display/intel_display_types.h    |   3 +
 drivers/gpu/drm/i915/display/intel_dp.c       |  23 ++
 drivers/gpu/drm/i915/display/intel_dp.h       |   2 +
 drivers/gpu/drm/i915/display/intel_vrr.c      |  13 +-
 drivers/gpu/drm/i915/display/intel_vrr_regs.h |   6 -
 drivers/gpu/drm/xe/Makefile                   |   1 +
 13 files changed, 353 insertions(+), 17 deletions(-)
 create mode 100644 drivers/gpu/drm/i915/display/intel_dip.c
 create mode 100644 drivers/gpu/drm/i915/display/intel_dip.h
 create mode 100644 drivers/gpu/drm/i915/display/intel_dip_regs.h

-- 
2.45.2


^ permalink raw reply	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2026-04-16  3:00 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-13  3:53 [PATCH 00/12] Add support for Common SDP Transmission Line Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 01/12] drm/i915/vrr: Add HAS_EMP_AS_SDP_TL macro Ankit Nautiyal
2026-04-13  8:31   ` Jani Nikula
2026-04-13  8:58     ` Nautiyal, Ankit K
2026-04-13  3:53 ` [PATCH 02/12] drm/i915/vrr: Add helper to readback EMP_AS_SDP_TL Ankit Nautiyal
2026-04-13  8:32   ` Jani Nikula
2026-04-13  9:25   ` Ville Syrjälä
2026-04-13  9:54     ` Nautiyal, Ankit K
2026-04-13 10:21       ` Ville Syrjälä
2026-04-13  3:53 ` [PATCH 03/12] drm/i915/vrr: Separate out helper to write EMP_AS_SDP_TL Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 04/12] drm/i915/dp: Add helper to get AS SDP Transmission Line Ankit Nautiyal
2026-04-13  8:34   ` Jani Nikula
2026-04-13  9:38     ` Nautiyal, Ankit K
2026-04-13  3:53 ` [PATCH 05/12] drm/i915/dp: Add crtc state for AS SDP transmission line Ankit Nautiyal
2026-04-13  8:36   ` Jani Nikula
2026-04-13  9:36     ` Nautiyal, Ankit K
2026-04-13  3:53 ` [PATCH 06/12] drm/i915/dp: Store and use AS SDP transmission line from crtc state Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 07/12] drm/i915/nvl: Add register definitions for common SDP Transmission Line Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 08/12] drm/i915/display: Add HAS_CMN_SDP_TL macro Ankit Nautiyal
2026-04-13  8:37   ` Jani Nikula
2026-04-13  3:53 ` [PATCH 09/12] drm/i915/dp: Store SDP transmission lines in crtc_state Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 10/12] drm/i915/dp: Introduce helpers to enable/disable CMN SDP Transmission line Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 11/12] drm/i915/dp: Enable Common " Ankit Nautiyal
2026-04-13  3:53 ` [PATCH 12/12] drm/i915/display: Dump SDP Transmission lines Ankit Nautiyal
2026-04-13  4:18 ` ✗ CI.checkpatch: warning for Add support for Common SDP Transmission Line (rev2) Patchwork
2026-04-13  4:19 ` ✓ CI.KUnit: success " Patchwork
2026-04-13  5:00 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-13  6:04 ` ✗ Xe.CI.FULL: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-04-16  2:44 [PATCH 00/12] Add support for Common SDP Transmission Line Ankit Nautiyal
2026-04-16  2:44 ` [PATCH 04/12] drm/i915/dp: Add helper to get AS " Ankit Nautiyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox