Re: [PATCH 07/12] drm/xe: Reduce DPT table alignment as in i915

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, Feb 21, 2025 at 10:17:26AM +0000, Tvrtko Ursulin wrote:
> There is some magic going on with DPT alignment values which are
> multiplied by 512, and then for specifically pinning the DPT table
> scaled back down.

This does follow same pattern as i915's intel_plane_pin_fb()
and it looks like it would deserve some refactor to make this
512 magic less magical and more clear.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

But I believe Ville has a better view on this, so it is better
to double check.

> 
> Make xe do it in the same way as i915.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
> ---
>  drivers/gpu/drm/xe/display/xe_fb_pin.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_fb_pin.c b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> index 496257a60009..6c85e03dfd79 100644
> --- a/drivers/gpu/drm/xe/display/xe_fb_pin.c
> +++ b/drivers/gpu/drm/xe/display/xe_fb_pin.c
> @@ -326,7 +326,7 @@ static struct i915_vma *__xe_pin_fb_vma(const struct intel_framebuffer *fb,
>  
>  	vma->bo = bo;
>  	if (intel_fb_uses_dpt(&fb->base))
> -		ret = __xe_pin_fb_vma_dpt(fb, view, vma, alignment);
> +		ret = __xe_pin_fb_vma_dpt(fb, view, vma, alignment / 512);
>  	else
>  		ret = __xe_pin_fb_vma_ggtt(fb, view, vma,  alignment);
>  	if (ret)
> -- 
> 2.48.0
>