* [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe()
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
@ 2026-07-31 3:54 ` Pan Chuang
2026-07-31 14:45 ` Frank Li
2026-07-31 3:54 ` [PATCH 05/11] usb: gadget: Remove redundant dev_err() Pan Chuang
` (3 subsequent siblings)
4 siblings, 1 reply; 7+ messages in thread
From: Pan Chuang @ 2026-07-31 3:54 UTC (permalink / raw)
To: Peter Griffin, André Draszik, Tudor Ambarus, Thinh Nguyen,
Greg Kroah-Hartman, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam,
moderated list:GOOGLE TENSOR SoC SUPPORT,
open list:GOOGLE TENSOR SoC SUPPORT,
open list:DESIGNWARE USB3 DRD IP DRIVER, open list,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OMAP USB SUPPORT
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/usb/dwc3/dwc3-google.c | 4 +---
drivers/usb/dwc3/dwc3-imx.c | 2 +-
drivers/usb/dwc3/dwc3-imx8mp.c | 4 +---
drivers/usb/dwc3/dwc3-keystone.c | 5 +----
drivers/usb/dwc3/dwc3-omap.c | 5 +----
5 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c
index 60ee4cc99b28..e581d407b872 100644
--- a/drivers/usb/dwc3/dwc3-google.c
+++ b/drivers/usb/dwc3/dwc3-google.c
@@ -235,10 +235,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d
dwc3_google_resume_irq,
IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
req_name, google);
- if (ret < 0) {
- dev_err(google->dev, "failed to request irq %s\n", req_name);
+ if (ret < 0)
return ret;
- }
return irq;
}
diff --git a/drivers/usb/dwc3/dwc3-imx.c b/drivers/usb/dwc3/dwc3-imx.c
index 973a486b544d..d967acd43d44 100644
--- a/drivers/usb/dwc3/dwc3-imx.c
+++ b/drivers/usb/dwc3/dwc3-imx.c
@@ -250,7 +250,7 @@ static int dwc3_imx_probe(struct platform_device *pdev)
IRQF_ONESHOT | IRQF_NO_AUTOEN,
irq_name, dwc_imx);
if (ret)
- return dev_err_probe(dev, ret, "failed to request IRQ #%d\n", irq);
+ return ret;
ret = device_add_software_node(dev, &dwc3_imx_swnode);
if (ret)
diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
index 1cf96540b66e..ee92a5efaa6e 100644
--- a/drivers/usb/dwc3/dwc3-imx8mp.c
+++ b/drivers/usb/dwc3/dwc3-imx8mp.c
@@ -273,10 +273,8 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
err = devm_request_threaded_irq(dev, irq, NULL, dwc3_imx8mp_interrupt,
IRQF_ONESHOT, dev_name(dev), dwc3_imx);
- if (err) {
- dev_err(dev, "failed to request IRQ #%d --> %d\n", irq, err);
+ if (err)
goto put_dwc3;
- }
device_set_wakeup_capable(dev, true);
pm_runtime_put(dev);
diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c
index 7ee1610162b9..8ad302abe883 100644
--- a/drivers/usb/dwc3/dwc3-keystone.c
+++ b/drivers/usb/dwc3/dwc3-keystone.c
@@ -144,11 +144,8 @@ static int kdwc3_probe(struct platform_device *pdev)
error = devm_request_irq(dev, irq, dwc3_keystone_interrupt, IRQF_SHARED,
dev_name(dev), kdwc);
- if (error) {
- dev_err(dev, "failed to request IRQ #%d --> %d\n",
- irq, error);
+ if (error)
goto err_irq;
- }
kdwc3_enable_irqs(kdwc);
diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
index fe74d11bb629..3bff775fbe4e 100644
--- a/drivers/usb/dwc3/dwc3-omap.c
+++ b/drivers/usb/dwc3/dwc3-omap.c
@@ -518,11 +518,8 @@ static int dwc3_omap_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, omap->irq, dwc3_omap_interrupt,
dwc3_omap_interrupt_thread, IRQF_SHARED,
"dwc3-omap", omap);
- if (ret) {
- dev_err(dev, "failed to request IRQ #%d --> %d\n",
- omap->irq, ret);
+ if (ret)
goto err2;
- }
dwc3_omap_enable_irqs(omap);
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe()
2026-07-31 3:54 ` [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-31 14:45 ` Frank Li
0 siblings, 0 replies; 7+ messages in thread
From: Frank Li @ 2026-07-31 14:45 UTC (permalink / raw)
To: Pan Chuang
Cc: Peter Griffin, André Draszik, Tudor Ambarus, Thinh Nguyen,
Greg Kroah-Hartman, Frank Li, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam,
moderated list:GOOGLE TENSOR SoC SUPPORT,
open list:GOOGLE TENSOR SoC SUPPORT,
open list:DESIGNWARE USB3 DRD IP DRIVER, open list,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
open list:OMAP USB SUPPORT
On Fri, Jul 31, 2026 at 11:54:38AM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"),
> devm_request_irq() and devm_request_threaded_irq() automatically log
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() and dev_err_probe() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/usb/dwc3/dwc3-google.c | 4 +---
> drivers/usb/dwc3/dwc3-imx.c | 2 +-
> drivers/usb/dwc3/dwc3-imx8mp.c | 4 +---
for imx part
Acked-by: Frank Li <Frank.Li@nxp.com>
> drivers/usb/dwc3/dwc3-keystone.c | 5 +----
> drivers/usb/dwc3/dwc3-omap.c | 5 +----
> 5 files changed, 5 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c
> index 60ee4cc99b28..e581d407b872 100644
> --- a/drivers/usb/dwc3/dwc3-google.c
> +++ b/drivers/usb/dwc3/dwc3-google.c
> @@ -235,10 +235,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d
> dwc3_google_resume_irq,
> IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> req_name, google);
> - if (ret < 0) {
> - dev_err(google->dev, "failed to request irq %s\n", req_name);
> + if (ret < 0)
> return ret;
> - }
>
> return irq;
> }
> diff --git a/drivers/usb/dwc3/dwc3-imx.c b/drivers/usb/dwc3/dwc3-imx.c
> index 973a486b544d..d967acd43d44 100644
> --- a/drivers/usb/dwc3/dwc3-imx.c
> +++ b/drivers/usb/dwc3/dwc3-imx.c
> @@ -250,7 +250,7 @@ static int dwc3_imx_probe(struct platform_device *pdev)
> IRQF_ONESHOT | IRQF_NO_AUTOEN,
> irq_name, dwc_imx);
> if (ret)
> - return dev_err_probe(dev, ret, "failed to request IRQ #%d\n", irq);
> + return ret;
>
> ret = device_add_software_node(dev, &dwc3_imx_swnode);
> if (ret)
> diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
> index 1cf96540b66e..ee92a5efaa6e 100644
> --- a/drivers/usb/dwc3/dwc3-imx8mp.c
> +++ b/drivers/usb/dwc3/dwc3-imx8mp.c
> @@ -273,10 +273,8 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
>
> err = devm_request_threaded_irq(dev, irq, NULL, dwc3_imx8mp_interrupt,
> IRQF_ONESHOT, dev_name(dev), dwc3_imx);
> - if (err) {
> - dev_err(dev, "failed to request IRQ #%d --> %d\n", irq, err);
> + if (err)
> goto put_dwc3;
> - }
>
> device_set_wakeup_capable(dev, true);
> pm_runtime_put(dev);
> diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c
> index 7ee1610162b9..8ad302abe883 100644
> --- a/drivers/usb/dwc3/dwc3-keystone.c
> +++ b/drivers/usb/dwc3/dwc3-keystone.c
> @@ -144,11 +144,8 @@ static int kdwc3_probe(struct platform_device *pdev)
>
> error = devm_request_irq(dev, irq, dwc3_keystone_interrupt, IRQF_SHARED,
> dev_name(dev), kdwc);
> - if (error) {
> - dev_err(dev, "failed to request IRQ #%d --> %d\n",
> - irq, error);
> + if (error)
> goto err_irq;
> - }
>
> kdwc3_enable_irqs(kdwc);
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index fe74d11bb629..3bff775fbe4e 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -518,11 +518,8 @@ static int dwc3_omap_probe(struct platform_device *pdev)
> ret = devm_request_threaded_irq(dev, omap->irq, dwc3_omap_interrupt,
> dwc3_omap_interrupt_thread, IRQF_SHARED,
> "dwc3-omap", omap);
> - if (ret) {
> - dev_err(dev, "failed to request IRQ #%d --> %d\n",
> - omap->irq, ret);
> + if (ret)
> goto err2;
> - }
> dwc3_omap_enable_irqs(omap);
> return 0;
>
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 05/11] usb: gadget: Remove redundant dev_err()
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-31 3:54 ` [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-31 3:54 ` Pan Chuang
2026-07-31 3:54 ` [PATCH 07/11] usb: misc: Remove redundant dev_err()/dev_err_probe() Pan Chuang
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Pan Chuang @ 2026-07-31 3:54 UTC (permalink / raw)
To: Greg Kroah-Hartman, Joel Stanley, Andrew Jeffery, Neal Liu,
Cristian Birsan, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
Herve Codina, Thierry Reding, Jonathan Hunter,
open list:USB SUBSYSTEM,
moderated list:ARM/ASPEED MACHINE SUPPORT,
moderated list:ARM/ASPEED MACHINE SUPPORT, open list,
open list:RENESAS RZ/N1 USBF CONTROLLER DRIVER,
open list:TEGRA ARCHITECTURE SUPPORT
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/usb/gadget/udc/aspeed-vhub/core.c | 4 +---
drivers/usb/gadget/udc/aspeed_udc.c | 4 +---
drivers/usb/gadget/udc/atmel_usba_udc.c | 5 +----
drivers/usb/gadget/udc/r8a66597-udc.c | 4 +---
drivers/usb/gadget/udc/renesas_usbf.c | 8 ++------
drivers/usb/gadget/udc/snps_udc_plat.c | 4 +---
drivers/usb/gadget/udc/tegra-xudc.c | 5 +----
7 files changed, 8 insertions(+), 26 deletions(-)
diff --git a/drivers/usb/gadget/udc/aspeed-vhub/core.c b/drivers/usb/gadget/udc/aspeed-vhub/core.c
index 4a8b9ff8368f..4ac990553a86 100644
--- a/drivers/usb/gadget/udc/aspeed-vhub/core.c
+++ b/drivers/usb/gadget/udc/aspeed-vhub/core.c
@@ -379,10 +379,8 @@ static int ast_vhub_probe(struct platform_device *pdev)
}
rc = devm_request_irq(&pdev->dev, vhub->irq, ast_vhub_irq, 0,
KBUILD_MODNAME, vhub);
- if (rc) {
- dev_err(&pdev->dev, "Failed to request interrupt\n");
+ if (rc)
goto err;
- }
dma_mask_ptr = (u64 *)of_device_get_match_data(&pdev->dev);
if (dma_mask_ptr) {
diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c
index 54f81e668009..08b24902c7b9 100644
--- a/drivers/usb/gadget/udc/aspeed_udc.c
+++ b/drivers/usb/gadget/udc/aspeed_udc.c
@@ -1568,10 +1568,8 @@ static int ast_udc_probe(struct platform_device *pdev)
rc = devm_request_irq(&pdev->dev, udc->irq, ast_udc_isr, 0,
KBUILD_MODNAME, udc);
- if (rc) {
- dev_err(&pdev->dev, "Failed to request interrupt\n");
+ if (rc)
goto err_cleanup;
- }
rc = usb_add_gadget_udc(&pdev->dev, &udc->gadget);
if (rc) {
diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 72a2f95ff018..18b4b2358d1e 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -2332,11 +2332,8 @@ static int usba_udc_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, irq, usba_udc_irq, 0,
"atmel_usba_udc", udc);
- if (ret) {
- dev_err(&pdev->dev, "Cannot request irq %d (error %d)\n",
- irq, ret);
+ if (ret)
return ret;
- }
udc->irq = irq;
if (udc->vbus_pin) {
diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c
index d190e16d43fc..915786c9628c 100644
--- a/drivers/usb/gadget/udc/r8a66597-udc.c
+++ b/drivers/usb/gadget/udc/r8a66597-udc.c
@@ -1894,10 +1894,8 @@ static int r8a66597_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, irq, r8a66597_irq, IRQF_SHARED,
udc_name, r8a66597);
- if (ret < 0) {
- dev_err(dev, "request_irq error (%d)\n", ret);
+ if (ret < 0)
goto clean_up2;
- }
INIT_LIST_HEAD(&r8a66597->gadget.ep_list);
r8a66597->gadget.ep0 = &r8a66597->ep[0].ep;
diff --git a/drivers/usb/gadget/udc/renesas_usbf.c b/drivers/usb/gadget/udc/renesas_usbf.c
index d67002ea049a..367c9e73f366 100644
--- a/drivers/usb/gadget/udc/renesas_usbf.c
+++ b/drivers/usb/gadget/udc/renesas_usbf.c
@@ -3335,19 +3335,15 @@ static int usbf_probe(struct platform_device *pdev)
if (irq < 0)
return irq;
ret = devm_request_irq(dev, irq, usbf_epc_irq, 0, "usbf-epc", udc);
- if (ret) {
- dev_err(dev, "cannot request irq %d err %d\n", irq, ret);
+ if (ret)
return ret;
- }
irq = platform_get_irq(pdev, 1);
if (irq < 0)
return irq;
ret = devm_request_irq(dev, irq, usbf_ahb_epc_irq, 0, "usbf-ahb-epc", udc);
- if (ret) {
- dev_err(dev, "cannot request irq %d err %d\n", irq, ret);
+ if (ret)
return ret;
- }
usbf_reg_bitset(udc, USBF_REG_AHBMCTR, USBF_SYS_WBURST_TYPE);
diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c b/drivers/usb/gadget/udc/snps_udc_plat.c
index db842a6de643..9e4f04476595 100644
--- a/drivers/usb/gadget/udc/snps_udc_plat.c
+++ b/drivers/usb/gadget/udc/snps_udc_plat.c
@@ -193,10 +193,8 @@ static int udc_plat_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, udc->irq, udc_irq, IRQF_SHARED,
"snps-udc", udc);
- if (ret < 0) {
- dev_err(dev, "Request irq %d failed for UDC\n", udc->irq);
+ if (ret < 0)
goto exit_dma;
- }
platform_set_drvdata(pdev, udc);
udc->chiprev = UDC_BCM_REV;
diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
index e9d33be02866..5042c13f92be 100644
--- a/drivers/usb/gadget/udc/tegra-xudc.c
+++ b/drivers/usb/gadget/udc/tegra-xudc.c
@@ -3803,11 +3803,8 @@ static int tegra_xudc_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, xudc->irq, tegra_xudc_irq, 0,
dev_name(&pdev->dev), xudc);
- if (err < 0) {
- dev_err(xudc->dev, "failed to claim IRQ#%u: %d\n", xudc->irq,
- err);
+ if (err < 0)
return err;
- }
xudc->clks = devm_kcalloc(&pdev->dev, xudc->soc->num_clks, sizeof(*xudc->clks),
GFP_KERNEL);
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 07/11] usb: misc: Remove redundant dev_err()/dev_err_probe()
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-31 3:54 ` [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe() Pan Chuang
2026-07-31 3:54 ` [PATCH 05/11] usb: gadget: Remove redundant dev_err() Pan Chuang
@ 2026-07-31 3:54 ` Pan Chuang
2026-07-31 3:54 ` [PATCH 08/11] usb: mtu3: Remove redundant dev_err() Pan Chuang
2026-07-31 3:54 ` [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe() Pan Chuang
4 siblings, 0 replies; 7+ messages in thread
From: Pan Chuang @ 2026-07-31 3:54 UTC (permalink / raw)
To: Al Cooper, Broadcom internal kernel review list,
Greg Kroah-Hartman, Florian Fainelli, Souradeep Chowdhury,
open list:BROADCOM BRCMSTB USB PIN MAP DRIVER,
moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE, open list,
open list:ARM/QUALCOMM MAILING LIST
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"),
devm_request_irq() and devm_request_threaded_irq() automatically log
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/usb/misc/brcmstb-usb-pinmap.c | 9 ++-------
drivers/usb/misc/qcom_eud.c | 2 +-
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c
index 1ce885e4184c..d8e9c80a9c2e 100644
--- a/drivers/usb/misc/brcmstb-usb-pinmap.c
+++ b/drivers/usb/misc/brcmstb-usb-pinmap.c
@@ -299,10 +299,8 @@ static int __init brcmstb_usb_pinmap_probe(struct platform_device *pdev)
brcmstb_usb_pinmap_ovr_isr,
IRQF_TRIGGER_RISING,
pdev->name, pdata);
- if (err < 0) {
- dev_err(&pdev->dev, "Error requesting IRQ\n");
+ if (err < 0)
return err;
- }
}
for (x = 0, pin = pdata->in_pins; x < pdata->in_count; x++, pin++) {
@@ -317,11 +315,8 @@ static int __init brcmstb_usb_pinmap_probe(struct platform_device *pdev)
IRQF_SHARED | IRQF_TRIGGER_RISING |
IRQF_TRIGGER_FALLING,
pdev->name, pin);
- if (err < 0) {
- dev_err(&pdev->dev, "Error requesting IRQ for %s pin\n",
- pin->name);
+ if (err < 0)
return err;
- }
}
dev_dbg(&pdev->dev, "Driver probe succeeded\n");
diff --git a/drivers/usb/misc/qcom_eud.c b/drivers/usb/misc/qcom_eud.c
index 926419ca560f..a7b9ed4ac071 100644
--- a/drivers/usb/misc/qcom_eud.c
+++ b/drivers/usb/misc/qcom_eud.c
@@ -225,7 +225,7 @@ static int eud_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(&pdev->dev, chip->irq, handle_eud_irq,
handle_eud_irq_thread, IRQF_ONESHOT, NULL, chip);
if (ret)
- return dev_err_probe(chip->dev, ret, "failed to allocate irq\n");
+ return ret;
enable_irq_wake(chip->irq);
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 08/11] usb: mtu3: Remove redundant dev_err()
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
` (2 preceding siblings ...)
2026-07-31 3:54 ` [PATCH 07/11] usb: misc: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-31 3:54 ` Pan Chuang
2026-07-31 3:54 ` [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe() Pan Chuang
4 siblings, 0 replies; 7+ messages in thread
From: Pan Chuang @ 2026-07-31 3:54 UTC (permalink / raw)
To: Chunfeng Yun, Greg Kroah-Hartman,
open list:MEDIATEK USB3 DRD IP DRIVER,
moderated list:MEDIATEK USB3 DRD IP DRIVER,
moderated list:MEDIATEK USB3 DRD IP DRIVER, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/usb/mtu3/mtu3_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/usb/mtu3/mtu3_core.c b/drivers/usb/mtu3/mtu3_core.c
index a40bf5bad2d5..990e2e8e6bc2 100644
--- a/drivers/usb/mtu3/mtu3_core.c
+++ b/drivers/usb/mtu3/mtu3_core.c
@@ -973,10 +973,8 @@ int ssusb_gadget_init(struct ssusb_mtk *ssusb)
ret = devm_request_threaded_irq(dev, mtu->irq, NULL, mtu3_irq,
IRQF_ONESHOT, dev_name(dev), mtu);
- if (ret) {
- dev_err(dev, "request irq %d failed!\n", mtu->irq);
+ if (ret)
goto irq_err;
- }
/* power down device IP for power saving by default */
mtu3_stop(mtu);
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 11/11] usb: typec: Remove redundant dev_err()/dev_err_probe()
2026-07-31 3:54 [PATCH 00/11] usb: Remove redundant error messages on IRQ request failure Pan Chuang
` (3 preceding siblings ...)
2026-07-31 3:54 ` [PATCH 08/11] usb: mtu3: Remove redundant dev_err() Pan Chuang
@ 2026-07-31 3:54 ` Pan Chuang
4 siblings, 0 replies; 7+ messages in thread
From: Pan Chuang @ 2026-07-31 3:54 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman, Matthias Brugger,
AngeloGioacchino Del Regno, open list:USB TYPEC CLASS, open list,
moderated list:ARM/Mediatek SoC support,
moderated list:ARM/Mediatek SoC support
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/usb/typec/anx7411.c | 4 +---
drivers/usb/typec/hd3ss3220.c | 4 +---
drivers/usb/typec/mux/it5205.c | 2 +-
drivers/usb/typec/tcpm/tcpci_maxim_core.c | 3 +--
drivers/usb/typec/tcpm/tcpci_mt6360.c | 1 -
drivers/usb/typec/tcpm/tcpci_mt6370.c | 2 +-
6 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
index 41df115912b9..2c41e00819f8 100644
--- a/drivers/usb/typec/anx7411.c
+++ b/drivers/usb/typec/anx7411.c
@@ -1529,10 +1529,8 @@ static int anx7411_i2c_probe(struct i2c_client *client)
IRQF_TRIGGER_FALLING |
IRQF_ONESHOT,
"anx7411-intp", plat);
- if (ret) {
- dev_err(dev, "fail to request irq\n");
+ if (ret)
goto free_wq;
- }
if (anx7411_typec_check_connection(plat))
dev_err(dev, "check status\n");
diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c
index 3e39b800e6b5..64648686bf8b 100644
--- a/drivers/usb/typec/hd3ss3220.c
+++ b/drivers/usb/typec/hd3ss3220.c
@@ -436,10 +436,8 @@ static int hd3ss3220_probe(struct i2c_client *client)
IRQF_TRIGGER_RISING |
IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
dev_name(hd3ss3220->dev), hd3ss3220);
- if (ret < 0) {
- dev_err(hd3ss3220->dev, "failed to get ID irq: %d\n", ret);
+ if (ret < 0)
goto err_put_fwnode;
- }
}
typec_cap.prefer_role = TYPEC_NO_PREFERRED_ROLE;
diff --git a/drivers/usb/typec/mux/it5205.c b/drivers/usb/typec/mux/it5205.c
index 5e1a120b2e3b..2ab2ba6a3cbd 100644
--- a/drivers/usb/typec/mux/it5205.c
+++ b/drivers/usb/typec/mux/it5205.c
@@ -250,7 +250,7 @@ static int it5205_probe(struct i2c_client *client)
if (ret) {
typec_mux_unregister(it->mux);
typec_switch_unregister(it->sw);
- return dev_err_probe(dev, ret, "Failed to request irq\n");
+ return ret;
}
}
diff --git a/drivers/usb/typec/tcpm/tcpci_maxim_core.c b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
index 998693a61839..52dbbbe53691 100644
--- a/drivers/usb/typec/tcpm/tcpci_maxim_core.c
+++ b/drivers/usb/typec/tcpm/tcpci_maxim_core.c
@@ -542,8 +542,7 @@ static int max_tcpci_probe(struct i2c_client *client)
(IRQF_TRIGGER_LOW | IRQF_ONESHOT), dev_name(chip->dev),
chip);
if (ret < 0)
- return dev_err_probe(&client->dev, ret,
- "IRQ initialization failed\n");
+ return ret;
ret = devm_device_init_wakeup(chip->dev);
if (ret)
diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
index 881ffacbfd77..d4010ea5183b 100644
--- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
+++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
@@ -167,7 +167,6 @@ static int mt6360_tcpc_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(mti->dev, mti->irq, NULL, mt6360_irq, IRQF_ONESHOT,
dev_name(&pdev->dev), mti);
if (ret) {
- dev_err(mti->dev, "Failed to register irq\n");
tcpci_unregister_port(mti->tcpci);
return ret;
}
diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
index 7d6c75c70985..2e85cb05ed37 100644
--- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
+++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
@@ -168,7 +168,7 @@ static int mt6370_tcpc_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, irq, NULL, mt6370_irq_handler,
IRQF_ONESHOT, dev_name(dev), priv);
if (ret)
- return dev_err_probe(dev, ret, "Failed to allocate irq\n");
+ return ret;
device_init_wakeup(dev, true);
dev_pm_set_wake_irq(dev, irq);
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread