Re: [PATCH 05/17] cxl/cache: Add cxl_cache driver

[Jonathan Cameron <jonathan.cameron@huawei.com>]

On Tue, 11 Nov 2025 15:40:20 -0600
Ben Cheatham <Benjamin.Cheatham@amd.com> wrote:

> Add the cxl_cache driver which will manage struct cxl_cachdev devices.

cxl_cachedev

> This driver will provide common management functions for some of a cache
> capable endpoint. This driver will also be responsible for validating
> the system's CXL.cache configuration.
> 
> The driver expects the device's cache capabilities to be prefetched by
> the endpoint-specific driver. The required capabilities can be gotten by
> calling cxl_accel_get_cache_info().
> 
> Signed-off-by: Ben Cheatham <Benjamin.Cheatham@amd.com>

Trivial thing inline.

> diff --git a/drivers/cxl/cache.c b/drivers/cxl/cache.c
> new file mode 100644
> index 000000000000..6f410fae9437
> --- /dev/null
> +++ b/drivers/cxl/cache.c

> +
> +/**
> + * devm_cxl_add_cachedev - Add a CXL cache device
> + * @host: devres alloc/release context and parent for the cachedev
> + * @cxlds: CXL device state to associate with the cachedev
> + * @ops: optional operations to run in cxl_cache::{probe,remove}() context

Run kernel doc over these as it will point out there is no such
parameter yet.

> + *
> + * Upon return the device will have had a chance to attach to the
> + * cxl_cache driver. This may fail if the CXL topology is not ready
> + * (hardware CXL link down, or software platform CXL root not attached)
> + * or the CXL.cache system configuration is invalid.
> + *
> + * The cache state of @cxlds needs to be populated before calling this function,
> + * use cxl_accel_read_cache_info() to do so.
> + */
> +struct cxl_cachedev *devm_cxl_add_cachedev(struct device *host,
> +					   struct cxl_dev_state *cxlds)