Re: [PATCH v2 5/5] cxl: Kill enum cxl_decoder_mode

[Ira Weiny <ira.weiny@intel.com>]

Dan Williams wrote:
> Now that the operational mode of DPA capacity (ram vs pmem... etc) is
> tracked in the partition, and no code paths have dependencies on the
> mode implying the partition index, the ambiguous 'enum cxl_decoder_mode'
> can be cleaned up, specifically this ambiguity on whether the operation
> mode implied anything about the partition order.
> 
> Endpoint decoders simply reference their assigned partition where the
> operational mode can be retrieved as partition mode.

You really seem to be defining a region mode not a partition mode.

I did a lot of work to resolve this for DCD interleave in the future.
This included the introduction of the DC region mode.  I __think__ that
what you have here will work fine.

However, from a user ABI standpoint I'm going to have to play games with
having the DCD partitions in a well defined sub-array such that the user
can specify which DCD partition they want to use.  So the user concept of
decoder mode does not really go away.

In the interest of urgency I'm going to give my tag on this.  But I would
have preferred this called region mode.  But I can see why partition mode
makes sense too.

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

[snip]