Re: [PATCH v2 5/5] cxl: Kill enum cxl_decoder_mode

[Ira Weiny <ira.weiny@intel.com>]

Dave Jiang wrote:
> 
> 
> On 1/22/25 10:42 AM, Ira Weiny wrote:
> > Dan Williams wrote:
> >> Now that the operational mode of DPA capacity (ram vs pmem... etc) is
> >> tracked in the partition, and no code paths have dependencies on the
> >> mode implying the partition index, the ambiguous 'enum cxl_decoder_mode'
> >> can be cleaned up, specifically this ambiguity on whether the operation
> >> mode implied anything about the partition order.
> >>
> >> Endpoint decoders simply reference their assigned partition where the
> >> operational mode can be retrieved as partition mode.
> > 
> > You really seem to be defining a region mode not a partition mode.
> > 
> > I did a lot of work to resolve this for DCD interleave in the future.
> > This included the introduction of the DC region mode.  I __think__ that
> > what you have here will work fine.
> > 
> > However, from a user ABI standpoint I'm going to have to play games with
> > having the DCD partitions in a well defined sub-array such that the user
> 
> Are you talking about instead of having additional elements in the partition array, DCD will have it's own array?

Not it's own.  But a well known sub-array.

Dan does not like that though.  He wants the partitions to be anonymous to
the user and based only on their attributes.  So I'll defer to that and
let the next person deal with the fall out if anyone ever makes an actual
device.

Ira