Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Guodong Xu <docular.xu@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org,
	kvm@vger.kernel.org, sashiko-reviews@lists.linux.dev
Subject: Re: [PATCH v3 07/15] dt-bindings: riscv: Add Zic64b extension description
Date: Thu, 4 Jun 2026 10:06:07 +0100	[thread overview]
Message-ID: <20260604-mating-multiple-458aafa93791@spud> (raw)
In-Reply-To: <CA+Ck9FYWCbHO6-BU48KLx_Lov7pJiSbAP8j3Te_uqFFq81rUjg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

On Thu, Jun 04, 2026 at 01:23:24PM +0800, Guodong Xu wrote:
> Hi Rob, Conor,
> 
> On Wed, Jun 3, 2026 at 7:29 AM <sashiko-bot@kernel.org> wrote:
> >
> > The properties block requires multi-letter extensions to be sorted
> > alphanumerically. Because '6' comes before 'c', would it be more accurate to
> > place zic64b before ziccamoa?
> 
> On a double check, I found here Sashiko is flagging a real ordering issue.
> (Although it exists before my submission.)
> 
> In current riscv/extensions.yaml, zic* entries are split into two groups:
> one (ziccamoa etc.) sits above the Zk* block, the other (zicbom, zimop,
> etc.) sits below it. This is wrong considering the rule says "# multi-letter
> extensions, sorted alphanumerically".
> 
> Would you like a standalone patch that re-sorts the zi*/zk* ordering
> properly? It's purely cosmetic.

Please.

> 
> If there are no objections I can send it as part of my v4.
> Let me know what you think.
> 
> BR,
> Guodong
> 
> >
> > Does it make sense to place zic64b in its strictly correct alphanumeric
> > position, rather than continuing the out-of-order grouping of the existing
> > cache-block extensions like zicbom?
> >
> > [ ... ]
> >
> > --
> > Sashiko AI review · https://sashiko.dev/#/patchset/20260603-rva23u64-hwprobe-v2-v3-0-5529a7b28384@gmail.com?part=7

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-06-04  9:06 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 11:11 [PATCH v3 00/15] riscv: hwprobe: Expose RVA23U64 base behavior Guodong Xu
2026-06-03 11:11 ` [PATCH v3 01/15] riscv: hwprobe.rst: Make indentation consistent Guodong Xu
2026-06-03 11:11 ` [PATCH v3 02/15] riscv: hwprobe.rst: Document EXT_ZICFISS and EXT_ZICFILP Guodong Xu
2026-06-03 11:11 ` [PATCH v3 03/15] riscv: Standardize extension capitalization Guodong Xu
2026-06-03 11:11 ` [PATCH v3 04/15] riscv: Add Zicclsm to cpufeature and hwprobe Guodong Xu
2026-06-03 11:12 ` [PATCH v3 05/15] riscv: Add Ziccamoa, Ziccif, Ziccrse, and Za64rs " Guodong Xu
2026-06-03 11:12 ` [PATCH v3 06/15] riscv: Add B to hwcap " Guodong Xu
2026-06-03 11:12 ` [PATCH v3 07/15] dt-bindings: riscv: Add Zic64b extension description Guodong Xu
2026-06-02 23:28   ` sashiko-bot
2026-06-04  5:23     ` Guodong Xu
2026-06-04  9:06       ` Conor Dooley [this message]
2026-06-03 11:12 ` [PATCH v3 08/15] riscv: Add Zic64b to cpufeature and hwprobe Guodong Xu
2026-06-02 23:28   ` sashiko-bot
2026-06-04  6:42     ` Guodong Xu
2026-06-04  9:17       ` Conor Dooley
2026-06-05  1:31         ` Guodong Xu
2026-06-04 16:28           ` Conor Dooley
2026-06-04 16:43           ` Qingwei Hu
2026-06-04 15:48   ` Andrew Jones
2026-06-03 11:12 ` [PATCH v3 09/15] riscv: dts: spacemit: k3: Add Zic64b ISA extension Guodong Xu
2026-06-03 11:12 ` [PATCH v3 10/15] riscv: dts: spacemit: k1: " Guodong Xu
2026-06-03 11:12 ` [PATCH v3 11/15] riscv: dts: sophgo: sg2044: " Guodong Xu
2026-06-03 11:12 ` [PATCH v3 12/15] riscv: Add a getter for user PMLEN support Guodong Xu
2026-06-03 11:12 ` [PATCH v3 13/15] riscv: cpufeature: Introduce ISA bases bitmap and rva23u64 detection Guodong Xu
2026-06-02 23:37   ` sashiko-bot
2026-06-04  6:46     ` Guodong Xu
2026-06-04  9:06       ` Conor Dooley
2026-06-03 11:12 ` [PATCH v3 14/15] riscv: cpu: Output isa bases lines in cpuinfo Guodong Xu
2026-06-03 11:12 ` [PATCH v3 15/15] riscv: hwprobe: Introduce rva23u64 base behavior Guodong Xu
2026-06-04 16:03 ` [PATCH v3 00/15] riscv: hwprobe: Expose RVA23U64 " Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260604-mating-multiple-458aafa93791@spud \
    --to=conor@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=docular.xu@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox