From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, dongcheng.yan@intel.com
Subject: Re: [PATCH v2 06/11] media: ccs-pll: Drop LINK_DECOUPLED flag
Date: Mon, 21 Apr 2025 23:03:31 +0300 [thread overview]
Message-ID: <20250421200331.GG17813@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20250417065354.311617-7-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Thu, Apr 17, 2025 at 09:53:49AM +0300, Sakari Ailus wrote:
> The LINK_DECOUPLED flag wasn't used by the PLL calculator other than
s/wasn't/isn't/
> printing it. The number of OP/VT lanes are already printed in any case.
> Thus drop the flag as it has no function.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> drivers/media/i2c/ccs-pll.c | 3 +--
> drivers/media/i2c/ccs-pll.h | 1 -
> drivers/media/i2c/ccs/ccs-core.c | 1 -
> drivers/media/i2c/ccs/ccs-quirk.c | 3 +--
> 4 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/i2c/ccs-pll.c b/drivers/media/i2c/ccs-pll.c
> index 66d046d576f7..16eb09462c8b 100644
> --- a/drivers/media/i2c/ccs-pll.c
> +++ b/drivers/media/i2c/ccs-pll.c
> @@ -124,9 +124,8 @@ static void print_pll(struct device *dev, const struct ccs_pll *pll)
> dev_dbg(dev, "pixel rate on CSI-2 bus:\t%u\n",
> pll->pixel_rate_csi);
>
> - dev_dbg(dev, "flags%s%s%s%s%s%s%s%s%s\n",
> + dev_dbg(dev, "flags%s%s%s%s%s%s%s%s\n",
> pll->flags & PLL_FL(LANE_SPEED_MODEL) ? " lane-speed" : "",
> - pll->flags & PLL_FL(LINK_DECOUPLED) ? " link-decoupled" : "",
> pll->flags & PLL_FL(EXT_IP_PLL_DIVIDER) ?
> " ext-ip-pll-divider" : "",
> pll->flags & PLL_FL(FLEXIBLE_OP_PIX_CLK_DIV) ?
> diff --git a/drivers/media/i2c/ccs-pll.h b/drivers/media/i2c/ccs-pll.h
> index 6eb1b1c68e1e..ee206e5b287b 100644
> --- a/drivers/media/i2c/ccs-pll.h
> +++ b/drivers/media/i2c/ccs-pll.h
> @@ -24,7 +24,6 @@
> #define CCS_PLL_FLAG_NO_OP_CLOCKS BIT(1)
> /* CCS PLL flags */
> #define CCS_PLL_FLAG_LANE_SPEED_MODEL BIT(2)
> -#define CCS_PLL_FLAG_LINK_DECOUPLED BIT(3)
> #define CCS_PLL_FLAG_EXT_IP_PLL_DIVIDER BIT(4)
> #define CCS_PLL_FLAG_FLEXIBLE_OP_PIX_CLK_DIV BIT(5)
> #define CCS_PLL_FLAG_FIFO_DERATING BIT(6)
> diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
> index 004d28c33287..06e0ba53f2a8 100644
> --- a/drivers/media/i2c/ccs/ccs-core.c
> +++ b/drivers/media/i2c/ccs/ccs-core.c
> @@ -3451,7 +3451,6 @@ static int ccs_probe(struct i2c_client *client)
> CCS_LIM(sensor, NUM_OF_VT_LANES) + 1;
> sensor->pll.op_lanes =
> CCS_LIM(sensor, NUM_OF_OP_LANES) + 1;
> - sensor->pll.flags |= CCS_PLL_FLAG_LINK_DECOUPLED;
> } else {
> sensor->pll.vt_lanes = sensor->pll.csi2.lanes;
> sensor->pll.op_lanes = sensor->pll.csi2.lanes;
> diff --git a/drivers/media/i2c/ccs/ccs-quirk.c b/drivers/media/i2c/ccs/ccs-quirk.c
> index e3d4c7a275bc..e48a4fa1f5dd 100644
> --- a/drivers/media/i2c/ccs/ccs-quirk.c
> +++ b/drivers/media/i2c/ccs/ccs-quirk.c
> @@ -190,8 +190,7 @@ static int jt8ev1_post_streamoff(struct ccs_sensor *sensor)
>
> static int jt8ev1_init(struct ccs_sensor *sensor)
> {
> - sensor->pll.flags |= CCS_PLL_FLAG_LANE_SPEED_MODEL |
> - CCS_PLL_FLAG_LINK_DECOUPLED;
> + sensor->pll.flags |= CCS_PLL_FLAG_LANE_SPEED_MODEL;
> sensor->pll.vt_lanes = 1;
> sensor->pll.op_lanes = sensor->pll.csi2.lanes;
>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2025-04-21 20:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 6:53 [PATCH v2 00/11] CCS PLL fixes and improvements Sakari Ailus
2025-04-17 6:53 ` [PATCH v2 01/11] media: ccs-pll: Start OP pre-PLL multiplier search from correct value Sakari Ailus
2025-04-21 19:50 ` Laurent Pinchart
2025-04-22 11:43 ` Sakari Ailus
2025-04-22 11:50 ` Laurent Pinchart
2025-04-22 12:07 ` Sakari Ailus
2025-04-17 6:53 ` [PATCH v2 02/11] media: ccs-pll: Start VT " Sakari Ailus
2025-04-21 19:53 ` Laurent Pinchart
2025-04-17 6:53 ` [PATCH v2 03/11] media: ccs-pll: Check for too high VT PLL multiplier in dual PLL case Sakari Ailus
2025-04-21 19:56 ` Laurent Pinchart
2025-04-17 6:53 ` [PATCH v2 04/11] media: ccs-pll: Correctly the upper limit of maximum op_pre_pll_clk_div Sakari Ailus
2025-04-21 20:01 ` Laurent Pinchart
2025-04-23 11:55 ` Sakari Ailus
2025-04-17 6:53 ` [PATCH v2 05/11] media: ccs-pll: Print a debug message on too high VT PLL OP clock Sakari Ailus
2025-04-21 20:02 ` Laurent Pinchart
2025-04-17 6:53 ` [PATCH v2 06/11] media: ccs-pll: Drop LINK_DECOUPLED flag Sakari Ailus
2025-04-21 20:03 ` Laurent Pinchart [this message]
2025-04-23 12:04 ` Sakari Ailus
2025-04-23 12:22 ` Laurent Pinchart
2025-04-17 6:53 ` [PATCH v2 07/11] media: ccs-pll: Print missing PLL flags Sakari Ailus
2025-04-21 20:05 ` Laurent Pinchart
2025-04-17 6:53 ` [PATCH v2 08/11] media: ccs-pll: Add a flag for even PLL multipliers Sakari Ailus
2025-04-21 20:19 ` Laurent Pinchart
2025-04-23 10:19 ` Sakari Ailus
2025-04-17 6:53 ` [PATCH v2 09/11] media: ccs-pll: Better validate VT PLL branch Sakari Ailus
2025-04-21 20:24 ` Laurent Pinchart
2025-04-23 10:26 ` Sakari Ailus
2025-04-17 6:53 ` [PATCH v2 10/11] media: ccs-pll: Print PLL calculator flags in the beginning Sakari Ailus
2025-04-21 20:25 ` Laurent Pinchart
2025-04-17 6:53 ` [PATCH v2 11/11] media: ccs-pll: Document the CCS PLL flags Sakari Ailus
2025-04-21 20:29 ` Laurent Pinchart
2025-04-22 11:49 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421200331.GG17813@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dongcheng.yan@intel.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox