Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Jon Hunter <jonathanh@nvidia.com>
To: Manikanta Maddireddy <mmaddireddy@nvidia.com>,
	bhelgaas@google.com, lpieralisi@kernel.org,
	kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	thierry.reding@gmail.com, kishon@kernel.org, arnd@arndb.de,
	gregkh@linuxfoundation.org, Frank.Li@nxp.com, den@valinux.co.jp,
	hongxing.zhu@nxp.com, jingoohan1@gmail.com, vidyas@nvidia.com,
	cassel@kernel.org, 18255117159@163.com
Cc: linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/9] Enhancements to pcie-tegra194 driver
Date: Fri, 27 Feb 2026 16:59:15 +0000	[thread overview]
Message-ID: <c8ac9a7e-5f37-4e5f-a33a-f1c3e94b4d19@nvidia.com> (raw)
In-Reply-To: <20260223184538.3084753-1-mmaddireddy@nvidia.com>


On 23/02/2026 18:45, Manikanta Maddireddy wrote:
> This series[1] was originally posted by Vidya Sagar, and I have rebased
> it onto 6.19.0-rc6-next. I addressed review comments and split this into
> two series, one for fixes and the other is for enhancements(current).
> I verified these patches on Jetson AGX Orin(Tegra234 SoC).
> 
> Disabling L1SS capability based on support-clkreq device tree property
> is moved to common DWC driver, so I reworked below patch to disable
> just L1.2 capability on Tegra234 SoC.
>   - PCI: tegra194: Disable L1.2 capability of Tegra234 EP
> 
> I added below new patch to tune the ASPM parameters, commit message of the
> patch has the details on the bug and fix.
>   - PCI: tegra194: Add ASPM L1 entrance latency config
> 
> I added more context in the commit message for below patch based on review
> comment in V3.
>   - PCI: tegra194: Remove IRQF_ONESHOT flag during Endpoint interrupt registration
> 
> Rest of the patches are same as the original V3 series, just rebased them on
> 6.19.0-rc6-next.
> 
> I fixed the missing PATCH prefix in the subject in V6.
> 
> Verification details.
>   - I verified both Root port and Endpoint mode controllers on Tegra234 SoC.
>   - Basic sanity Link up, configuration space access and BAR access are verified.
>   - I verified that ASPM L1.2 capability is disabled for Endpoint mode.
>   - I verified suspend to RAM tests with Endpoint mode.
> 
> [1] https://patchwork.kernel.org/project/linux-pci/patch/20221013183854.21087-1-vidyas@nvidia.com/
> 
> Manikanta Maddireddy (1):
>    PCI: tegra194: Add ASPM L1 entrance latency config
> 
> Vidya Sagar (8):
>    PCI: tegra194: Drive CLKREQ signal low explicitly
>    PCI: tegra194: Calibrate P2U for endpoint mode
>    PCI: tegra194: Remove IRQF_ONESHOT flag during Endpoint interrupt
>      registration
>    PCI: tegra194: Enable DMA interrupt
>    PCI: tegra194: Enable hardware hot reset mode in Endpoint
>    PCI: tegra194: Disable L1.2 capability of Tegra234 EP
>    dt-bindings: PCI: tegra194: Add monitor clock support
>    PCI: tegra194: Add core monitor clock support
> 
>   .../bindings/pci/nvidia,tegra194-pcie-ep.yaml |  6 +-
>   .../bindings/pci/nvidia,tegra194-pcie.yaml    |  6 +-
>   drivers/pci/controller/dwc/pcie-tegra194.c    | 67 ++++++++++++++++++-
>   3 files changed, 76 insertions(+), 3 deletions(-)
> 

For the series ...

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Tested-by: Jon Hunter <jonathanh@nvidia.com>

Thanks
Jon

-- 
nvpublic


      parent reply	other threads:[~2026-02-27 16:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 18:45 [PATCH v6 0/9] Enhancements to pcie-tegra194 driver Manikanta Maddireddy
2026-02-23 18:45 ` [PATCH v6 1/9] PCI: tegra194: Drive CLKREQ signal low explicitly Manikanta Maddireddy
2026-02-27 12:35   ` Vidya Sagar
2026-03-02 23:34     ` Bjorn Helgaas
2026-03-03  6:51       ` Manikanta Maddireddy
2026-02-23 18:45 ` [PATCH v6 2/9] PCI: tegra194: Calibrate P2U for endpoint mode Manikanta Maddireddy
2026-02-27 12:35   ` Vidya Sagar
2026-02-23 18:45 ` [PATCH v6 3/9] PCI: tegra194: Remove IRQF_ONESHOT flag during Endpoint interrupt registration Manikanta Maddireddy
2026-02-27 12:35   ` Vidya Sagar
2026-02-23 18:45 ` [PATCH v6 4/9] PCI: tegra194: Enable DMA interrupt Manikanta Maddireddy
2026-02-27 12:36   ` Vidya Sagar
2026-02-23 18:45 ` [PATCH v6 5/9] PCI: tegra194: Enable hardware hot reset mode in Endpoint Manikanta Maddireddy
2026-02-27 12:36   ` Vidya Sagar
2026-02-23 18:45 ` [PATCH v6 6/9] PCI: tegra194: Disable L1.2 capability of Tegra234 EP Manikanta Maddireddy
2026-02-27 12:36   ` Vidya Sagar
2026-02-23 18:45 ` [PATCH v6 7/9] dt-bindings: PCI: tegra194: Add monitor clock support Manikanta Maddireddy
2026-02-27 12:36   ` Vidya Sagar
2026-02-23 18:45 ` [PATCH v6 8/9] PCI: tegra194: Add core " Manikanta Maddireddy
2026-02-27 12:36   ` Vidya Sagar
2026-02-23 18:45 ` [PATCH v6 9/9] PCI: tegra194: Add ASPM L1 entrance latency config Manikanta Maddireddy
2026-02-27 12:36   ` Vidya Sagar
2026-02-27 16:59 ` Jon Hunter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8ac9a7e-5f37-4e5f-a33a-f1c3e94b4d19@nvidia.com \
    --to=jonathanh@nvidia.com \
    --cc=18255117159@163.com \
    --cc=Frank.Li@nxp.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=den@valinux.co.jp \
    --cc=gregkh@linuxfoundation.org \
    --cc=hongxing.zhu@nxp.com \
    --cc=jingoohan1@gmail.com \
    --cc=kishon@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=mmaddireddy@nvidia.com \
    --cc=robh@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vidyas@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox