From: Mike Anderson <andmike@us.ibm.com>
To: Kurt Garloff <garloff@suse.de>,
Linux SCSI list <linux-scsi@vger.kernel.org>,
Erik Andersen <andersen@codepoet.org>,
USB Storage List <usb-storage@one-eyed-alien.net>
Subject: Re: [PATCH] SCSI hotplug support
Date: Mon, 14 Oct 2002 09:19:22 -0700 [thread overview]
Message-ID: <20021014161922.GB2940@beaverton.ibm.com> (raw)
In-Reply-To: <20021014154719.GE21010@nbkurt.casa-etp.nl>
Kurt Garloff [garloff@suse.de] wrote:
> There are some scary comments around the scsi add/remove-single-device
> code which imply that this stuff only works by accident.
> I have used this functionality heavily for some time now and have never
> had a problem. Same for people I talked to.
> But it would probably make sense to review the code for possible
> problems.
>
> But I'm all for integrating your patch. It does not introduce new
> problems. And if it exposes old ones, because the code is more
> heavily used, this can only be good.
The comments may be pointing at the issues of the locking around the
host_queue. Adds will probably be ok as we init the scsi_device before
adding it to the list (so one would see a ready scsi_device or NULL
?maybe?). The remove could be an issue if something happened to be
traversing the list at the same time.
-andmike
--
Michael Anderson
andmike@us.ibm.com
next prev parent reply other threads:[~2002-10-14 16:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-14 5:40 [PATCH] SCSI hotplug support Erik Andersen
2002-10-14 7:06 ` Matthew Dharm
2002-10-14 7:12 ` Erik Andersen
2002-10-14 15:47 ` Kurt Garloff
2002-10-14 16:19 ` Mike Anderson [this message]
2002-10-14 20:41 ` Erik Andersen
2002-10-14 22:10 ` Mike Anderson
2002-10-14 20:46 ` Erik Andersen
2002-10-14 15:57 ` James Bottomley
2002-10-14 17:22 ` Mike Anderson
2002-10-14 17:30 ` Matthew Dharm
2002-10-14 17:39 ` James Bottomley
2002-10-14 19:11 ` Oliver Xymoron
2002-10-15 0:42 ` Kurt Garloff
2002-10-14 20:37 ` Erik Andersen
2002-10-14 21:07 ` James Bottomley
2002-10-14 21:54 ` Erik Andersen
2002-10-14 22:25 ` Doug Ledford
2002-10-15 5:25 ` Erik Andersen
2002-10-15 15:33 ` Doug Ledford
2002-10-15 18:18 ` Erik Andersen
2002-10-15 18:22 ` Doug Ledford
2002-10-15 18:45 ` Erik Andersen
2002-10-15 19:13 ` Doug Ledford
2002-10-15 19:32 ` Erik Andersen
2002-10-15 19:45 ` James Bottomley
2002-10-15 19:50 ` Scott Merritt
2002-10-15 19:55 ` Doug Ledford
2002-10-15 22:07 ` Erik Andersen
2002-10-16 2:40 ` Doug Ledford
2002-10-18 11:28 ` Erik Andersen
2002-10-15 21:43 ` Oliver Neukum
2002-10-15 22:07 ` Erik Andersen
2002-10-14 22:19 ` Oliver Neukum
2002-10-15 0:22 ` Doug Ledford
2002-10-15 7:53 ` Oliver Neukum
2002-10-15 14:35 ` Doug Ledford
2002-10-15 15:19 ` Oliver Neukum
2002-10-15 15:40 ` James Bottomley
2002-10-15 17:47 ` Erik Andersen
2002-10-15 18:34 ` Doug Ledford
2002-10-15 18:22 ` Scott Merritt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021014161922.GB2940@beaverton.ibm.com \
--to=andmike@us.ibm.com \
--cc=andersen@codepoet.org \
--cc=garloff@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=usb-storage@one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox