Re: [PATCH] SCSI hotplug support

[Erik Andersen <andersen@codepoet.org>]

On Tue Oct 15, 2002 at 03:13:30PM -0400, Doug Ledford wrote:
> On Tue, Oct 15, 2002 at 12:45:35PM -0600, Erik Andersen wrote:
> > On Tue Oct 15, 2002 at 02:22:47PM -0400, Doug Ledford wrote:
> > > On Mon, Oct 14, 2002 at 11:25:22PM -0600, Erik Andersen wrote:
> > > > 
> > > > It is called from within the insmod's context.
> > > 
> > > So it's called by what module then?  And what happens if we have a user 
> > > add a hard drive and it gets the module loaded and then attaches the 
> > > drive, then we attach another drive sometime later, and this time hotplug 
> > > doesn't do anything because the right module is already loaded?  How does 
> > > the drive get added then?  Am I missing something?
> > 
> > Oops.  I spoke wrongly....  It is called from within
> > /sbin/hotplug's context.
> 
> Then what the sam hell has all this crap been for!?!?  We've been saying 
> all along "Add the device from hotplug instead of kernel module", and now 
> you tell us that it's already happening from hotplug's context?  If it's 
> already happening from hotplug's context, then why not just do the 
> fprintf(); that I put in one of my emails and be done with it?  And what 

The main reason why I'd prefer to put this stuff into the sbp2
driver is to avoid 1394 layering violations. For ieee1394
devices, the 1394 nodemgr makes the hotplug calls.  But it does
the hotplug thing for all 1394 devices, and has no knowledge of
whether a device is an SBP-2 device (one that need to be
connected to the SCSI subsystem).  I suspect the 1394 maintainers
would reject patches that infect the nodemgr with SBP-2 and/or
SCSI specific stuff.  Sigh.  We seem to be at an impasse.  We
either screw up SCSI or we screw up 1394... 

> about the scenario I asked about in my last email regarding a second disc 
> and the situation where no module needs loaded?  How is that handled?

Same deal.  The 1394 nodemgr invokes /sbin/hotplug.

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--