Re: [PATCH] SCSI hotplug support

[Oliver Neukum <oliver@neukum.name>]

> You guys aren't thinking.  Come on, what's the realistic difference in the
> hot plug user space manager in the two cases:
>
> Case 1, scsi does the attach, hot plug does the rest:
>
> hot_plug_attach_notifier(dev_t device)
> {
>   do stuff..
> }
>
> Case 2, scsi doesn't do the attach:
> hot_plug_attach_notifier(int host, int bus, int target, int lun)
> {
>   fprintf(/proc/scsi/scsi, "scsi add-single-device %d %d %d %d", host,
> bus, target, lun);
>   if(device_added_successfully) {
>     do stuff..
>   }
> }

It would have to be:
hot_plug_attach_notifier(int host, int bus, int target, int lun)
{
fprintf(/proc/scsi/scsi, "scsi add-single-device %d %d %d %d", host, bus, target, lun);
dev = find_matching_device(host, bus, target, lun);
if (!dev)
	exit();
err = check_for_device_still_present();
if (err)
	exit();
do_stuff(dev);
}

> Now, please, someone tell me why everyone is whining about user space
> doing so little to accomplish what the much larger patch that was
> posted does in kernel space?  My point is, and was, that since we need the
> user space manager *anyway* to handle things the kernel will *never*

We don't need it. We may want to have it. It works without it, not as
well, but it works.

> Besides, I've not heard anyone address my concerns about what context the
> disc attach is done in with the kernel space patch.

Shouldn't we discuss this when we conclude that it's worth doing at all?

	Regards
		Oliver