Re: [PATCH] SCSI hotplug support

[Erik Andersen <andersen@codepoet.org>]

On Mon Oct 14, 2002 at 09:19:22AM -0700, Mike Anderson wrote:
> Kurt Garloff [garloff@suse.de] wrote:
> > There are some scary comments around the scsi add/remove-single-device
> > code which imply that this stuff only works by accident. 
> > I have used this functionality heavily for some time now and have never 
> > had a problem. Same for people I talked to.
> > But it would  probably make sense to review the code for possible
> > problems.
> > 
> > But I'm all for integrating your patch. It does not introduce new
> > problems. And if it exposes old ones, because the code is more
> > heavily used, this can only be good.
> 
> The comments may be pointing at the issues of the locking around the
> host_queue. Adds will probably be ok as we init the scsi_device before

It was my understanding that the comments (which were present
long before I changed anything) refer mainly to the fact that
hotswapping with a normal SCSI subsystem (without additional
electronic support for hotswapping) is electrically unsafe and is
likely to fry up your drives and your SCSI host controller.  For
people with hotswap safe hardware (or using ieee1394 or usb mass
storage devices), hotswapping is perfectly normal and safe, and
the scarry comments do not apply.

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--