[PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks

[PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks

[hasunpark]

From: Hasun Park <hasunpark@gmail.com>

Hi,

This series adds ACP70 platform quirks for ASUS ProArt PX13
(HN7306EA/HN7306EAC).

The goal is to keep platform selection on the expected SoundWire path and
add the required ACP70 machine/quirk entries for this board family.

Baseline (without this series):
  $ cat /proc/asound/cards
   0 [Generic        ]: HDA-Intel - HD-Audio Generic
                        HD-Audio Generic at 0xa0440000 irq 160
   1 [acppdmmach     ]: acp-pdm-mach - acp-pdm-mach
                        ASUSTeKCOMPUTERINC.-ProArtPX13HN7306EAC-1.0-HN7306EAC

Result (with this series applied):
  $ cat /proc/asound/cards
   0 [Generic        ]: HDA-Intel - HD-Audio Generic
   1 [amdsoundwire   ]: amd-soundwire - amd-soundwire

  $ aplay -l
   card 1: amdsoundwire [amd-soundwire], device 0: ... rt721 ...
   card 1: amdsoundwire [amd-soundwire], device 2: ... SmartAmp ...

  $ arecord -l
   card 1: amdsoundwire [amd-soundwire], device 1: ... rt721 ...
   card 1: amdsoundwire [amd-soundwire], device 3: ... SmartAmp ...
   card 1: amdsoundwire [amd-soundwire], device 4: ... acp-dmic ...

Patch summary:
  1. Add DMI override for ACP70 ACPI config flag handling.
  2. Add ACP70 SoundWire machine link for rt721 + tas2783x2.
  3. Add ASUS HN7306EA quirk in legacy SDW machine table.

Hasun Park (3):
  ASoC: amd: acp: add DMI override for ACP70 flag
  ASoC: amd: acp: add PX13 SoundWire machine link for rt721+tas2783x2
  ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

 sound/soc/amd/acp-config.c               | 15 +++++-
 sound/soc/amd/acp/acp-sdw-legacy-mach.c  |  8 ++++
 sound/soc/amd/acp/amd-acp70-acpi-match.c | 61 ++++++++++++++++++++++++
 3 files changed, 83 insertions(+), 1 deletion(-)


base-commit: 5b12bef92c1dca68a0e6ae42f6c51dfafb58e322
-- 
2.53.0

[PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag

[hasunpark]

From: Hasun Park <hasunpark@gmail.com>

Some ASUS ProArt PX13 systems expose ACP ACPI config flags that can
select a non-working fallback path.

Add a DMI override in snd_amd_acp_find_config() for ACP70+ boards and
return 0 so ACP ACPI flag-based selection is skipped on this platform.

This keeps machine driver selection on the intended SoundWire path.

Signed-off-by: Hasun Park <hasunpark@gmail.com>
---
 sound/soc/amd/acp-config.c | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/sound/soc/amd/acp-config.c b/sound/soc/amd/acp-config.c
index 365209ea53f3..1604ed679224 100644
--- a/sound/soc/amd/acp-config.c
+++ b/sound/soc/amd/acp-config.c
@@ -23,6 +23,16 @@
 
 static int acp_quirk_data;
 
+static const struct dmi_system_id acp70_acpi_flag_override_table[] = {
+	{
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "HN7306EA"),
+		},
+	},
+	{}
+};
+
 static const struct config_entry config_table[] = {
 	{
 		.flags = FLAG_AMD_SOF,
@@ -186,8 +196,11 @@ int snd_amd_acp_find_config(struct pci_dev *pci)
 	 */
 	if (!pci->revision)
 		return 0;
-	else if (pci->revision >= ACP_7_0_REV)
+	else if (pci->revision >= ACP_7_0_REV) {
+		if (dmi_check_system(acp70_acpi_flag_override_table))
+			return 0;
 		return snd_amd_acp_acpi_find_config(pci);
+	}
 
 	for (i = 0; i < ARRAY_SIZE(config_table); i++, table++) {
 		if (table->device != device)
-- 
2.53.0

Re: [PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag

[Mukunda,Vijendar]

On 08/03/26 20:46, hasunpark@gmail.com wrote:
> [You don't often get email from hasunpark@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: Hasun Park <hasunpark@gmail.com>
>
> Some ASUS ProArt PX13 systems expose ACP ACPI config flags that can
> select a non-working fallback path.
>
> Add a DMI override in snd_amd_acp_find_config() for ACP70+ boards and
> return 0 so ACP ACPI flag-based selection is skipped on this platform.
>
> This keeps machine driver selection on the intended SoundWire path.

This patch should be dropped.
To avoid overgrowing DMI quirks table, we have introduced "acp-audio-config-flag"
which should be updated based on platform hw configuration and required driver
solution to be loaded.

ASUS has to update the BIOS by changing "acp-audio-config-flag" to zero.

>
> Signed-off-by: Hasun Park <hasunpark@gmail.com>
> ---
>  sound/soc/amd/acp-config.c | 15 ++++++++++++++-
>  1 file changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/acp-config.c b/sound/soc/amd/acp-config.c
> index 365209ea53f3..1604ed679224 100644
> --- a/sound/soc/amd/acp-config.c
> +++ b/sound/soc/amd/acp-config.c
> @@ -23,6 +23,16 @@
>
>  static int acp_quirk_data;
>
> +static const struct dmi_system_id acp70_acpi_flag_override_table[] = {
> +       {
> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "HN7306EA"),
> +               },
> +       },
> +       {}
> +};
> +
>  static const struct config_entry config_table[] = {
>         {
>                 .flags = FLAG_AMD_SOF,
> @@ -186,8 +196,11 @@ int snd_amd_acp_find_config(struct pci_dev *pci)
>          */
>         if (!pci->revision)
>                 return 0;
> -       else if (pci->revision >= ACP_7_0_REV)
> +       else if (pci->revision >= ACP_7_0_REV) {
> +               if (dmi_check_system(acp70_acpi_flag_override_table))
> +                       return 0;
>                 return snd_amd_acp_acpi_find_config(pci);
> +       }
>
>         for (i = 0; i < ARRAY_SIZE(config_table); i++, table++) {
>                 if (table->device != device)
> --
> 2.53.0
>

Re: [PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]

On Mon, Mar 09, 2026 at 11:03:21AM +0530, Mukunda,Vijendar wrote:
> On 08/03/26 20:46, hasunpark@gmail.com wrote:

> > Add a DMI override in snd_amd_acp_find_config() for ACP70+ boards and
> > return 0 so ACP ACPI flag-based selection is skipped on this platform.

> This patch should be dropped.
> To avoid overgrowing DMI quirks table, we have introduced "acp-audio-config-flag"
> which should be updated based on platform hw configuration and required driver
> solution to be loaded.

> ASUS has to update the BIOS by changing "acp-audio-config-flag" to zero.

This is a good thing to have going forward but I don't think we can
require that people get or apply firmware updates for existing systems,
there's no guarantee that vendors will make them and the process of
getting and applying the update may not be trivial, particularly for
people running Linux on a system the vendor shipped with Windows.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag

[Mario Limonciello]

On 3/9/2026 6:34 AM, Mark Brown wrote:
> On Mon, Mar 09, 2026 at 11:03:21AM +0530, Mukunda,Vijendar wrote:
>> On 08/03/26 20:46, hasunpark@gmail.com wrote:
> 
>>> Add a DMI override in snd_amd_acp_find_config() for ACP70+ boards and
>>> return 0 so ACP ACPI flag-based selection is skipped on this platform.
> 
>> This patch should be dropped.
>> To avoid overgrowing DMI quirks table, we have introduced "acp-audio-config-flag"
>> which should be updated based on platform hw configuration and required driver
>> solution to be loaded.
> 
>> ASUS has to update the BIOS by changing "acp-audio-config-flag" to zero.
> 
> This is a good thing to have going forward but I don't think we can
> require that people get or apply firmware updates for existing systems,
> there's no guarantee that vendors will make them and the process of
> getting and applying the update may not be trivial, particularly for
> people running Linux on a system the vendor shipped with Windows.

At least for pre-production hardware we should not accept quirks like 
this.  Vendors should populate their BIOS properly.

But I gather this is a production hardware and the vendor made a 
mistake.  In this case I guess the vendor doesn't make Linux BIOS update 
easy either, and thus the reporter suffers.

So maybe we should let this one go, but let's look through these closely 
if more come.

We really don't want to end up with a giant quirk table of BIOS mistakes.

Re: [PATCH 1/3] ASoC: amd: acp: add DMI override for ACP70 flag

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]

On Mon, Mar 09, 2026 at 10:31:00AM -0500, Mario Limonciello wrote:
> On 3/9/2026 6:34 AM, Mark Brown wrote:
> > On Mon, Mar 09, 2026 at 11:03:21AM +0530, Mukunda,Vijendar wrote:

> > > ASUS has to update the BIOS by changing "acp-audio-config-flag" to zero.

> > This is a good thing to have going forward but I don't think we can
> > require that people get or apply firmware updates for existing systems,
> > there's no guarantee that vendors will make them and the process of
> > getting and applying the update may not be trivial, particularly for
> > people running Linux on a system the vendor shipped with Windows.

> At least for pre-production hardware we should not accept quirks like this.
> Vendors should populate their BIOS properly.

Yeah, for preproduction that's definitely reasonable in the normal
course of affairs.

> But I gather this is a production hardware and the vendor made a mistake.
> In this case I guess the vendor doesn't make Linux BIOS update easy either,
> and thus the reporter suffers.

> So maybe we should let this one go, but let's look through these closely if
> more come.

> We really don't want to end up with a giant quirk table of BIOS mistakes.

I mean, that's idiomatic for ACPI :(

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH 2/3] ASoC: amd: acp: add PX13 SoundWire machine link for rt721+tas2783x2

[hasunpark]

From: Hasun Park <hasunpark@gmail.com>

Add an ACP70 SoundWire machine entry for ASUS PX13
(HN7306EA/HN7306EAC) with rt721 and two TAS2783 amps on link1.

Describe rt721 with jack/DMIC endpoints on this platform and add
explicit left/right TAS2783 speaker endpoint mapping via name prefixes.

Signed-off-by: Hasun Park <hasunpark@gmail.com>
---
 sound/soc/amd/acp/amd-acp70-acpi-match.c | 61 ++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/sound/soc/amd/acp/amd-acp70-acpi-match.c b/sound/soc/amd/acp/amd-acp70-acpi-match.c
index 7a567ba02292..1ae43df5da6c 100644
--- a/sound/soc/amd/acp/amd-acp70-acpi-match.c
+++ b/sound/soc/amd/acp/amd-acp70-acpi-match.c
@@ -69,6 +69,28 @@ static const struct snd_soc_acpi_endpoint jack_amp_g1_dmic_endpoints[] = {
 	},
 };
 
+static const struct snd_soc_acpi_endpoint jack_dmic_endpoints[] = {
+	/* Jack Endpoint */
+	{
+		.num = 0,
+		.aggregated = 0,
+		.group_position = 0,
+		.group_id = 0,
+	},
+	/* DMIC Endpoint */
+	{
+		/*
+		 * rt721 endpoint #2 maps to AIF3 (internal DMIC capture).
+		 * Endpoint #1 is AIF2 amp path and is handled by external amps
+		 * on this platform.
+		 */
+		.num = 2,
+		.aggregated = 0,
+		.group_position = 0,
+		.group_id = 0,
+	},
+};
+
 static const struct snd_soc_acpi_adr_device rt712_vb_1_group1_adr[] = {
 	{
 		.adr = 0x000130025D071201ull,
@@ -563,6 +585,40 @@ static const struct snd_soc_acpi_link_adr acp70_rt1320_l0_rt722_l1[] = {
 	{}
 };
 
+static const struct snd_soc_acpi_adr_device rt721_l1u0_tas2783x2_l1u8b_adr[] = {
+	{
+		.adr = 0x000130025D072101ull,
+		/*
+		 * On this platform speakers are provided by two TAS2783 amps.
+		 * Keep rt721 as UAJ + DMIC only.
+		 */
+		.num_endpoints = ARRAY_SIZE(jack_dmic_endpoints),
+		.endpoints = jack_dmic_endpoints,
+		.name_prefix = "rt721",
+	},
+	{
+		.adr = 0x0001380102000001ull,
+		.num_endpoints = 1,
+		.endpoints = &spk_l_endpoint,
+		.name_prefix = "tas2783-1",
+	},
+	{
+		.adr = 0x00013B0102000001ull,
+		.num_endpoints = 1,
+		.endpoints = &spk_r_endpoint,
+		.name_prefix = "tas2783-2",
+	},
+};
+
+static const struct snd_soc_acpi_link_adr acp70_rt721_l1u0_tas2783x2_l1u8b[] = {
+	{
+		.mask = BIT(1),
+		.num_adr = ARRAY_SIZE(rt721_l1u0_tas2783x2_l1u8b_adr),
+		.adr_d = rt721_l1u0_tas2783x2_l1u8b_adr,
+	},
+	{}
+};
+
 struct snd_soc_acpi_mach snd_soc_acpi_amd_acp70_sdw_machines[] = {
 	{
 		.link_mask = BIT(0) | BIT(1),
@@ -650,6 +706,11 @@ struct snd_soc_acpi_mach snd_soc_acpi_amd_acp70_sdw_machines[] = {
 		.machine_check = snd_soc_acpi_amd_sdca_is_device_rt712_vb,
 		.drv_name = "amd_sdw",
 	},
+	{
+		.link_mask = BIT(1),
+		.links = acp70_rt721_l1u0_tas2783x2_l1u8b,
+		.drv_name = "amd_sdw",
+	},
 	{},
 };
 EXPORT_SYMBOL(snd_soc_acpi_amd_acp70_sdw_machines);
-- 
2.53.0

[PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[hasunpark]

From: Hasun Park <hasunpark@gmail.com>

Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
machine driver.

Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
platform-specific jack/DMIC quirk path is selected.

Signed-off-by: Hasun Park <hasunpark@gmail.com>
---
 sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
index c30ccf23005a..d22b71e3fd2d 100644
--- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
+++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
@@ -111,6 +111,14 @@ static const struct dmi_system_id soc_sdw_quirk_table[] = {
 		},
 		.driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
 	},
+	{
+		.callback = soc_sdw_quirk_cb,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "HN7306EA"),
+		},
+		.driver_data = (void *)(RT711_JD1 | ASOC_SDW_ACP_DMIC),
+	},
 	{}
 };
 
-- 
2.53.0

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Mukunda,Vijendar]

On 08/03/26 20:46, hasunpark@gmail.com wrote:
> [You don't often get email from hasunpark@gmail.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> From: Hasun Park <hasunpark@gmail.com>
>
> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
> machine driver.
>
> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
> platform-specific jack/DMIC quirk path is selected.

As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case?
If you are using RT721 (UAJ + DMIC combination) below quirk is not required.
>
> Signed-off-by: Hasun Park <hasunpark@gmail.com>
> ---
>  sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> index c30ccf23005a..d22b71e3fd2d 100644
> --- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> +++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
> @@ -111,6 +111,14 @@ static const struct dmi_system_id soc_sdw_quirk_table[] = {
>                 },
>                 .driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
>         },
> +       {
> +               .callback = soc_sdw_quirk_cb,
> +               .matches = {
> +                       DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "HN7306EA"),
> +               },
> +               .driver_data = (void *)(RT711_JD1 | ASOC_SDW_ACP_DMIC),
> +       },
>         {}
>  };
>
> --
> 2.53.0
>

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote:
> On 08/03/26 20:46, hasunpark@gmail.com wrote:
> > From: Hasun Park <hasunpark@gmail.com>

> > Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
> > machine driver.

> > Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
> > platform-specific jack/DMIC quirk path is selected.

> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case?
> If you are using RT721 (UAJ + DMIC combination) below quirk is not required.

Presumably nothing stops the system integrator wiring a DMIC directly to
the SoC even if the CODEC can also use it?  It doesn't seem an obviously
silly configuration.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Mukunda,Vijendar]

On 11/03/26 22:51, Mark Brown wrote:
> On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote:
>> On 08/03/26 20:46, hasunpark@gmail.com wrote:
>>> From: Hasun Park <hasunpark@gmail.com>
>>> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
>>> machine driver.
>>> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
>>> platform-specific jack/DMIC quirk path is selected.
>> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case?
>> If you are using RT721 (UAJ + DMIC combination) below quirk is not required.
> Presumably nothing stops the system integrator wiring a DMIC directly to
> the SoC even if the CODEC can also use it?  It doesn't seem an obviously
> silly configuration.

On this platform Soundwire Codec RT721 already comes up with DMIC
endpoint. As per our understanding current soundwire topology points to
use RT721 + TI codecs. ACP DMIC is not being used.
If we want to use ACP PDM DMIC where DMIC's are connected to SOC and 
routed to ACP PDM controller instead of Soundwire Codec (Which supports
DMIC path), then ACP_PDM_DMIC quirk should be enabled.

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Mukunda,Vijendar]

On 11/03/26 23:02, Mukunda,Vijendar wrote:
> On 11/03/26 22:51, Mark Brown wrote:
>> On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote:
>>> On 08/03/26 20:46, hasunpark@gmail.com wrote:
>>>> From: Hasun Park <hasunpark@gmail.com>
>>>> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
>>>> machine driver.
>>>> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
>>>> platform-specific jack/DMIC quirk path is selected.
>>> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case?
>>> If you are using RT721 (UAJ + DMIC combination) below quirk is not required.
>> Presumably nothing stops the system integrator wiring a DMIC directly to
>> the SoC even if the CODEC can also use it?  It doesn't seem an obviously
>> silly configuration.
> On this platform Soundwire Codec RT721 already comes up with DMIC
> endpoint. As per our understanding current soundwire topology points to
> use RT721 + TI codecs. ACP DMIC is not being used.
> If we want to use ACP PDM DMIC where DMIC's are connected to SOC and 
> routed to ACP PDM controller instead of Soundwire Codec (Which supports
> DMIC path), then ACP_PDM_DMIC quirk should be enabled.

We have cross-checked hw configuration. This platform uses DMIC connected
to Soundwire codec(ALC721). This patch should be dropped.
>
>

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

On Thu, Mar 12, 2026 at 12:19:48PM +0530, Mukunda,Vijendar wrote:

> We have cross-checked hw configuration. This platform uses DMIC connected
> to Soundwire codec(ALC721). This patch should be dropped.

Thanks for duble checking.  I already sent my PR for this -rc, I'll take
the other two patches once -rc4 is out all being well.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Eric Naim]

On 3/12/26 9:06 PM, Mark Brown wrote:
> On Thu, Mar 12, 2026 at 12:19:48PM +0530, Mukunda,Vijendar wrote:
> 
>> We have cross-checked hw configuration. This platform uses DMIC connected
>> to Soundwire codec(ALC721). This patch should be dropped.
> 
> Thanks for duble checking.  I already sent my PR for this -rc, I'll take
> the other two patches once -rc4 is out all being well.

Hi Mark,

should these patches be cc-ed to stable? As it stands, I don't think stable kernels will pick this up.

-- 
Regards,
  Eric

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

On Sun, Mar 15, 2026 at 08:20:00PM +0000, Eric Naim wrote:
> On 3/12/26 9:06 PM, Mark Brown wrote:
> > On Thu, Mar 12, 2026 at 12:19:48PM +0530, Mukunda,Vijendar wrote:

> > Thanks for duble checking.  I already sent my PR for this -rc, I'll take
> > the other two patches once -rc4 is out all being well.

> should these patches be cc-ed to stable? As it stands, I don't think stable kernels will pick this up.

Feel free to raise it with the stable people if they don't pick them up.
I gave up on tagging things since their automated selection of patches
picks up vastly more than I would ever select.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Mario Limonciello]

On 3/15/2026 6:53 PM, Mark Brown wrote:
> On Sun, Mar 15, 2026 at 08:20:00PM +0000, Eric Naim wrote:
>> On 3/12/26 9:06 PM, Mark Brown wrote:
>>> On Thu, Mar 12, 2026 at 12:19:48PM +0530, Mukunda,Vijendar wrote:
> 
>>> Thanks for duble checking.  I already sent my PR for this -rc, I'll take
>>> the other two patches once -rc4 is out all being well.
> 
>> should these patches be cc-ed to stable? As it stands, I don't think stable kernels will pick this up.
> 
> Feel free to raise it with the stable people if they don't pick them up.
> I gave up on tagging things since their automated selection of patches
> picks up vastly more than I would ever select.

Eric,

Hold horses on this one.  Vijendar confirmed the hardware design and 
this patch is wrong [1].  Let's not get it out to stable.

https://lore.kernel.org/linux-sound/a7e7e79d-c839-4a76-8a2a-f3422d2cc089@amd.com/ 
[1]

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Eric Naim]

On 3/16/26 10:30 AM, Mario Limonciello wrote:
> 
> 
> On 3/15/2026 6:53 PM, Mark Brown wrote:
>> On Sun, Mar 15, 2026 at 08:20:00PM +0000, Eric Naim wrote:
>>> On 3/12/26 9:06 PM, Mark Brown wrote:
>>>> On Thu, Mar 12, 2026 at 12:19:48PM +0530, Mukunda,Vijendar wrote:
>>
>>>> Thanks for duble checking.  I already sent my PR for this -rc, I'll take
>>>> the other two patches once -rc4 is out all being well.
>>
>>> should these patches be cc-ed to stable? As it stands, I don't think stable kernels will pick this up.
>>
>> Feel free to raise it with the stable people if they don't pick them up.
>> I gave up on tagging things since their automated selection of patches
>> picks up vastly more than I would ever select.
> 
> Eric,
> 
> Hold horses on this one.  Vijendar confirmed the hardware design and this patch is wrong [1].  Let's not get it out to stable.
> 
> https://lore.kernel.org/linux-sound/a7e7e79d-c839-4a76-8a2a-f3422d2cc089@amd.com/ [1]

Wasn't that specifically referring to patch 3/3? There weren't any comments from the second patch and the first patch was also accepted (begrudgingly). Please correct me if I'm wrong.

-- 
Regards,
  Eric

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Hasun Park]

>On 11/03/26 23:02, Mukunda,Vijendar wrote:
>> On 11/03/26 22:51, Mark Brown wrote:
>>> On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote:
>>>> On 08/03/26 20:46, hasunpark@gmail.com wrote:
>>>>> From: Hasun Park <hasunpark@gmail.com>
>>>>> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
>>>>> machine driver.
>>>>> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
>>>>> platform-specific jack/DMIC quirk path is selected.
>>>> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case?
>>>> If you are using RT721 (UAJ + DMIC combination) below quirk is not required.
>>> Presumably nothing stops the system integrator wiring a DMIC directly to
>>> the SoC even if the CODEC can also use it?  It doesn't seem an obviously
>>> silly configuration.
>> On this platform Soundwire Codec RT721 already comes up with DMIC
>> endpoint. As per our understanding current soundwire topology points to
>> use RT721 + TI codecs. ACP DMIC is not being used.
>> If we want to use ACP PDM DMIC where DMIC's are connected to SOC and 
>> routed to ACP PDM controller instead of Soundwire Codec (Which supports
>> DMIC path), then ACP_PDM_DMIC quirk should be enabled.
>
>We have cross-checked hw configuration. This platform uses DMIC connected
>to Soundwire codec(ALC721). This patch should be dropped.

Thanks for double-checking the hw configs.

I'm not sure to drop this patch because when i test it dmic only works when i add quirk and enable BE link to ACP.

But one thing i have to update is both jack and dmic both works fine with ASOC_SDW_ACP_DMIC not RT711_JD1|ASOC_SDW_ACP_DMIC.

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Mukunda,Vijendar]

On 16/03/26 21:16, Hasun Park wrote:
>> On 11/03/26 23:02, Mukunda,Vijendar wrote:
>>> On 11/03/26 22:51, Mark Brown wrote:
>>>> On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote:
>>>>> On 08/03/26 20:46, hasunpark@gmail.com wrote:
>>>>>> From: Hasun Park <hasunpark@gmail.com>
>>>>>> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
>>>>>> machine driver.
>>>>>> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
>>>>>> platform-specific jack/DMIC quirk path is selected.
>>>>> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case?
>>>>> If you are using RT721 (UAJ + DMIC combination) below quirk is not required.
>>>> Presumably nothing stops the system integrator wiring a DMIC directly to
>>>> the SoC even if the CODEC can also use it?  It doesn't seem an obviously
>>>> silly configuration.
>>> On this platform Soundwire Codec RT721 already comes up with DMIC
>>> endpoint. As per our understanding current soundwire topology points to
>>> use RT721 + TI codecs. ACP DMIC is not being used.
>>> If we want to use ACP PDM DMIC where DMIC's are connected to SOC and 
>>> routed to ACP PDM controller instead of Soundwire Codec (Which supports
>>> DMIC path), then ACP_PDM_DMIC quirk should be enabled.
>> We have cross-checked hw configuration. This platform uses DMIC connected
>> to Soundwire codec(ALC721). This patch should be dropped.
> Thanks for double-checking the hw configs.
>
> I'm not sure to drop this patch because when i test it dmic only works when i add quirk and enable BE link to ACP.
>
> But one thing i have to update is both jack and dmic both works fine with ASOC_SDW_ACP_DMIC not RT711_JD1|ASOC_SDW_ACP_DMIC.
Hi Park, There is a confusion. We don't have a platform to cross-check.  Could
you please double confirm,
when you record audio stream from UI, which capture PCM device being used ?  Or
else you can do
command line testing using arecord and confirm the pcm device.

As per our CE team, the platform you have mentioned uses different hardware
configuration.
Could you please double confirm exact model details?  Share us dmidecode and
acpidump.
Share us aplay -l and arecord -l listing.

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Mukunda,Vijendar]

On 17/03/26 09:30, Mukunda,Vijendar wrote:
> On 16/03/26 21:16, Hasun Park wrote:
>>> On 11/03/26 23:02, Mukunda,Vijendar wrote:
>>>> On 11/03/26 22:51, Mark Brown wrote:
>>>>> On Mon, Mar 09, 2026 at 11:07:30AM +0530, Mukunda,Vijendar wrote:
>>>>>> On 08/03/26 20:46, hasunpark@gmail.com wrote:
>>>>>>> From: Hasun Park <hasunpark@gmail.com>
>>>>>>> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
>>>>>>> machine driver.
>>>>>>> Set driver_data to RT711_JD1 | ASOC_SDW_ACP_DMIC for this board so the
>>>>>>> platform-specific jack/DMIC quirk path is selected.
>>>>>> As RT721 comes up with UAJ + DMIC, then why we need ACP PDM DMIC in this case?
>>>>>> If you are using RT721 (UAJ + DMIC combination) below quirk is not required.
>>>>> Presumably nothing stops the system integrator wiring a DMIC directly to
>>>>> the SoC even if the CODEC can also use it?  It doesn't seem an obviously
>>>>> silly configuration.
>>>> On this platform Soundwire Codec RT721 already comes up with DMIC
>>>> endpoint. As per our understanding current soundwire topology points to
>>>> use RT721 + TI codecs. ACP DMIC is not being used.
>>>> If we want to use ACP PDM DMIC where DMIC's are connected to SOC and 
>>>> routed to ACP PDM controller instead of Soundwire Codec (Which supports
>>>> DMIC path), then ACP_PDM_DMIC quirk should be enabled.
>>> We have cross-checked hw configuration. This platform uses DMIC connected
>>> to Soundwire codec(ALC721). This patch should be dropped.
>> Thanks for double-checking the hw configs.
>>
>> I'm not sure to drop this patch because when i test it dmic only works when i add quirk and enable BE link to ACP.
>>
>> But one thing i have to update is both jack and dmic both works fine with ASOC_SDW_ACP_DMIC not RT711_JD1|ASOC_SDW_ACP_DMIC.
> Hi Park, There is a confusion. We don't have a platform to cross-check.  Could
> you please double confirm,
> when you record audio stream from UI, which capture PCM device being used ?  Or
> else you can do
> command line testing using arecord and confirm the pcm device.
>
> As per our CE team, the platform you have mentioned uses different hardware
> configuration.
> Could you please double confirm exact model details?  Share us dmidecode and
> acpidump.
> Share us aplay -l and arecord -l listing.
 
Got the confirmation on hw configuration being used for this ASUS platform from
our CE team.
ACP PDM DMIC being used for this platform. 


>
>

Re: [PATCH 3/3] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Hasun Park]

Sorry I'm late. I was just about to start working on your request.
Is there anything else you need me to check? Let me know if there's anything else.

Best Regards.

[PATCH v2] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Hasun Park]

Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
machine driver.

Set driver_data to ASOC_SDW_ACP_DMIC for this board so the
platform-specific DMIC quirk path is selected.

Changes in v2:
- drop RT711_JD1 since only DMIC needs quirk

Signed-off-by: Hasun Park <hasunpark@gmail.com>
---
 sound/soc/amd/acp/acp-sdw-legacy-mach.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/sound/soc/amd/acp/acp-sdw-legacy-mach.c b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
index c30ccf23005a..6388cd7cb28e 100644
--- a/sound/soc/amd/acp/acp-sdw-legacy-mach.c
+++ b/sound/soc/amd/acp/acp-sdw-legacy-mach.c
@@ -111,6 +111,14 @@ static const struct dmi_system_id soc_sdw_quirk_table[] = {
 		},
 		.driver_data = (void *)(ASOC_SDW_CODEC_SPKR),
 	},
+	{
+		.callback = soc_sdw_quirk_cb,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK COMPUTER INC."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "HN7306EA"),
+		},
+		.driver_data = (void *)(ASOC_SDW_ACP_DMIC),
+	},
 	{}
 };
 
-- 
2.53.0

Re: [PATCH v2] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

On Fri, Mar 20, 2026 at 01:33:21AM +0900, Hasun Park wrote:
> Add a DMI quirk entry for ASUS HN7306EA in the ACP SoundWire legacy
> machine driver.
> 
> Set driver_data to ASOC_SDW_ACP_DMIC for this board so the
> platform-specific DMIC quirk path is selected.
> 
> Changes in v2:
> - drop RT711_JD1 since only DMIC needs quirk

Changelogs like this should go...

> Signed-off-by: Hasun Park <hasunpark@gmail.com>
> ---

...after the --- here so that they can be automatically removed by
tools.  Don't worry about it here, just something to be aware of for
future submissions.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

[Mark Brown]

On Fri, 20 Mar 2026 01:33:21 +0900, Hasun Park wrote:
> ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.0

Thanks!

[1/1] ASoC: amd: acp: add ASUS HN7306EA quirk for legacy SDW machine
      https://git.kernel.org/broonie/sound/c/2594196f4e3b

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: (subset) [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks

[Mark Brown]

On Mon, 09 Mar 2026 00:16:51 +0900, hasunpark@gmail.com wrote:
> ASoC: amd: acp: PX13 ACP70 config and machine quirks
> 
> From: Hasun Park <hasunpark@gmail.com>
> 
> Hi,
> 
> This series adds ACP70 platform quirks for ASUS ProArt PX13
> (HN7306EA/HN7306EAC).
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.0

Thanks!

[1/3] ASoC: amd: acp: add DMI override for ACP70 flag
      https://git.kernel.org/broonie/sound/c/d0426510a9e1
[2/3] ASoC: amd: acp: add PX13 SoundWire machine link for rt721+tas2783x2
      https://git.kernel.org/broonie/sound/c/399b6fd37a10

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: (subset) [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks

[Hasun Park]

>On Mon, 09 Mar 2026 00:16:51 +0900, hasunpark@gmail.com wrote:
>> ASoC: amd: acp: PX13 ACP70 config and machine quirks
>> 
>> From: Hasun Park <hasunpark@gmail.com>
>> 
>> Hi,
>> 
>> This series adds ACP70 platform quirks for ASUS ProArt PX13
>> (HN7306EA/HN7306EAC).
>> 
>> [...]
>
>Applied to
>
>   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.0
>
>Thanks!

Hi Mark. I've done some clean up since that system does not require rt721 for dmic.

After preparing V2 patch series i realized some are already merged on for-next branch.

I'm not sure what should i prefer, send this v2 patch or
since this change is just for cleaning up and doesn't cause problem at function
so submit another patch for cleaning up.

I need your advice. Thanks

Re: (subset) [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

On Tue, Mar 17, 2026 at 01:47:31AM +0900, Hasun Park wrote:

> I'm not sure what should i prefer, send this v2 patch or
> since this change is just for cleaning up and doesn't cause problem at function
> so submit another patch for cleaning up.

Please send an incremental patch (or patches) on top of what's applied
that does your cleanups.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: (subset) [PATCH 0/3] ASoC: amd: acp: PX13 ACP70 config and machine quirks

[Mark Brown]

On Mon, 09 Mar 2026 00:16:51 +0900, hasunpark@gmail.com wrote:
> This series adds ACP70 platform quirks for ASUS ProArt PX13
> (HN7306EA/HN7306EAC).
> 
> The goal is to keep platform selection on the expected SoundWire path and
> add the required ACP70 machine/quirk entries for this board family.
> 
> Baseline (without this series):
>   $ cat /proc/asound/cards
>    0 [Generic        ]: HDA-Intel - HD-Audio Generic
>                         HD-Audio Generic at 0xa0440000 irq 160
>    1 [acppdmmach     ]: acp-pdm-mach - acp-pdm-mach
>                         ASUSTeKCOMPUTERINC.-ProArtPX13HN7306EAC-1.0-HN7306EAC
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/3] ASoC: amd: acp: add DMI override for ACP70 flag
      https://git.kernel.org/broonie/misc/c/d0426510a9e1
[2/3] ASoC: amd: acp: add PX13 SoundWire machine link for rt721+tas2783x2
      https://git.kernel.org/broonie/misc/c/399b6fd37a10

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark