[PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[Bryan Wu]

From: Mike Frysinger <vapier.adi@gmail.com>

Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
Signed-off-by: Bryan Wu <cooloney@kernel.org>
---
 drivers/usb/musb/blackfin.c |    9 +++++----
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
index 7861348..0ebb19d 100644
--- a/drivers/usb/musb/blackfin.c
+++ b/drivers/usb/musb/blackfin.c
@@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
 void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
 {
 	void __iomem *fifo = hw_ep->fifo;
+
+#ifdef CONFIG_BF52x
 	u8 epnum = hw_ep->epnum;
 	u16 dma_reg = 0;
 
-	DBG(4, "%cX ep%d fifo %p count %d buf %p\n",
-			'R', hw_ep->epnum, fifo, len, dst);
-
-#ifdef CONFIG_BF52x
 	invalidate_dcache_range((unsigned int)dst,
 		(unsigned int)(dst + len));
 
@@ -103,6 +101,9 @@ void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
 			len & 0x01 ? (len >> 1) + 1 : len >> 1);
 #endif
 
+	DBG(4, "%cX ep%d fifo %p count %d buf %p\n",
+			'R', hw_ep->epnum, fifo, len, dst);
+
 	dump_fifo_data(dst, len);
 }
 
-- 
1.5.6.3

Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[Felipe Balbi]

On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote:
> From: Mike Frysinger <vapier.adi@gmail.com>

I'd like to get a patch body here.

> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> ---
>  drivers/usb/musb/blackfin.c |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
> index 7861348..0ebb19d 100644
> --- a/drivers/usb/musb/blackfin.c
> +++ b/drivers/usb/musb/blackfin.c
> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
>  void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
>  {
>  	void __iomem *fifo = hw_ep->fifo;
> +
> +#ifdef CONFIG_BF52x
>  	u8 epnum = hw_ep->epnum;
>  	u16 dma_reg = 0;

Is this patch avoiding a warning about these variables being unused ?

Would be nice to get this info to the patch body ;-)

otherwise, looks fine.

-- 
balbi

Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[Mike Frysinger]

On Fri, Feb 6, 2009 at 14:15, Felipe Balbi wrote:
> On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote:
>> From: Mike Frysinger <vapier.adi@gmail.com>
>
> I'd like to get a patch body here.
>
>> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
>> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>> ---
>>  drivers/usb/musb/blackfin.c |    9 +++++----
>>  1 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
>> index 7861348..0ebb19d 100644
>> --- a/drivers/usb/musb/blackfin.c
>> +++ b/drivers/usb/musb/blackfin.c
>> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
>>  void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
>>  {
>>       void __iomem *fifo = hw_ep->fifo;
>> +
>> +#ifdef CONFIG_BF52x
>>       u8 epnum = hw_ep->epnum;
>>       u16 dma_reg = 0;
>
> Is this patch avoiding a warning about these variables being unused ?
>
> Would be nice to get this info to the patch body ;-)

the subject already says that
-mike

Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[Felipe Balbi]

On Fri, Feb 06, 2009 at 02:24:27PM -0500, Mike Frysinger wrote:
> On Fri, Feb 6, 2009 at 14:15, Felipe Balbi wrote:
> > On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote:
> >> From: Mike Frysinger <vapier.adi@gmail.com>
> >
> > I'd like to get a patch body here.
> >
> >> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> >> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> >> ---
> >>  drivers/usb/musb/blackfin.c |    9 +++++----
> >>  1 files changed, 5 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
> >> index 7861348..0ebb19d 100644
> >> --- a/drivers/usb/musb/blackfin.c
> >> +++ b/drivers/usb/musb/blackfin.c
> >> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
> >>  void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
> >>  {
> >>       void __iomem *fifo = hw_ep->fifo;
> >> +
> >> +#ifdef CONFIG_BF52x
> >>       u8 epnum = hw_ep->epnum;
> >>       u16 dma_reg = 0;
> >
> > Is this patch avoiding a warning about these variables being unused ?
> >
> > Would be nice to get this info to the patch body ;-)
> 
> the subject already says that

the subject says:

"tweak musb_read_fifo() to avoid unused warnings"

it doesn't specify where are the warnings.

-- 
balbi

Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[Mike Frysinger]

On Fri, Feb 6, 2009 at 14:26, Felipe Balbi wrote:
> On Fri, Feb 06, 2009 at 02:24:27PM -0500, Mike Frysinger wrote:
>> On Fri, Feb 6, 2009 at 14:15, Felipe Balbi wrote:
>> > On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote:
>> >> From: Mike Frysinger <vapier.adi@gmail.com>
>> >
>> > I'd like to get a patch body here.
>> >
>> >> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
>> >> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>> >> ---
>> >>  drivers/usb/musb/blackfin.c |    9 +++++----
>> >>  1 files changed, 5 insertions(+), 4 deletions(-)
>> >>
>> >> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
>> >> index 7861348..0ebb19d 100644
>> >> --- a/drivers/usb/musb/blackfin.c
>> >> +++ b/drivers/usb/musb/blackfin.c
>> >> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
>> >>  void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
>> >>  {
>> >>       void __iomem *fifo = hw_ep->fifo;
>> >> +
>> >> +#ifdef CONFIG_BF52x
>> >>       u8 epnum = hw_ep->epnum;
>> >>       u16 dma_reg = 0;
>> >
>> > Is this patch avoiding a warning about these variables being unused ?
>> >
>> > Would be nice to get this info to the patch body ;-)
>>
>> the subject already says that
>
> the subject says:
>
> "tweak musb_read_fifo() to avoid unused warnings"
>
> it doesn't specify where are the warnings.

i dont think it really adds anything to explicitly mention every
variable that triggers an unused warning.  but if we look at the code
that changed, it's easy to see that it's epnum and dma_reg.
-mike

Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[Felipe Balbi]

On Fri, Feb 06, 2009 at 02:28:46PM -0500, Mike Frysinger wrote:
> >> the subject already says that
> >
> > the subject says:
> >
> > "tweak musb_read_fifo() to avoid unused warnings"
> >
> > it doesn't specify where are the warnings.
> 
> i dont think it really adds anything to explicitly mention every
> variable that triggers an unused warning.  but if we look at the code
> that changed, it's easy to see that it's epnum and dma_reg.

Still I like to see patch bodies otherwise git log will look awkward.

-- 
balbi

Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[David Brownell]

On Friday 06 February 2009, Mike Frysinger wrote:
> > Is this patch avoiding a warning about these variables being unused ?
> >
> > Would be nice to get this info to the patch body ;-)
> 
> the subject already says that

Not enough.

Mike, why is it that patches from ADI generally don't include
patch descriptions?   It's not like folk haven't asked for them...

In the case of "avoid a warning" patches, the convention is to
have the patch summary include the warnings being avoided.
(Or at least a few, if they're too numerous.)

Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[Greg KH]

On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote:
> From: Mike Frysinger <vapier.adi@gmail.com>
> 
> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> ---
>  drivers/usb/musb/blackfin.c |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
> index 7861348..0ebb19d 100644
> --- a/drivers/usb/musb/blackfin.c
> +++ b/drivers/usb/musb/blackfin.c
> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
>  void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
>  {
>  	void __iomem *fifo = hw_ep->fifo;
> +
> +#ifdef CONFIG_BF52x

Any way we can just not have ifdefs in .c files alltogether?

thanks,

greg k-h

Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[Mike Frysinger]

On Fri, Feb 6, 2009 at 19:01, Greg KH wrote:
> On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote:
>> From: Mike Frysinger <vapier.adi@gmail.com>
>>
>> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
>> Signed-off-by: Bryan Wu <cooloney@kernel.org>
>> ---
>>  drivers/usb/musb/blackfin.c |    9 +++++----
>>  1 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
>> index 7861348..0ebb19d 100644
>> --- a/drivers/usb/musb/blackfin.c
>> +++ b/drivers/usb/musb/blackfin.c
>> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
>>  void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
>>  {
>>       void __iomem *fifo = hw_ep->fifo;
>> +
>> +#ifdef CONFIG_BF52x
>
> Any way we can just not have ifdefs in .c files alltogether?

the sub arch.c files for musb are pretty much header files.  the
alternative (splitting up the funcs into their own header files) would
be much more bothersome for us to maintain atm i think since there's
so very little different.
-mike

Re: [PATCH] usb: musb: tweak musb_read_fifo() to avoid unused warnings

[Greg KH]

On Fri, Feb 06, 2009 at 11:29:54PM -0500, Mike Frysinger wrote:
> On Fri, Feb 6, 2009 at 19:01, Greg KH wrote:
> > On Fri, Feb 06, 2009 at 06:22:16PM +0800, Bryan Wu wrote:
> >> From: Mike Frysinger <vapier.adi@gmail.com>
> >>
> >> Signed-off-by: Mike Frysinger <vapier.adi@gmail.com>
> >> Signed-off-by: Bryan Wu <cooloney@kernel.org>
> >> ---
> >>  drivers/usb/musb/blackfin.c |    9 +++++----
> >>  1 files changed, 5 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
> >> index 7861348..0ebb19d 100644
> >> --- a/drivers/usb/musb/blackfin.c
> >> +++ b/drivers/usb/musb/blackfin.c
> >> @@ -54,13 +54,11 @@ void musb_write_fifo(struct musb_hw_ep *hw_ep, u16 len, const u8 *src)
> >>  void musb_read_fifo(struct musb_hw_ep *hw_ep, u16 len, u8 *dst)
> >>  {
> >>       void __iomem *fifo = hw_ep->fifo;
> >> +
> >> +#ifdef CONFIG_BF52x
> >
> > Any way we can just not have ifdefs in .c files alltogether?
> 
> the sub arch.c files for musb are pretty much header files.  the
> alternative (splitting up the funcs into their own header files) would
> be much more bothersome for us to maintain atm i think since there's
> so very little different.

Ick.  Oh well, any cleanup that people can think of would be good in
this area...

thanks,

greg k-h