All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] get_maintainer: Add subsystem to reviewer output
Date: Wed, 28 Oct 2015 17:22:08 +0000	[thread overview]
Message-ID: <20151028172208.GJ4058@x1> (raw)
In-Reply-To: <1446052121.2757.120.camel@perches.com>

On Wed, 28 Oct 2015, Joe Perches wrote:

> On Wed, 2015-10-28 at 17:01 +0000, Lee Jones wrote:
> > On Wed, 28 Oct 2015, Joe Perches wrote:
> > 
> > > Reviewer output currently does not include the subsystem
> > > that matched.  Add it.
> > > 
> > > Miscellanea:
> > > 
> > > o Add a get_subsystem_name routine to centralize this
> > > 
> > > Signed-off-by: Joe Perches <joe@perches.com>
> > > ---
> > >  scripts/get_maintainer.pl | 31 ++++++++++++++++---------------
> > >  1 file changed, 16 insertions(+), 15 deletions(-)
> > 
> > It looks like I'm going to have to drop the patch where we actually
> > start using the R: tag properly due to some social, emotional issues.
> 
> Not to mention logical.

Hmm... we continue to disagree on that one.

> > Despite that and not knowing Perl, I believe get_maintainer.pl should
> > be printing out the subsystem next to 'reviewer' as it does for
> > 'maintainer'.
> > 
> > So with that in mind:
> >   Acked-by: Lee Jones <lee.jones@linaro.org>
> 
> It'd be better if you could add a "tested-by:" instead.

Patch works as expected:
  Tested-by: Lee Jones <lee.jones@linaro.org>

Feel free to add my Suggested-by too, based on my belief that this
patch was born out of this comment:

      "I'm sure we can make the output even more similar by listing
      the MAINTAINERS tag after "reviewer" too."

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Joe Perches <joe@perches.com>
Cc: "Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	k.kozlowski.k@gmail.com, wsa@the-dreams.de,
	linus.walleij@linaro.org, "Sebastian Reichel" <sre@kernel.org>,
	linux-kernel@vger.kernel.org,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	broonie@kernel.org, ben-linux@fluff.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] get_maintainer: Add subsystem to reviewer output
Date: Wed, 28 Oct 2015 17:22:08 +0000	[thread overview]
Message-ID: <20151028172208.GJ4058@x1> (raw)
In-Reply-To: <1446052121.2757.120.camel@perches.com>

On Wed, 28 Oct 2015, Joe Perches wrote:

> On Wed, 2015-10-28 at 17:01 +0000, Lee Jones wrote:
> > On Wed, 28 Oct 2015, Joe Perches wrote:
> > 
> > > Reviewer output currently does not include the subsystem
> > > that matched.  Add it.
> > > 
> > > Miscellanea:
> > > 
> > > o Add a get_subsystem_name routine to centralize this
> > > 
> > > Signed-off-by: Joe Perches <joe@perches.com>
> > > ---
> > >  scripts/get_maintainer.pl | 31 ++++++++++++++++---------------
> > >  1 file changed, 16 insertions(+), 15 deletions(-)
> > 
> > It looks like I'm going to have to drop the patch where we actually
> > start using the R: tag properly due to some social, emotional issues.
> 
> Not to mention logical.

Hmm... we continue to disagree on that one.

> > Despite that and not knowing Perl, I believe get_maintainer.pl should
> > be printing out the subsystem next to 'reviewer' as it does for
> > 'maintainer'.
> > 
> > So with that in mind:
> >   Acked-by: Lee Jones <lee.jones@linaro.org>
> 
> It'd be better if you could add a "tested-by:" instead.

Patch works as expected:
  Tested-by: Lee Jones <lee.jones@linaro.org>

Feel free to add my Suggested-by too, based on my belief that this
patch was born out of this comment:

      "I'm sure we can make the output even more similar by listing
      the MAINTAINERS tag after "reviewer" too."

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2015-10-28 17:22 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 15:42 [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag Lee Jones
2015-10-27 15:42 ` Lee Jones
2015-10-27 17:24 ` Sebastian Reichel
2015-10-27 17:24   ` Sebastian Reichel
2015-10-27 18:15   ` Lee Jones
2015-10-27 18:15     ` Lee Jones
2015-10-27 18:44     ` Joe Perches
2015-10-27 18:44       ` Joe Perches
2015-10-28  1:46       ` Krzysztof Kozlowski
2015-10-28  1:46         ` Krzysztof Kozlowski
2015-10-28  8:24         ` Lee Jones
2015-10-28  8:24           ` Lee Jones
2015-10-28  9:21           ` Javier Martinez Canillas
2015-10-28  9:21             ` Javier Martinez Canillas
2015-10-28  9:25             ` Javier Martinez Canillas
2015-10-28  9:25               ` Javier Martinez Canillas
2015-10-28  9:31             ` Krzysztof Kozlowski
2015-10-28  9:31               ` Krzysztof Kozlowski
2015-10-28 10:28             ` Lee Jones
2015-10-28 10:28               ` Lee Jones
2015-10-28 10:53               ` Javier Martinez Canillas
2015-10-28 10:53                 ` Javier Martinez Canillas
2015-10-28 11:06                 ` Joe Perches
2015-10-28 11:06                   ` Joe Perches
2015-10-28 11:25                   ` Javier Martinez Canillas
2015-10-28 11:25                     ` Javier Martinez Canillas
2015-10-28 11:39                     ` Lee Jones
2015-10-28 11:39                       ` Lee Jones
2015-10-28 12:14                       ` Lee Jones
2015-10-28 12:14                         ` Lee Jones
2015-10-28 12:20                         ` Joe Perches
2015-10-28 12:20                           ` Joe Perches
2015-10-28 12:24                           ` Lee Jones
2015-10-28 12:24                             ` Lee Jones
2015-10-28 12:46                             ` Joe Perches
2015-10-28 12:46                               ` Joe Perches
2015-10-28 13:06                         ` Javier Martinez Canillas
2015-10-28 13:06                           ` Javier Martinez Canillas
2015-10-28 13:34                           ` Lee Jones
2015-10-28 13:34                             ` Lee Jones
2015-10-28 14:09                             ` Javier Martinez Canillas
2015-10-28 14:09                               ` Javier Martinez Canillas
2015-10-28 14:38                               ` Lee Jones
2015-10-28 14:38                                 ` Lee Jones
2015-10-28 14:54                                 ` Javier Martinez Canillas
2015-10-28 14:54                                   ` Javier Martinez Canillas
2015-10-28 23:56                                 ` Krzysztof Kozlowski
2015-10-28 23:56                                   ` Krzysztof Kozlowski
2015-10-29  0:12                                   ` Javier Martinez Canillas
2015-10-29  0:12                                     ` Javier Martinez Canillas
2015-10-30 16:51                                     ` Lee Jones
2015-10-30 16:51                                       ` Lee Jones
2015-10-30 16:51                                   ` Lee Jones
2015-10-30 16:51                                     ` Lee Jones
2015-10-28  9:23           ` Krzysztof Kozlowski
2015-10-28  9:23             ` Krzysztof Kozlowski
2015-10-28  9:39             ` Uwe Kleine-König
2015-10-28  9:39               ` Uwe Kleine-König
2015-10-28  9:55               ` Lee Jones
2015-10-28  9:55                 ` Lee Jones
2015-10-28 13:13                 ` Krzysztof Kozlowski
2015-10-28 13:13                   ` Krzysztof Kozlowski
2015-10-28 16:41                   ` [PATCH] get_maintainer: Add subsystem to reviewer output Joe Perches
2015-10-28 16:41                     ` Joe Perches
2015-10-28 17:01                     ` Lee Jones
2015-10-28 17:01                       ` Lee Jones
2015-10-28 17:08                       ` Joe Perches
2015-10-28 17:08                         ` Joe Perches
2015-10-28 17:22                         ` Lee Jones [this message]
2015-10-28 17:22                           ` Lee Jones
2015-10-28 17:30                           ` Joe Perches
2015-10-28 17:30                             ` Joe Perches
2015-10-28 17:49                             ` Lee Jones
2015-10-28 17:49                               ` Lee Jones
2015-10-28 17:56                               ` Joe Perches
2015-10-28 17:56                                 ` Joe Perches
2015-10-29  9:20                                 ` Lee Jones
2015-10-29  9:20                                   ` Lee Jones
2015-10-29 14:14                                   ` Joe Perches
2015-10-29 14:14                                     ` Joe Perches
2015-10-29 16:17                                     ` Lee Jones
2015-10-29 16:17                                       ` Lee Jones
2015-10-28 17:18                       ` Joe Perches
2015-10-28 17:18                         ` Joe Perches
2015-10-28 23:49                     ` Krzysztof Kozlowski
2015-10-28 23:49                       ` Krzysztof Kozlowski
2015-10-28 10:14             ` [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag Lee Jones
2015-10-28 10:14               ` Lee Jones
2015-10-28 13:27               ` Krzysztof Kozlowski
2015-10-28 13:27                 ` Krzysztof Kozlowski
2015-10-28 13:49                 ` Lee Jones
2015-10-28 13:49                   ` Lee Jones
2015-10-28 16:26           ` Bartlomiej Zolnierkiewicz
2015-10-28 16:26             ` Bartlomiej Zolnierkiewicz
2015-10-28 16:33             ` Lee Jones
2015-10-28 16:33               ` Lee Jones
2015-10-28  8:57 ` Chanwoo Choi
2015-10-28  8:57   ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151028172208.GJ4058@x1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.