All of lore.kernel.org
 help / color / mirror / Atom feed
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag
Date: Wed, 28 Oct 2015 22:13:42 +0900	[thread overview]
Message-ID: <5630CA06.7050503@samsung.com> (raw)
In-Reply-To: <20151028095524.GP5828@x1>

W dniu 28.10.2015 o 18:55, Lee Jones pisze:
> On Wed, 28 Oct 2015, Uwe Kleine-K?nig wrote:
> 
>> Hello,
>>
>> On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote:
>>> On 28.10.2015 17:24, Lee Jones wrote:
>>>> You guys are pushing back like this is some kind of demotion.
>>>> That's not the case at all.  All it does is better describe the (very
>>>> worthy) function you *actually* provide.
>>>
>>> It is getting into dispute about entire change of yours... which is not
>>> what I want. I agree with your general idea but I was referring only to
>>> that particular case - the Samsung PMICs (and Maxim PMICs/MUICs which
>>> would fall into same category).
>>
>> Not being affected by this change, I wonder what the technical
>> difference is if someone is listed as reviewer instead of maintainer.
>> Does get_maintainer.pl behave differently?
> 
> Reviewers are people who should be Cc'ed on all patches, as are
> Maintainers, so no, fundamentally they are treated the same by a
> Submitter.
> 
> Here is some output for Maintainers/Reviews from get_maintainer.pl.
> 
>  $ ./scripts/get_maintainer.pl -f arch/arm/boot/dts/vf500.dtsi
>  Shawn Guo <shawnguo@kernel.org> (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
>  Sascha Hauer <kernel@pengutronix.de> (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
>  Stefan Agner <stefan@agner.ch> (reviewer)
>  Russell King <linux@arm.linux.org.uk> (maintainer:ARM PORT)
>  linux-arm-kernel at lists.infradead.org (moderated list:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
>  devicetree at vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>  linux-kernel at vger.kernel.org (open list)
> 
> I'm sure we can make the output even more similar by listing the
> MAINTAINERS tag after "reviewer" too.

And here is the output of drivers/mfd/sec-core.c *before*:
Sangbeom Kim <sbkim73@samsung.com> (supporter:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS)
Krzysztof Kozlowski <k.kozlowski@samsung.com> (supporter:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS)
Lee Jones <lee.jones@linaro.org> (supporter:MULTIFUNCTION DEVICES (MFD))


and after (where I am listed as reviewer):
Sangbeom Kim <sbkim73@samsung.com> (reviewer)
Krzysztof Kozlowski <k.kozlowski@samsung.com> (reviewer)
Lee Jones <lee.jones@linaro.org> (supporter:MULTIFUNCTION DEVICES (MFD))

Maybe it should be "supporter reviewer"?

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: "Lee Jones" <lee.jones@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: k.kozlowski.k@gmail.com, wsa@the-dreams.de,
	linus.walleij@linaro.org, Sebastian Reichel <sre@kernel.org>,
	linux-kernel@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>,
	broonie@kernel.org, ben-linux@fluff.org,
	Joe Perches <joe@perches.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag
Date: Wed, 28 Oct 2015 22:13:42 +0900	[thread overview]
Message-ID: <5630CA06.7050503@samsung.com> (raw)
In-Reply-To: <20151028095524.GP5828@x1>

W dniu 28.10.2015 o 18:55, Lee Jones pisze:
> On Wed, 28 Oct 2015, Uwe Kleine-König wrote:
> 
>> Hello,
>>
>> On Wed, Oct 28, 2015 at 06:23:37PM +0900, Krzysztof Kozlowski wrote:
>>> On 28.10.2015 17:24, Lee Jones wrote:
>>>> You guys are pushing back like this is some kind of demotion.
>>>> That's not the case at all.  All it does is better describe the (very
>>>> worthy) function you *actually* provide.
>>>
>>> It is getting into dispute about entire change of yours... which is not
>>> what I want. I agree with your general idea but I was referring only to
>>> that particular case - the Samsung PMICs (and Maxim PMICs/MUICs which
>>> would fall into same category).
>>
>> Not being affected by this change, I wonder what the technical
>> difference is if someone is listed as reviewer instead of maintainer.
>> Does get_maintainer.pl behave differently?
> 
> Reviewers are people who should be Cc'ed on all patches, as are
> Maintainers, so no, fundamentally they are treated the same by a
> Submitter.
> 
> Here is some output for Maintainers/Reviews from get_maintainer.pl.
> 
>  $ ./scripts/get_maintainer.pl -f arch/arm/boot/dts/vf500.dtsi
>  Shawn Guo <shawnguo@kernel.org> (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
>  Sascha Hauer <kernel@pengutronix.de> (maintainer:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
>  Stefan Agner <stefan@agner.ch> (reviewer)
>  Russell King <linux@arm.linux.org.uk> (maintainer:ARM PORT)
>  linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE VYBRID ARM ARCHITECTURE)
>  devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>  linux-kernel@vger.kernel.org (open list)
> 
> I'm sure we can make the output even more similar by listing the
> MAINTAINERS tag after "reviewer" too.

And here is the output of drivers/mfd/sec-core.c *before*:
Sangbeom Kim <sbkim73@samsung.com> (supporter:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS)
Krzysztof Kozlowski <k.kozlowski@samsung.com> (supporter:SAMSUNG MULTIFUNCTION PMIC DEVICE DRIVERS)
Lee Jones <lee.jones@linaro.org> (supporter:MULTIFUNCTION DEVICES (MFD))


and after (where I am listed as reviewer):
Sangbeom Kim <sbkim73@samsung.com> (reviewer)
Krzysztof Kozlowski <k.kozlowski@samsung.com> (reviewer)
Lee Jones <lee.jones@linaro.org> (supporter:MULTIFUNCTION DEVICES (MFD))

Maybe it should be "supporter reviewer"?

Best regards,
Krzysztof


  reply	other threads:[~2015-10-28 13:13 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 15:42 [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag Lee Jones
2015-10-27 15:42 ` Lee Jones
2015-10-27 17:24 ` Sebastian Reichel
2015-10-27 17:24   ` Sebastian Reichel
2015-10-27 18:15   ` Lee Jones
2015-10-27 18:15     ` Lee Jones
2015-10-27 18:44     ` Joe Perches
2015-10-27 18:44       ` Joe Perches
2015-10-28  1:46       ` Krzysztof Kozlowski
2015-10-28  1:46         ` Krzysztof Kozlowski
2015-10-28  8:24         ` Lee Jones
2015-10-28  8:24           ` Lee Jones
2015-10-28  9:21           ` Javier Martinez Canillas
2015-10-28  9:21             ` Javier Martinez Canillas
2015-10-28  9:25             ` Javier Martinez Canillas
2015-10-28  9:25               ` Javier Martinez Canillas
2015-10-28  9:31             ` Krzysztof Kozlowski
2015-10-28  9:31               ` Krzysztof Kozlowski
2015-10-28 10:28             ` Lee Jones
2015-10-28 10:28               ` Lee Jones
2015-10-28 10:53               ` Javier Martinez Canillas
2015-10-28 10:53                 ` Javier Martinez Canillas
2015-10-28 11:06                 ` Joe Perches
2015-10-28 11:06                   ` Joe Perches
2015-10-28 11:25                   ` Javier Martinez Canillas
2015-10-28 11:25                     ` Javier Martinez Canillas
2015-10-28 11:39                     ` Lee Jones
2015-10-28 11:39                       ` Lee Jones
2015-10-28 12:14                       ` Lee Jones
2015-10-28 12:14                         ` Lee Jones
2015-10-28 12:20                         ` Joe Perches
2015-10-28 12:20                           ` Joe Perches
2015-10-28 12:24                           ` Lee Jones
2015-10-28 12:24                             ` Lee Jones
2015-10-28 12:46                             ` Joe Perches
2015-10-28 12:46                               ` Joe Perches
2015-10-28 13:06                         ` Javier Martinez Canillas
2015-10-28 13:06                           ` Javier Martinez Canillas
2015-10-28 13:34                           ` Lee Jones
2015-10-28 13:34                             ` Lee Jones
2015-10-28 14:09                             ` Javier Martinez Canillas
2015-10-28 14:09                               ` Javier Martinez Canillas
2015-10-28 14:38                               ` Lee Jones
2015-10-28 14:38                                 ` Lee Jones
2015-10-28 14:54                                 ` Javier Martinez Canillas
2015-10-28 14:54                                   ` Javier Martinez Canillas
2015-10-28 23:56                                 ` Krzysztof Kozlowski
2015-10-28 23:56                                   ` Krzysztof Kozlowski
2015-10-29  0:12                                   ` Javier Martinez Canillas
2015-10-29  0:12                                     ` Javier Martinez Canillas
2015-10-30 16:51                                     ` Lee Jones
2015-10-30 16:51                                       ` Lee Jones
2015-10-30 16:51                                   ` Lee Jones
2015-10-30 16:51                                     ` Lee Jones
2015-10-28  9:23           ` Krzysztof Kozlowski
2015-10-28  9:23             ` Krzysztof Kozlowski
2015-10-28  9:39             ` Uwe Kleine-König
2015-10-28  9:39               ` Uwe Kleine-König
2015-10-28  9:55               ` Lee Jones
2015-10-28  9:55                 ` Lee Jones
2015-10-28 13:13                 ` Krzysztof Kozlowski [this message]
2015-10-28 13:13                   ` Krzysztof Kozlowski
2015-10-28 16:41                   ` [PATCH] get_maintainer: Add subsystem to reviewer output Joe Perches
2015-10-28 16:41                     ` Joe Perches
2015-10-28 17:01                     ` Lee Jones
2015-10-28 17:01                       ` Lee Jones
2015-10-28 17:08                       ` Joe Perches
2015-10-28 17:08                         ` Joe Perches
2015-10-28 17:22                         ` Lee Jones
2015-10-28 17:22                           ` Lee Jones
2015-10-28 17:30                           ` Joe Perches
2015-10-28 17:30                             ` Joe Perches
2015-10-28 17:49                             ` Lee Jones
2015-10-28 17:49                               ` Lee Jones
2015-10-28 17:56                               ` Joe Perches
2015-10-28 17:56                                 ` Joe Perches
2015-10-29  9:20                                 ` Lee Jones
2015-10-29  9:20                                   ` Lee Jones
2015-10-29 14:14                                   ` Joe Perches
2015-10-29 14:14                                     ` Joe Perches
2015-10-29 16:17                                     ` Lee Jones
2015-10-29 16:17                                       ` Lee Jones
2015-10-28 17:18                       ` Joe Perches
2015-10-28 17:18                         ` Joe Perches
2015-10-28 23:49                     ` Krzysztof Kozlowski
2015-10-28 23:49                       ` Krzysztof Kozlowski
2015-10-28 10:14             ` [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag Lee Jones
2015-10-28 10:14               ` Lee Jones
2015-10-28 13:27               ` Krzysztof Kozlowski
2015-10-28 13:27                 ` Krzysztof Kozlowski
2015-10-28 13:49                 ` Lee Jones
2015-10-28 13:49                   ` Lee Jones
2015-10-28 16:26           ` Bartlomiej Zolnierkiewicz
2015-10-28 16:26             ` Bartlomiej Zolnierkiewicz
2015-10-28 16:33             ` Lee Jones
2015-10-28 16:33               ` Lee Jones
2015-10-28  8:57 ` Chanwoo Choi
2015-10-28  8:57   ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5630CA06.7050503@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.