All of lore.kernel.org
 help / color / mirror / Atom feed
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag
Date: Wed, 28 Oct 2015 18:31:13 +0900	[thread overview]
Message-ID: <563095E1.9010406@samsung.com> (raw)
In-Reply-To: <CABxcv=mGZstqyrkB95hjDCYCvhDJDVD=ga-Fg_5yPtXETuWe=g@mail.gmail.com>

On 28.10.2015 18:21, Javier Martinez Canillas wrote:
> Hello Lee,
> 

(...)
Let me only add something to certain part of your email...

>> But you aren't maintaining the driver i.e. you don't collect patches
>> and *maintain* them on an upstream branch.  Granted some of you guys
>> are doing a great job of maintaining branches on your downstream or
>> BSP kernels, but conduct a Reviewer type role for upstream.
>>
>> You guys are pushing back like this is some kind of demotion.  That's
>> not the case at all.  All it does is better describe the (very worthy)
>> function you *actually* provide.
>>
> 
> But I think it makes description less accurate in fact, since without
> $SUBJECT get_maintainers.pl reports for example:
> 
> Krzysztof Kozlowski <k.kozlowski@samsung.com> (supporter:MAXIM PMIC
> AND MUIC DRIVERS FOR EXYNOS BASED BO...)
> Lee Jones <lee.jones@linaro.org> (supporter:MULTIFUNCTION DEVICES (MFD))
> 
> and after the change:
> 
> Krzysztof Kozlowski <k.kozlowski@samsung.com> (reviewer)
> Lee Jones <lee.jones@linaro.org> (supporter:MULTIFUNCTION DEVICES (MFD))
> 
> He also works for Samsung so the driver is not only maintained but
> supported since he can actually take care of it as a part of his day
> job (if I understood correctly).

Oh, that's interesting semantic change. Yes, in that particular case, I
added the "supported" tag on purpose - it's part of my job. It is
connected with what I said in other reply - we have deep interest in
these drivers. Not only "I will review the code if I have the time". No.
I will devote my time to ensure that the code is working on our products.

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@dowhile0.org>,
	Lee Jones <lee.jones@linaro.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Mark Brown <broonie@kernel.org>, Ben Dooks <ben-linux@fluff.org>,
	Joe Perches <joe@perches.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag
Date: Wed, 28 Oct 2015 18:31:13 +0900	[thread overview]
Message-ID: <563095E1.9010406@samsung.com> (raw)
In-Reply-To: <CABxcv=mGZstqyrkB95hjDCYCvhDJDVD=ga-Fg_5yPtXETuWe=g@mail.gmail.com>

On 28.10.2015 18:21, Javier Martinez Canillas wrote:
> Hello Lee,
> 

(...)
Let me only add something to certain part of your email...

>> But you aren't maintaining the driver i.e. you don't collect patches
>> and *maintain* them on an upstream branch.  Granted some of you guys
>> are doing a great job of maintaining branches on your downstream or
>> BSP kernels, but conduct a Reviewer type role for upstream.
>>
>> You guys are pushing back like this is some kind of demotion.  That's
>> not the case at all.  All it does is better describe the (very worthy)
>> function you *actually* provide.
>>
> 
> But I think it makes description less accurate in fact, since without
> $SUBJECT get_maintainers.pl reports for example:
> 
> Krzysztof Kozlowski <k.kozlowski@samsung.com> (supporter:MAXIM PMIC
> AND MUIC DRIVERS FOR EXYNOS BASED BO...)
> Lee Jones <lee.jones@linaro.org> (supporter:MULTIFUNCTION DEVICES (MFD))
> 
> and after the change:
> 
> Krzysztof Kozlowski <k.kozlowski@samsung.com> (reviewer)
> Lee Jones <lee.jones@linaro.org> (supporter:MULTIFUNCTION DEVICES (MFD))
> 
> He also works for Samsung so the driver is not only maintained but
> supported since he can actually take care of it as a part of his day
> job (if I understood correctly).

Oh, that's interesting semantic change. Yes, in that particular case, I
added the "supported" tag on purpose - it's part of my job. It is
connected with what I said in other reply - we have deep interest in
these drivers. Not only "I will review the code if I have the time". No.
I will devote my time to ensure that the code is working on our products.

Best regards,
Krzysztof

  parent reply	other threads:[~2015-10-28  9:31 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 15:42 [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag Lee Jones
2015-10-27 15:42 ` Lee Jones
2015-10-27 17:24 ` Sebastian Reichel
2015-10-27 17:24   ` Sebastian Reichel
2015-10-27 18:15   ` Lee Jones
2015-10-27 18:15     ` Lee Jones
2015-10-27 18:44     ` Joe Perches
2015-10-27 18:44       ` Joe Perches
2015-10-28  1:46       ` Krzysztof Kozlowski
2015-10-28  1:46         ` Krzysztof Kozlowski
2015-10-28  8:24         ` Lee Jones
2015-10-28  8:24           ` Lee Jones
2015-10-28  9:21           ` Javier Martinez Canillas
2015-10-28  9:21             ` Javier Martinez Canillas
2015-10-28  9:25             ` Javier Martinez Canillas
2015-10-28  9:25               ` Javier Martinez Canillas
2015-10-28  9:31             ` Krzysztof Kozlowski [this message]
2015-10-28  9:31               ` Krzysztof Kozlowski
2015-10-28 10:28             ` Lee Jones
2015-10-28 10:28               ` Lee Jones
2015-10-28 10:53               ` Javier Martinez Canillas
2015-10-28 10:53                 ` Javier Martinez Canillas
2015-10-28 11:06                 ` Joe Perches
2015-10-28 11:06                   ` Joe Perches
2015-10-28 11:25                   ` Javier Martinez Canillas
2015-10-28 11:25                     ` Javier Martinez Canillas
2015-10-28 11:39                     ` Lee Jones
2015-10-28 11:39                       ` Lee Jones
2015-10-28 12:14                       ` Lee Jones
2015-10-28 12:14                         ` Lee Jones
2015-10-28 12:20                         ` Joe Perches
2015-10-28 12:20                           ` Joe Perches
2015-10-28 12:24                           ` Lee Jones
2015-10-28 12:24                             ` Lee Jones
2015-10-28 12:46                             ` Joe Perches
2015-10-28 12:46                               ` Joe Perches
2015-10-28 13:06                         ` Javier Martinez Canillas
2015-10-28 13:06                           ` Javier Martinez Canillas
2015-10-28 13:34                           ` Lee Jones
2015-10-28 13:34                             ` Lee Jones
2015-10-28 14:09                             ` Javier Martinez Canillas
2015-10-28 14:09                               ` Javier Martinez Canillas
2015-10-28 14:38                               ` Lee Jones
2015-10-28 14:38                                 ` Lee Jones
2015-10-28 14:54                                 ` Javier Martinez Canillas
2015-10-28 14:54                                   ` Javier Martinez Canillas
2015-10-28 23:56                                 ` Krzysztof Kozlowski
2015-10-28 23:56                                   ` Krzysztof Kozlowski
2015-10-29  0:12                                   ` Javier Martinez Canillas
2015-10-29  0:12                                     ` Javier Martinez Canillas
2015-10-30 16:51                                     ` Lee Jones
2015-10-30 16:51                                       ` Lee Jones
2015-10-30 16:51                                   ` Lee Jones
2015-10-30 16:51                                     ` Lee Jones
2015-10-28  9:23           ` Krzysztof Kozlowski
2015-10-28  9:23             ` Krzysztof Kozlowski
2015-10-28  9:39             ` Uwe Kleine-König
2015-10-28  9:39               ` Uwe Kleine-König
2015-10-28  9:55               ` Lee Jones
2015-10-28  9:55                 ` Lee Jones
2015-10-28 13:13                 ` Krzysztof Kozlowski
2015-10-28 13:13                   ` Krzysztof Kozlowski
2015-10-28 16:41                   ` [PATCH] get_maintainer: Add subsystem to reviewer output Joe Perches
2015-10-28 16:41                     ` Joe Perches
2015-10-28 17:01                     ` Lee Jones
2015-10-28 17:01                       ` Lee Jones
2015-10-28 17:08                       ` Joe Perches
2015-10-28 17:08                         ` Joe Perches
2015-10-28 17:22                         ` Lee Jones
2015-10-28 17:22                           ` Lee Jones
2015-10-28 17:30                           ` Joe Perches
2015-10-28 17:30                             ` Joe Perches
2015-10-28 17:49                             ` Lee Jones
2015-10-28 17:49                               ` Lee Jones
2015-10-28 17:56                               ` Joe Perches
2015-10-28 17:56                                 ` Joe Perches
2015-10-29  9:20                                 ` Lee Jones
2015-10-29  9:20                                   ` Lee Jones
2015-10-29 14:14                                   ` Joe Perches
2015-10-29 14:14                                     ` Joe Perches
2015-10-29 16:17                                     ` Lee Jones
2015-10-29 16:17                                       ` Lee Jones
2015-10-28 17:18                       ` Joe Perches
2015-10-28 17:18                         ` Joe Perches
2015-10-28 23:49                     ` Krzysztof Kozlowski
2015-10-28 23:49                       ` Krzysztof Kozlowski
2015-10-28 10:14             ` [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag Lee Jones
2015-10-28 10:14               ` Lee Jones
2015-10-28 13:27               ` Krzysztof Kozlowski
2015-10-28 13:27                 ` Krzysztof Kozlowski
2015-10-28 13:49                 ` Lee Jones
2015-10-28 13:49                   ` Lee Jones
2015-10-28 16:26           ` Bartlomiej Zolnierkiewicz
2015-10-28 16:26             ` Bartlomiej Zolnierkiewicz
2015-10-28 16:33             ` Lee Jones
2015-10-28 16:33               ` Lee Jones
2015-10-28  8:57 ` Chanwoo Choi
2015-10-28  8:57   ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563095E1.9010406@samsung.com \
    --to=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.