All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag
Date: Fri, 30 Oct 2015 16:51:57 +0000	[thread overview]
Message-ID: <20151030165157.GX4058@x1> (raw)
In-Reply-To: <CABxcv=mXD3AhWeqZJ4vigCtQ7utBgG2_BD0TKcjr2ctL2MjMbQ@mail.gmail.com>

On Thu, 29 Oct 2015, Javier Martinez Canillas wrote:

> Hello Lee,
> 
> On Thu, Oct 29, 2015 at 12:56 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
> > On 28.10.2015 23:38, Lee Jones wrote:
> >> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote:
> >>> They are not maintainers according to your definition of maintainer
> >>> that doesn't seem what most people agree with.
> >>
> >> "most people" so far are 3 people that I assume still want to be
> >> Maintainers despite not actually conducting Maintainer duties, but
> >> are rather Reviewers.  I also have 2 Acks for this patch, so thus far
> >> that's 3 that agree and 3 that do not.  Unsurprisingly the ones that
> >> agree are Maintainers and the ones who are not are (by my definition)
> >> Reviewers -- go figure.
> >>
> >
> > I am not sure on which side you put me finally. :)
> > If there is a consensus among some more experienced developers that
> > maintainer means branch and patches maintaining, then I won't see any
> > problem with the patch nor with switching Samsung PMIC entries to review.
> >
> > In that case, that would be:
> > Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >
> 
> Same for me, what I don't want is to have different meanings per
> subsystems of what maintainers and reviewers mean since that could
> confuse developers posting patches.
> 
> But if there is a kernel wide consensus and all subsystems entries are
> going to be updated to use the same semantics and list as Reviewer to
> people that don't keep git trees, then I'm OK with this patch and you
> can add my:
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Thanks Javier, but I'm going to drop this patch.

I can see it causing more issues than it'll solve.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Joe Perches <joe@perches.com>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	Linus Walleij <linus.walleij@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Mark Brown <broonie@kernel.org>, Ben Dooks <ben-linux@fluff.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag
Date: Fri, 30 Oct 2015 16:51:57 +0000	[thread overview]
Message-ID: <20151030165157.GX4058@x1> (raw)
In-Reply-To: <CABxcv=mXD3AhWeqZJ4vigCtQ7utBgG2_BD0TKcjr2ctL2MjMbQ@mail.gmail.com>

On Thu, 29 Oct 2015, Javier Martinez Canillas wrote:

> Hello Lee,
> 
> On Thu, Oct 29, 2015 at 12:56 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
> > On 28.10.2015 23:38, Lee Jones wrote:
> >> On Wed, 28 Oct 2015, Javier Martinez Canillas wrote:
> >>> They are not maintainers according to your definition of maintainer
> >>> that doesn't seem what most people agree with.
> >>
> >> "most people" so far are 3 people that I assume still want to be
> >> Maintainers despite not actually conducting Maintainer duties, but
> >> are rather Reviewers.  I also have 2 Acks for this patch, so thus far
> >> that's 3 that agree and 3 that do not.  Unsurprisingly the ones that
> >> agree are Maintainers and the ones who are not are (by my definition)
> >> Reviewers -- go figure.
> >>
> >
> > I am not sure on which side you put me finally. :)
> > If there is a consensus among some more experienced developers that
> > maintainer means branch and patches maintaining, then I won't see any
> > problem with the patch nor with switching Samsung PMIC entries to review.
> >
> > In that case, that would be:
> > Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >
> 
> Same for me, what I don't want is to have different meanings per
> subsystems of what maintainers and reviewers mean since that could
> confuse developers posting patches.
> 
> But if there is a kernel wide consensus and all subsystems entries are
> going to be updated to use the same semantics and list as Reviewer to
> people that don't keep git trees, then I'm OK with this patch and you
> can add my:
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Thanks Javier, but I'm going to drop this patch.

I can see it causing more issues than it'll solve.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2015-10-30 16:51 UTC|newest]

Thread overview: 98+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 15:42 [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag Lee Jones
2015-10-27 15:42 ` Lee Jones
2015-10-27 17:24 ` Sebastian Reichel
2015-10-27 17:24   ` Sebastian Reichel
2015-10-27 18:15   ` Lee Jones
2015-10-27 18:15     ` Lee Jones
2015-10-27 18:44     ` Joe Perches
2015-10-27 18:44       ` Joe Perches
2015-10-28  1:46       ` Krzysztof Kozlowski
2015-10-28  1:46         ` Krzysztof Kozlowski
2015-10-28  8:24         ` Lee Jones
2015-10-28  8:24           ` Lee Jones
2015-10-28  9:21           ` Javier Martinez Canillas
2015-10-28  9:21             ` Javier Martinez Canillas
2015-10-28  9:25             ` Javier Martinez Canillas
2015-10-28  9:25               ` Javier Martinez Canillas
2015-10-28  9:31             ` Krzysztof Kozlowski
2015-10-28  9:31               ` Krzysztof Kozlowski
2015-10-28 10:28             ` Lee Jones
2015-10-28 10:28               ` Lee Jones
2015-10-28 10:53               ` Javier Martinez Canillas
2015-10-28 10:53                 ` Javier Martinez Canillas
2015-10-28 11:06                 ` Joe Perches
2015-10-28 11:06                   ` Joe Perches
2015-10-28 11:25                   ` Javier Martinez Canillas
2015-10-28 11:25                     ` Javier Martinez Canillas
2015-10-28 11:39                     ` Lee Jones
2015-10-28 11:39                       ` Lee Jones
2015-10-28 12:14                       ` Lee Jones
2015-10-28 12:14                         ` Lee Jones
2015-10-28 12:20                         ` Joe Perches
2015-10-28 12:20                           ` Joe Perches
2015-10-28 12:24                           ` Lee Jones
2015-10-28 12:24                             ` Lee Jones
2015-10-28 12:46                             ` Joe Perches
2015-10-28 12:46                               ` Joe Perches
2015-10-28 13:06                         ` Javier Martinez Canillas
2015-10-28 13:06                           ` Javier Martinez Canillas
2015-10-28 13:34                           ` Lee Jones
2015-10-28 13:34                             ` Lee Jones
2015-10-28 14:09                             ` Javier Martinez Canillas
2015-10-28 14:09                               ` Javier Martinez Canillas
2015-10-28 14:38                               ` Lee Jones
2015-10-28 14:38                                 ` Lee Jones
2015-10-28 14:54                                 ` Javier Martinez Canillas
2015-10-28 14:54                                   ` Javier Martinez Canillas
2015-10-28 23:56                                 ` Krzysztof Kozlowski
2015-10-28 23:56                                   ` Krzysztof Kozlowski
2015-10-29  0:12                                   ` Javier Martinez Canillas
2015-10-29  0:12                                     ` Javier Martinez Canillas
2015-10-30 16:51                                     ` Lee Jones [this message]
2015-10-30 16:51                                       ` Lee Jones
2015-10-30 16:51                                   ` Lee Jones
2015-10-30 16:51                                     ` Lee Jones
2015-10-28  9:23           ` Krzysztof Kozlowski
2015-10-28  9:23             ` Krzysztof Kozlowski
2015-10-28  9:39             ` Uwe Kleine-König
2015-10-28  9:39               ` Uwe Kleine-König
2015-10-28  9:55               ` Lee Jones
2015-10-28  9:55                 ` Lee Jones
2015-10-28 13:13                 ` Krzysztof Kozlowski
2015-10-28 13:13                   ` Krzysztof Kozlowski
2015-10-28 16:41                   ` [PATCH] get_maintainer: Add subsystem to reviewer output Joe Perches
2015-10-28 16:41                     ` Joe Perches
2015-10-28 17:01                     ` Lee Jones
2015-10-28 17:01                       ` Lee Jones
2015-10-28 17:08                       ` Joe Perches
2015-10-28 17:08                         ` Joe Perches
2015-10-28 17:22                         ` Lee Jones
2015-10-28 17:22                           ` Lee Jones
2015-10-28 17:30                           ` Joe Perches
2015-10-28 17:30                             ` Joe Perches
2015-10-28 17:49                             ` Lee Jones
2015-10-28 17:49                               ` Lee Jones
2015-10-28 17:56                               ` Joe Perches
2015-10-28 17:56                                 ` Joe Perches
2015-10-29  9:20                                 ` Lee Jones
2015-10-29  9:20                                   ` Lee Jones
2015-10-29 14:14                                   ` Joe Perches
2015-10-29 14:14                                     ` Joe Perches
2015-10-29 16:17                                     ` Lee Jones
2015-10-29 16:17                                       ` Lee Jones
2015-10-28 17:18                       ` Joe Perches
2015-10-28 17:18                         ` Joe Perches
2015-10-28 23:49                     ` Krzysztof Kozlowski
2015-10-28 23:49                       ` Krzysztof Kozlowski
2015-10-28 10:14             ` [PATCH] MAINTAINERS: Start using the 'reviewer' (R) tag Lee Jones
2015-10-28 10:14               ` Lee Jones
2015-10-28 13:27               ` Krzysztof Kozlowski
2015-10-28 13:27                 ` Krzysztof Kozlowski
2015-10-28 13:49                 ` Lee Jones
2015-10-28 13:49                   ` Lee Jones
2015-10-28 16:26           ` Bartlomiej Zolnierkiewicz
2015-10-28 16:26             ` Bartlomiej Zolnierkiewicz
2015-10-28 16:33             ` Lee Jones
2015-10-28 16:33               ` Lee Jones
2015-10-28  8:57 ` Chanwoo Choi
2015-10-28  8:57   ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151030165157.GX4058@x1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.