All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Bart Van Assche <bvanassche@acm.org>,
	Theodore Tso <tytso@mit.edu>,
	linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org,
	Akilesh Kailash <akailash@google.com>,
	linux-fsdevel@vger.kernel.org,
	Christian Brauner <christian@brauner.io>
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: another way to set large folio by remembering inode number
Date: Wed, 27 May 2026 15:59:35 +0000	[thread overview]
Message-ID: <ahcU5xbVy7xjps02@google.com> (raw)
In-Reply-To: <ahaPDHiXcJoVShPv@infradead.org>

On 05/26, Christoph Hellwig wrote:
> On Tue, May 26, 2026 at 09:14:52AM -0700, Bart Van Assche wrote:
> > On 5/26/26 6:42 AM, Theodore Tso wrote:
> > > It seems... surprising that the additional I/O operations are actually
> > > throttloing UFS device bandwidth by 2x (4GB/s vs 2GB/s).  Have you dug
> > > into why this is happening, and whether there is anything that can be
> > > optimized below the file system?
> > The layers below the filesystem (block, SCSI, UFS) is what I'm
> > responsible for in the Pixel team and I can assure you that these are
> > highly optimized.
> > 
> > Since the transfer size used in Jaegeuk's tests is much larger than 4
> > KiB, how many CPU cycles are used per IO by the layers below the
> > filesystem is not limiting the transfer bandwidth.
> 
> I'm honestly not sure what discussion we have here.  Larger I/O is
> pretty much always more efficient.  If you submit smaller I/O you
> need more merging to build it back up larger, and more I/Os.

F2FS merges bios before submit_bio, regardless of small or large folios,
since the block addresses are consecutive. So, I think IO subsystem was
working in full speed.

> 
> Which is exaxtly why we need large folio support everywhere, as it
> makes a huge difference in I/O performance.
> 
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Theodore Tso <tytso@mit.edu>,
	Bart Van Assche <bvanassche@acm.org>,
	linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org,
	Akilesh Kailash <akailash@google.com>,
	Christian Brauner <christian@brauner.io>
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: another way to set large folio by remembering inode number
Date: Wed, 27 May 2026 15:59:35 +0000	[thread overview]
Message-ID: <ahcU5xbVy7xjps02@google.com> (raw)
In-Reply-To: <ahaPDHiXcJoVShPv@infradead.org>

On 05/26, Christoph Hellwig wrote:
> On Tue, May 26, 2026 at 09:14:52AM -0700, Bart Van Assche wrote:
> > On 5/26/26 6:42 AM, Theodore Tso wrote:
> > > It seems... surprising that the additional I/O operations are actually
> > > throttloing UFS device bandwidth by 2x (4GB/s vs 2GB/s).  Have you dug
> > > into why this is happening, and whether there is anything that can be
> > > optimized below the file system?
> > The layers below the filesystem (block, SCSI, UFS) is what I'm
> > responsible for in the Pixel team and I can assure you that these are
> > highly optimized.
> > 
> > Since the transfer size used in Jaegeuk's tests is much larger than 4
> > KiB, how many CPU cycles are used per IO by the layers below the
> > filesystem is not limiting the transfer bandwidth.
> 
> I'm honestly not sure what discussion we have here.  Larger I/O is
> pretty much always more efficient.  If you submit smaller I/O you
> need more merging to build it back up larger, and more I/Os.

F2FS merges bios before submit_bio, regardless of small or large folios,
since the block addresses are consecutive. So, I think IO subsystem was
working in full speed.

> 
> Which is exaxtly why we need large folio support everywhere, as it
> makes a huge difference in I/O performance.
> 
> 
> 
> _______________________________________________
> Linux-f2fs-devel mailing list
> Linux-f2fs-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2026-05-27 15:59 UTC|newest]

Thread overview: 116+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 13:45 [f2fs-dev] [PATCH] f2fs: another way to set large folio by remembering inode number Jaegeuk Kim via Linux-f2fs-devel
2026-04-09 13:45 ` Jaegeuk Kim
2026-04-10  1:16 ` [f2fs-dev] [PATCH v2] " Jaegeuk Kim via Linux-f2fs-devel
2026-04-10  1:16   ` Jaegeuk Kim
2026-04-14  8:02   ` Christoph Hellwig
2026-04-14  8:02     ` [f2fs-dev] " Christoph Hellwig
2026-04-15 16:44     ` Jaegeuk Kim
2026-04-15 16:44       ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-04-15 17:15       ` Matthew Wilcox
2026-04-15 17:15         ` [f2fs-dev] " Matthew Wilcox
2026-04-15 22:02         ` Jaegeuk Kim
2026-04-15 22:02           ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-04-15 23:49           ` Darrick J. Wong
2026-04-15 23:49             ` [f2fs-dev] " Darrick J. Wong via Linux-f2fs-devel
2026-04-16  1:19             ` Jaegeuk Kim
2026-04-16  1:19               ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-05-21  8:51         ` Christoph Hellwig
2026-05-21  8:51           ` [f2fs-dev] " Christoph Hellwig
2026-05-21 15:57           ` Theodore Tso
2026-05-21 15:57             ` [f2fs-dev] " Theodore Tso
2026-05-21 17:42             ` Matthew Wilcox
2026-05-21 17:42               ` [f2fs-dev] " Matthew Wilcox
2026-05-22  3:59               ` Jaegeuk Kim
2026-05-22  3:59                 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-05-22 12:55                 ` Matthew Wilcox
2026-05-22 12:55                   ` [f2fs-dev] " Matthew Wilcox
2026-05-22 14:04                   ` Jaegeuk Kim
2026-05-22 14:04                     ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-25  5:34                     ` Christoph Hellwig
2026-05-25  5:34                       ` Christoph Hellwig
2026-05-26  1:21                       ` Jaegeuk Kim
2026-05-26  1:21                         ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-26  2:31                         ` Matthew Wilcox
2026-05-26  2:31                           ` Matthew Wilcox
2026-05-26  3:47                           ` Jaegeuk Kim
2026-05-26  3:47                             ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-27  6:33                             ` Christoph Hellwig
2026-05-27  6:33                               ` Christoph Hellwig
2026-05-27  6:26                           ` Christoph Hellwig
2026-05-27  6:26                             ` Christoph Hellwig
2026-05-27 15:42                             ` Jaegeuk Kim
2026-05-27 15:42                               ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-25  5:34               ` Christoph Hellwig
2026-05-25  5:34                 ` [f2fs-dev] " Christoph Hellwig
2026-05-22  3:32             ` Jaegeuk Kim
2026-05-22  3:32               ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-22  3:53               ` Eric Biggers
2026-05-22  3:53                 ` Eric Biggers via Linux-f2fs-devel
2026-05-22  4:02                 ` Jaegeuk Kim
2026-05-22  4:02                   ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-22 10:01                 ` Christian Brauner
2026-05-22 10:01                   ` Christian Brauner via Linux-f2fs-devel
2026-05-22 14:11               ` Theodore Tso
2026-05-22 14:11                 ` Theodore Tso
2026-05-22 17:08                 ` Jaegeuk Kim
2026-05-22 17:08                   ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-22 22:41                   ` Theodore Tso
2026-05-22 22:41                     ` Theodore Tso
2026-05-26  1:10                     ` Jaegeuk Kim
2026-05-26  1:10                       ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-26  2:35                       ` Matthew Wilcox
2026-05-26  2:35                         ` Matthew Wilcox
2026-05-26  3:34                         ` Jaegeuk Kim
2026-05-26  3:34                           ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-26  3:35                       ` Randy Dunlap
2026-05-26  3:35                         ` Randy Dunlap
2026-05-26  4:12                         ` Jaegeuk Kim
2026-05-26  4:12                           ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-26 13:42                       ` Theodore Tso
2026-05-26 13:42                         ` Theodore Tso
2026-05-26 16:14                         ` Bart Van Assche
2026-05-26 16:14                           ` Bart Van Assche via Linux-f2fs-devel
2026-05-27  6:28                           ` Christoph Hellwig
2026-05-27  6:28                             ` Christoph Hellwig
2026-05-27 15:59                             ` Jaegeuk Kim [this message]
2026-05-27 15:59                               ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-29  5:36                               ` Christoph Hellwig
2026-05-29  5:36                                 ` Christoph Hellwig
2026-05-31  0:12                                 ` Jaegeuk Kim
2026-05-31  0:12                                   ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-31  5:28                                   ` Barry Song
2026-05-31  5:28                                     ` Barry Song via Linux-f2fs-devel
2026-06-01  1:52                                     ` Jaegeuk Kim
2026-06-01  1:52                                       ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-26 21:52                         ` Jaegeuk Kim
2026-05-26 21:52                           ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-27  1:21                           ` Theodore Tso
2026-05-27  1:21                             ` Theodore Tso
2026-05-27  2:43                             ` Jaegeuk Kim
2026-05-27  2:43                               ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-27  3:30                               ` Matthew Wilcox
2026-05-27  3:30                                 ` Matthew Wilcox
2026-05-27 15:39                                 ` Jaegeuk Kim
2026-05-27 15:39                                   ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-27  6:31                             ` Christoph Hellwig
2026-05-27  6:31                               ` Christoph Hellwig
2026-05-27  1:15                         ` Bart Van Assche via Linux-f2fs-devel
2026-05-27  1:15                           ` Bart Van Assche
2026-05-28 19:36                       ` Matthew Wilcox
2026-05-28 19:36                         ` Matthew Wilcox
2026-05-31  0:35                         ` Jaegeuk Kim
2026-05-31  0:35                           ` Jaegeuk Kim via Linux-f2fs-devel
2026-05-25  5:37               ` Christoph Hellwig
2026-05-25  5:37                 ` Christoph Hellwig
2026-05-22  9:59             ` Christian Brauner
2026-05-22  9:59               ` [f2fs-dev] " Christian Brauner via Linux-f2fs-devel
2026-04-15 16:41   ` Jaegeuk Kim
2026-04-15 16:41     ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2026-04-17  0:58   ` Chao Yu via Linux-f2fs-devel
2026-04-17  0:58     ` Chao Yu
2026-04-17 16:54     ` Jaegeuk Kim via Linux-f2fs-devel
2026-04-17 16:54       ` Jaegeuk Kim
2026-04-18  1:08       ` Chao Yu via Linux-f2fs-devel
2026-04-18  1:08         ` Chao Yu
2026-04-18  1:11   ` Chao Yu via Linux-f2fs-devel
2026-04-18  1:11     ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahcU5xbVy7xjps02@google.com \
    --to=jaegeuk@kernel.org \
    --cc=akailash@google.com \
    --cc=bvanassche@acm.org \
    --cc=christian@brauner.io \
    --cc=hch@infradead.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tytso@mit.edu \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.