[Buildroot] [PATCH 00/17] board: cleanup genimage partition-type-uuid shortcuts

[Buildroot] [PATCH 00/17] board: cleanup genimage partition-type-uuid shortcuts

[Brandon Maier]

Buildroot boards using genimage's "partition-type-uuid" can use either a
full GUID or one of the shortcuts defined in genimage[1]. The Buildroot
manual recommends using the "L", "U", or "F" shortcuts over a full GUID;
but does not specify how any other GUID should be defined.

This series tries to bring consistency to partition-type-uuid by making
shortcuts the preferred method. First we update the Buildroot manual to
say shortcuts should be preferred when available. Then we update all
boards to use shortcuts.

This series is partially implementing Thomas suggestion to have
consistency when using "L" vs "root-${ARCH}" vs full GUIDs[2].

[1] https://github.com/pengutronix/genimage/blob/master/image-hd.c#L264
[2] https://lore.kernel.org/buildroot/20241022224945.4dc67b89@windsurf/

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
Brandon Maier (17):
      docs/manual/writing-rules: add shortcuts for genimage partition-type-uuid
      board/beagleboard: use partition-type-uuid "L"
      board/sifive: use partition-type-uuid "L"
      board/visionfive2: use partition-type-uuid "L"
      board/pc: use partition-type-uuid "root-x86"
      support/testing/tests/boot/test_grub: use partition-type-uuid "root-x86"
      board/mender: use partition-type-uuid "root-x86-64"
      board/radxa: use partition-type-uuid "root-arm"
      board/qemu/arm-ebbr: use partition-type-uuid "root-arm"
      board/qemu/riscv64-virt-efi: use partition-type-uuid "root-riscv64"
      board/aarch64-efi: use partition-type-uuid "root-arm64"
      board/arm: use partition-type-uuid "root-arm64"
      board/pine64: use partition-type-uuid "root-arm64"
      board/qemu/aarch64-ebbr: use partition-type-uuid "root-arm64"
      board/qemu/aarch64-sbsa: use partition-type-uuid "root-arm64"
      board/visionfive2: use partition-type-uuid "xbootldr"
      support/testing/tests/boot/test_grub: use partition-type-uuid "U"

 board/aarch64-efi/genimage-efi.cfg                 |  2 +-
 board/arm/fvp-ebbr/genimage.cfg                    |  2 +-
 board/beagleboard/beaglev_fire/genimage.cfg        |  2 +-
 board/mender/x86_64/genimage-efi.cfg               |  4 ++--
 board/pc/genimage-efi.cfg                          |  2 +-
 board/pine64/rockpro64/genimage.cfg                |  2 +-
 board/qemu/aarch64-ebbr/genimage.cfg               |  2 +-
 board/qemu/aarch64-sbsa/genimage.cfg               |  2 +-
 board/qemu/arm-ebbr/genimage.cfg                   |  2 +-
 board/qemu/riscv64-virt-efi/genimage.cfg           |  2 +-
 board/radxa/rockpi-n8/genimage.cfg                 |  2 +-
 board/sifive/hifive-unleashed/genimage_sdcard.cfg  |  2 +-
 board/visionfive2/genimage.cfg                     |  4 ++--
 docs/manual/writing-rules.adoc                     | 28 +++++++++++++---------
 .../tests/boot/test_grub/genimage-aarch64-efi.cfg  |  4 ++--
 15 files changed, 34 insertions(+), 28 deletions(-)
---
base-commit: 0df7dfb804457a62c7751eec6555ad75158e3e3d
change-id: 20241109-genimage-partition-type-uuid-8e4c62ee041f

Best regards,
-- 
Brandon Maier <brandon.maier@gmail.com>

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 01/17] docs/manual/writing-rules: add shortcuts for genimage partition-type-uuid

[Brandon Maier]

Prefer the use of genimage partition-type-uuid shortcuts over using the
full GUID. To make shortcuts easier to find, include a link to the full
list in the genimage source.

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 docs/manual/writing-rules.adoc | 28 +++++++++++++++++-----------
 1 file changed, 17 insertions(+), 11 deletions(-)

diff --git a/docs/manual/writing-rules.adoc b/docs/manual/writing-rules.adoc
index 03e4f2c61cfe4820fe6d06d193b9215d423bf4d7..10f25a7011db2f8d4ea7c4acb3ea66c4dcce7a86 100644
--- a/docs/manual/writing-rules.adoc
+++ b/docs/manual/writing-rules.adoc
@@ -198,17 +198,23 @@ image sdimage.img {
   chance, the byte count.  In comments instead use +GB+, +MB+, +KB+
   (not +kb+) in place of +G+, +M+, +K+.
 
-* For GPT partitions, the +partition-type-uuid+ value must be +U+ for
-  the EFI System Partition (expanded to
-  +c12a7328-f81f-11d2-ba4b-00a0c93ec93b+ by _genimage_), +F+ for a FAT
-  partition (expanded to +ebd0a0a2-b9e5-4433-87c0-68b6b72699c7+ by
-  _genimage_) or +L+ for the root filesystem or other filesystems
-  (expanded to +0fc63daf-8483-4772-8e79-3d69d8477de4+ by
-  _genimage_). Even though +L+ is the default value of _genimage_, we
-  prefer to have it explicitly specified in our +genimage.cfg+
-  files. Finally, these shortcuts should be used without double
-  quotes, e.g +partition-type-uuid = U+. If an explicit GUID is
-  specified, lower-case letters should be used.
+* For GPT partitions, the +partition-type-uuid+ value must use a GUID shortcut
+  if it is supported by genimage. These shortcuts should be used without double
+  quotes, e.g +partition-type-uuid = U+. If an explicit GUID is specified,
+  lower-case letters should be used. Even though the shortcut +L+ is the
+  default value of _genimage_, we prefer to have it explicitly specified in our
+  +genimage.cfg+ files. Some common shortcuts are provided below, for the full
+  list see the +gpt_partition_type_shortcuts+ table in
+  https://github.com/pengutronix/genimage/blob/master/image-hd.c[].
+
+** +U+ for the EFI System Partition (expanded to
+   +c12a7328-f81f-11d2-ba4b-00a0c93ec93b+ by _genimage_)
+
+** +F+ for a FAT partition (expanded to +ebd0a0a2-b9e5-4433-87c0-68b6b72699c7+
+   by _genimage_)
+
+** +L+ for the root filesystem or other filesystems (expanded to
+   +0fc63daf-8483-4772-8e79-3d69d8477de4+ by _genimage_).
 
 The +genimage.cfg+ files are the input for the genimage tool used in
 Buildroot to generate the final image file(i.e. sdcard.img). For further

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 02/17] board/beagleboard: use partition-type-uuid "L"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/beagleboard/beaglev_fire/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/beagleboard/beaglev_fire/genimage.cfg b/board/beagleboard/beaglev_fire/genimage.cfg
index ef650704c65f24eea37fb1fa8d53b5759062d570..0241480ad6041883a799ed68c6f080d8a3b29cae 100644
--- a/board/beagleboard/beaglev_fire/genimage.cfg
+++ b/board/beagleboard/beaglev_fire/genimage.cfg
@@ -24,7 +24,7 @@ image sdcard.img {
 	}
 
 	partition kernel {
-		partition-type-uuid = 0FC63DAF-8483-4772-8E79-3D69D8477DE4
+		partition-type-uuid = L
 		bootable = "true"
 		image = "boot.vfat"
 	}

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 03/17] board/sifive: use partition-type-uuid "L"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/sifive/hifive-unleashed/genimage_sdcard.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/sifive/hifive-unleashed/genimage_sdcard.cfg b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
index 99e3525a8cf4cfe2abc84200becab0a38b4142d1..93355eaea9f0670b39d2357172b74ea43f0eaad5 100644
--- a/board/sifive/hifive-unleashed/genimage_sdcard.cfg
+++ b/board/sifive/hifive-unleashed/genimage_sdcard.cfg
@@ -18,7 +18,7 @@ image sdcard.img {
 	partition rootfs {
 		image = "rootfs.ext4"
 		offset = 4076K
-		partition-type-uuid = 0fc63daf-8483-4772-8e79-3d69d8477de4
+		partition-type-uuid = L
 		bootable = true
 	}
 }

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 04/17] board/visionfive2: use partition-type-uuid "L"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/visionfive2/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/visionfive2/genimage.cfg b/board/visionfive2/genimage.cfg
index 8133e740c0da233873937540d2a42b76d05a6f19..73d027c2e843246eaa8a4323e874c8892c0c2b88 100644
--- a/board/visionfive2/genimage.cfg
+++ b/board/visionfive2/genimage.cfg
@@ -16,7 +16,7 @@ image sdcard.img {
 	}
 
 	partition rootfs {
-		partition-type-uuid = 0FC63DAF-8483-4772-8E79-3D69D8477DE4
+		partition-type-uuid = L
 		bootable = true
 		image = "rootfs.ext4"
 	}

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 05/17] board/pc: use partition-type-uuid "root-x86"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/pc/genimage-efi.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/pc/genimage-efi.cfg b/board/pc/genimage-efi.cfg
index c231e1b9b2626c5a788c85511b1f1e9d12759d33..7d3d69bd067c2c39f5188d82d2e1fd11088657e1 100644
--- a/board/pc/genimage-efi.cfg
+++ b/board/pc/genimage-efi.cfg
@@ -25,7 +25,7 @@ image disk.img {
 	}
 
 	partition root {
-		partition-type-uuid = 44479540-f297-41b2-9af7-d131d5f0458a
+		partition-type-uuid = root-x86
 		partition-uuid = UUID_TMP
 		image = "rootfs.ext2"
 	}

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 06/17] support/testing/tests/boot/test_grub: use partition-type-uuid "root-x86"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg b/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
index 11615c885a062d5a86917bb942360a2ab9b3c2de..9717076ca871eb3efb4fea7ca94297d022839de3 100644
--- a/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
+++ b/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
@@ -25,7 +25,7 @@ image disk.img {
 	}
 
 	partition root {
-		partition-type-uuid = 44479540-f297-41b2-9af7-d131d5f0458a
+		partition-type-uuid = root-x86
 		partition-uuid = UUID_TMP
 		image = "rootfs.ext2"
 	}

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 07/17] board/mender: use partition-type-uuid "root-x86-64"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/mender/x86_64/genimage-efi.cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/mender/x86_64/genimage-efi.cfg b/board/mender/x86_64/genimage-efi.cfg
index 9c2723d8fb11958414670e60445bd2a86157269f..1bce8673b7a309d5bfc421044e5f671710270e52 100644
--- a/board/mender/x86_64/genimage-efi.cfg
+++ b/board/mender/x86_64/genimage-efi.cfg
@@ -27,12 +27,12 @@ image disk.img {
 	}
 
 	partition roota {
-		partition-type-uuid = 4F68BCE3-E8CD-4DB1-96E7-FBCAF984B709
+		partition-type-uuid = root-x86-64
 		image = "rootfs.ext2"
 	}
 
 	partition rootb {
-		partition-type-uuid = 4F68BCE3-E8CD-4DB1-96E7-FBCAF984B709
+		partition-type-uuid = root-x86-64
 		image = "rootfs.ext2"
 	}
 

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 08/17] board/radxa: use partition-type-uuid "root-arm"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/radxa/rockpi-n8/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/radxa/rockpi-n8/genimage.cfg b/board/radxa/rockpi-n8/genimage.cfg
index bfcd92f590effbb28cc1fa000a333bed46fec416..8165df8f36a82f56fb543d168dc9c6f5a160a2c4 100644
--- a/board/radxa/rockpi-n8/genimage.cfg
+++ b/board/radxa/rockpi-n8/genimage.cfg
@@ -33,7 +33,7 @@ image sdcard.img {
 	}
 
 	partition rootfs {
-		partition-type-uuid = 69dad710-2ce4-4e3c-b16c-21a1d49abed3
+		partition-type-uuid = root-arm
 		image = "rootfs.ext4"
 	}
 }

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 09/17] board/qemu/arm-ebbr: use partition-type-uuid "root-arm"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/qemu/arm-ebbr/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/qemu/arm-ebbr/genimage.cfg b/board/qemu/arm-ebbr/genimage.cfg
index 3d4c9cff1ad55e172421b0a388b52f94eb1f0dae..988c6ec386ffe3ef455fd15d021064681553293c 100644
--- a/board/qemu/arm-ebbr/genimage.cfg
+++ b/board/qemu/arm-ebbr/genimage.cfg
@@ -25,7 +25,7 @@ image disk.img {
 	}
 
 	partition root {
-		partition-type-uuid = 69dad710-2ce4-4e3c-b16c-21a1d49abed3
+		partition-type-uuid = root-arm
 		image = "rootfs.ext2"
 	}
 }

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 10/17] board/qemu/riscv64-virt-efi: use partition-type-uuid "root-riscv64"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/qemu/riscv64-virt-efi/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/qemu/riscv64-virt-efi/genimage.cfg b/board/qemu/riscv64-virt-efi/genimage.cfg
index 46950591e0a3d4c3fb14f81d71a6c2ccf245d564..a7d5420d78dc637a0c18fe7ce2ff86378b55741a 100644
--- a/board/qemu/riscv64-virt-efi/genimage.cfg
+++ b/board/qemu/riscv64-virt-efi/genimage.cfg
@@ -28,7 +28,7 @@ image disk.img {
 		# For partition-type-uuid value, see:
 		# https://uapi-group.org/specifications/specs/discoverable_partitions_specification/
 		# SD_GPT_ROOT_RISCV64
-		partition-type-uuid = 72ec70a6-cf74-40e6-bd49-4bda08e8f224
+		partition-type-uuid = root-riscv64
 		image = "rootfs.ext2"
 	}
 }

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 11/17] board/aarch64-efi: use partition-type-uuid "root-arm64"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/aarch64-efi/genimage-efi.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/aarch64-efi/genimage-efi.cfg b/board/aarch64-efi/genimage-efi.cfg
index 158deab87dc38cb918f066ceb5e9ba8d791e9895..207fc3e3bcc6325eab4cc03cb42a9a5c1978e219 100644
--- a/board/aarch64-efi/genimage-efi.cfg
+++ b/board/aarch64-efi/genimage-efi.cfg
@@ -24,7 +24,7 @@ image disk.img {
 	}
 
 	partition root {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = root-arm64
 		image = "rootfs.ext2"
 	}
 }

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 12/17] board/arm: use partition-type-uuid "root-arm64"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/arm/fvp-ebbr/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/arm/fvp-ebbr/genimage.cfg b/board/arm/fvp-ebbr/genimage.cfg
index 1ca8332b9cd005625a0dc60a3383b6284485a9f2..0d468953c131df43f87417473ea7be0f386df7bf 100644
--- a/board/arm/fvp-ebbr/genimage.cfg
+++ b/board/arm/fvp-ebbr/genimage.cfg
@@ -25,7 +25,7 @@ image disk.img {
 	}
 
 	partition root {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = root-arm64
 		image = "rootfs.ext2"
 	}
 }

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 13/17] board/pine64: use partition-type-uuid "root-arm64"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/pine64/rockpro64/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/pine64/rockpro64/genimage.cfg b/board/pine64/rockpro64/genimage.cfg
index 94fa2f7c0601d1cfd4989fcdec87f6b742ff396a..dbbc7e581e78039e2fe61797f060755643ba426e 100644
--- a/board/pine64/rockpro64/genimage.cfg
+++ b/board/pine64/rockpro64/genimage.cfg
@@ -33,7 +33,7 @@ image sdcard.img {
 	}
 
 	partition rootfs {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = root-arm64
 		image = "rootfs.ext4"
 	}
 }

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 14/17] board/qemu/aarch64-ebbr: use partition-type-uuid "root-arm64"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/qemu/aarch64-ebbr/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/qemu/aarch64-ebbr/genimage.cfg b/board/qemu/aarch64-ebbr/genimage.cfg
index 1ca8332b9cd005625a0dc60a3383b6284485a9f2..0d468953c131df43f87417473ea7be0f386df7bf 100644
--- a/board/qemu/aarch64-ebbr/genimage.cfg
+++ b/board/qemu/aarch64-ebbr/genimage.cfg
@@ -25,7 +25,7 @@ image disk.img {
 	}
 
 	partition root {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = root-arm64
 		image = "rootfs.ext2"
 	}
 }

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 15/17] board/qemu/aarch64-sbsa: use partition-type-uuid "root-arm64"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/qemu/aarch64-sbsa/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/qemu/aarch64-sbsa/genimage.cfg b/board/qemu/aarch64-sbsa/genimage.cfg
index e7ac7f2ee1a5c4bd941c52493fec9cea070728a2..d5daa5fbacf7e662a64aafa16ddb4fc10d2d4067 100644
--- a/board/qemu/aarch64-sbsa/genimage.cfg
+++ b/board/qemu/aarch64-sbsa/genimage.cfg
@@ -25,7 +25,7 @@ image disk.img {
 	}
 
 	partition root {
-		partition-type-uuid = b921b045-1df0-41c3-af44-4c6f280d3fae
+		partition-type-uuid = root-arm64
 		image = "rootfs.ext2"
 	}
 }

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 16/17] board/visionfive2: use partition-type-uuid "xbootldr"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 board/visionfive2/genimage.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/visionfive2/genimage.cfg b/board/visionfive2/genimage.cfg
index 73d027c2e843246eaa8a4323e874c8892c0c2b88..9757a8cd5154d313754d6dc366dc971eab4e31fe 100644
--- a/board/visionfive2/genimage.cfg
+++ b/board/visionfive2/genimage.cfg
@@ -11,7 +11,7 @@ image sdcard.img {
 	}
 
 	partition uboot {
-		partition-type-uuid = BC13C2FF-59E6-4262-A352-B275FD6F7172
+		partition-type-uuid = xbootldr
 		image = "u-boot.itb"
 	}
 

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 17/17] support/testing/tests/boot/test_grub: use partition-type-uuid "U"

[Brandon Maier]

Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
---
 support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg b/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
index 9717076ca871eb3efb4fea7ca94297d022839de3..83e49084dd920d4cf90b3735450402c3b47fdfa1 100644
--- a/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
+++ b/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
@@ -19,7 +19,7 @@ image disk.img {
 
 	partition boot {
 		image = "efi-part.vfat"
-		partition-type-uuid = c12a7328-f81f-11d2-ba4b-00a0c93ec93b
+		partition-type-uuid = U
 		offset = 32K
 		bootable = true
 	}

-- 
2.47.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/17] docs/manual/writing-rules: add shortcuts for genimage partition-type-uuid

[Niklas Cassel via buildroot]

Hello Brandon,

On Sat, Nov 09, 2024 at 04:16:15PM -0600, Brandon Maier wrote:
> Prefer the use of genimage partition-type-uuid shortcuts over using the
> full GUID. To make shortcuts easier to find, include a link to the full
> list in the genimage source.
> 
> Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> ---
>  docs/manual/writing-rules.adoc | 28 +++++++++++++++++-----------
>  1 file changed, 17 insertions(+), 11 deletions(-)
> 
> diff --git a/docs/manual/writing-rules.adoc b/docs/manual/writing-rules.adoc
> index 03e4f2c61cfe4820fe6d06d193b9215d423bf4d7..10f25a7011db2f8d4ea7c4acb3ea66c4dcce7a86 100644
> --- a/docs/manual/writing-rules.adoc
> +++ b/docs/manual/writing-rules.adoc
> @@ -198,17 +198,23 @@ image sdimage.img {
>    chance, the byte count.  In comments instead use +GB+, +MB+, +KB+
>    (not +kb+) in place of +G+, +M+, +K+.
>  
> -* For GPT partitions, the +partition-type-uuid+ value must be +U+ for
> -  the EFI System Partition (expanded to
> -  +c12a7328-f81f-11d2-ba4b-00a0c93ec93b+ by _genimage_), +F+ for a FAT
> -  partition (expanded to +ebd0a0a2-b9e5-4433-87c0-68b6b72699c7+ by
> -  _genimage_) or +L+ for the root filesystem or other filesystems
> -  (expanded to +0fc63daf-8483-4772-8e79-3d69d8477de4+ by
> -  _genimage_). Even though +L+ is the default value of _genimage_, we
> -  prefer to have it explicitly specified in our +genimage.cfg+
> -  files. Finally, these shortcuts should be used without double
> -  quotes, e.g +partition-type-uuid = U+. If an explicit GUID is
> -  specified, lower-case letters should be used.
> +* For GPT partitions, the +partition-type-uuid+ value must use a GUID shortcut
> +  if it is supported by genimage. These shortcuts should be used without double
> +  quotes, e.g +partition-type-uuid = U+. If an explicit GUID is specified,
> +  lower-case letters should be used. Even though the shortcut +L+ is the
> +  default value of _genimage_, we prefer to have it explicitly specified in our
> +  +genimage.cfg+ files. Some common shortcuts are provided below, for the full
> +  list see the +gpt_partition_type_shortcuts+ table in
> +  https://github.com/pengutronix/genimage/blob/master/image-hd.c[].

Like you wrote in the cover letter, this series is only partially
implementing Thomas' suggestion, which was:
"My point is that we want *consistency*. So either we use "L" for all
rootfs partitions. Or we use root-${ARCH} for all rootfs partitions."


While this series is just converting GUIDs to use a shortcut, if there is
one available, I still think that we can update the documentation to be
even stricter, something like:

"For the rootfs partition, the partition type GUID should be set to the
architecture-specific shortcut (e.g. root-arm64), rather than the generic
+L+ shortcut (generic Linux rootfs). An explicit partition type GUID should
always be specified for the rootfs partition."


That way we can remove:
"Even though the shortcut +L+ is the default value of _genimage_,
we prefer to have it explicitly specified in our +genimage.cfg+ files."

I don't like this sentence, because it could be interpreted as that
buildroot prefers to have the GUID explicitly specified (rather than
having the shortcut explicitly specified).



Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 06/17] support/testing/tests/boot/test_grub: use partition-type-uuid "root-x86"

[Niklas Cassel via buildroot]

On Sat, Nov 09, 2024 at 04:16:20PM -0600, Brandon Maier wrote:
> Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> ---
>  support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg b/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
> index 11615c885a062d5a86917bb942360a2ab9b3c2de..9717076ca871eb3efb4fea7ca94297d022839de3 100644
> --- a/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
> +++ b/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
> @@ -25,7 +25,7 @@ image disk.img {
>  	}
>  
>  	partition root {
> -		partition-type-uuid = 44479540-f297-41b2-9af7-d131d5f0458a
> +		partition-type-uuid = root-x86

The filename of this file is:
genimage-aarch64-efi.cfg

Yet you specify root-x86.

I understand that you are just converting to the shortcut,
but should this perhaps be root-arm64 instead?

Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 10/17] board/qemu/riscv64-virt-efi: use partition-type-uuid "root-riscv64"

[Niklas Cassel via buildroot]

On Sat, Nov 09, 2024 at 04:16:24PM -0600, Brandon Maier wrote:
> Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> ---
>  board/qemu/riscv64-virt-efi/genimage.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/qemu/riscv64-virt-efi/genimage.cfg b/board/qemu/riscv64-virt-efi/genimage.cfg
> index 46950591e0a3d4c3fb14f81d71a6c2ccf245d564..a7d5420d78dc637a0c18fe7ce2ff86378b55741a 100644
> --- a/board/qemu/riscv64-virt-efi/genimage.cfg
> +++ b/board/qemu/riscv64-virt-efi/genimage.cfg
> @@ -28,7 +28,7 @@ image disk.img {
>  		# For partition-type-uuid value, see:
>  		# https://uapi-group.org/specifications/specs/discoverable_partitions_specification/
>  		# SD_GPT_ROOT_RISCV64

I would kill the comment above.
Now when using the shortcut, it is self explanatory.


Kind regards,
Niklas

> -		partition-type-uuid = 72ec70a6-cf74-40e6-bd49-4bda08e8f224
> +		partition-type-uuid = root-riscv64
>  		image = "rootfs.ext2"
>  	}
>  }
> 
> -- 
> 2.47.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 00/17] board: cleanup genimage partition-type-uuid shortcuts

[Niklas Cassel via buildroot]

On Sat, Nov 09, 2024 at 04:16:14PM -0600, Brandon Maier wrote:
> Buildroot boards using genimage's "partition-type-uuid" can use either a
> full GUID or one of the shortcuts defined in genimage[1]. The Buildroot
> manual recommends using the "L", "U", or "F" shortcuts over a full GUID;
> but does not specify how any other GUID should be defined.
> 
> This series tries to bring consistency to partition-type-uuid by making
> shortcuts the preferred method. First we update the Buildroot manual to
> say shortcuts should be preferred when available. Then we update all
> boards to use shortcuts.
> 
> This series is partially implementing Thomas suggestion to have
> consistency when using "L" vs "root-${ARCH}" vs full GUIDs[2].
> 
> [1] https://github.com/pengutronix/genimage/blob/master/image-hd.c#L264
> [2] https://lore.kernel.org/buildroot/20241022224945.4dc67b89@windsurf/

Other than some minor comments, the series looks good to me.
Good job!


You seem to have missed one conversion though:
board/radxa/rock5b/genimage.cfg:

partition-type-uuid = 3de21764-95bd-54bd-a5c3-4abe786f38a8

can use shortcut:
partition-type-uuid = u-boot-env


But now when I look at it, it was you who added this to genimage just a
week ago:
https://github.com/pengutronix/genimage/commit/3e0a2aea8d10431f8c8f652129f73544cfa16af2

So we might need to bump genimage in buildroot before we can make use of
that shortcut. (And for that we probably want to wait for a new tagged
release of genimage.)


Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/17] docs/manual/writing-rules: add shortcuts for genimage partition-type-uuid

[Brandon Maier]

Hi Niklas

On Mon, Nov 11, 2024 at 7:11 AM Niklas Cassel <Niklas.Cassel@wdc.com> wrote:
>
> Like you wrote in the cover letter, this series is only partially
> implementing Thomas' suggestion, which was:
> "My point is that we want *consistency*. So either we use "L" for all
> rootfs partitions. Or we use root-${ARCH} for all rootfs partitions."
>
>
> While this series is just converting GUIDs to use a shortcut, if there is
> one available, I still think that we can update the documentation to be
> even stricter, something like:
>
> "For the rootfs partition, the partition type GUID should be set to the
> architecture-specific shortcut (e.g. root-arm64), rather than the generic
> +L+ shortcut (generic Linux rootfs). An explicit partition type GUID should
> always be specified for the rootfs partition."

I left it out of this series as I haven't looked too closely into
which of "L" or "root-*" is better. It doesn't seem like a simple
choice, as U-Boot has a lot of board-specific settings.

Do you and Thomas feel confident that root-$ARCH should be the preferred type?

>
>
> That way we can remove:
> "Even though the shortcut +L+ is the default value of _genimage_,
> we prefer to have it explicitly specified in our +genimage.cfg+ files."
>
> I don't like this sentence, because it could be interpreted as that
> buildroot prefers to have the GUID explicitly specified (rather than
> having the shortcut explicitly specified).

Agreed, if we can migrate all the boards to root-$ARCH then we could
remove this line.

For now, I can move this line down to the section for "+L+". That way
it's not emphasized in the main body.

Thanks!
Brandon Maier

>
>
>
> Kind regards,
> Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 06/17] support/testing/tests/boot/test_grub: use partition-type-uuid "root-x86"

[Brandon Maier]

Hi Niklas,

On Mon, Nov 11, 2024 at 7:16 AM Niklas Cassel <Niklas.Cassel@wdc.com> wrote:
>
> On Sat, Nov 09, 2024 at 04:16:20PM -0600, Brandon Maier wrote:
> > Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> > ---
> >  support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg b/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
> > index 11615c885a062d5a86917bb942360a2ab9b3c2de..9717076ca871eb3efb4fea7ca94297d022839de3 100644
> > --- a/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
> > +++ b/support/testing/tests/boot/test_grub/genimage-aarch64-efi.cfg
> > @@ -25,7 +25,7 @@ image disk.img {
> >       }
> >
> >       partition root {
> > -             partition-type-uuid = 44479540-f297-41b2-9af7-d131d5f0458a
> > +             partition-type-uuid = root-x86
>
> The filename of this file is:
> genimage-aarch64-efi.cfg
>
> Yet you specify root-x86.
>
> I understand that you are just converting to the shortcut,
> but should this perhaps be root-arm64 instead?

Good eye, I was using a script to bulk update. This definitely looks wrong.

I can attempt fixing this, though I would prefer to send it as a
separate patch. So that this series isn't making any functional
changes.

Thanks!
Brandon Maier

>
> Kind regards,
> Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 10/17] board/qemu/riscv64-virt-efi: use partition-type-uuid "root-riscv64"

[Brandon Maier]

Hi Niklas,

On Mon, Nov 11, 2024 at 7:22 AM Niklas Cassel <Niklas.Cassel@wdc.com> wrote:
>
> On Sat, Nov 09, 2024 at 04:16:24PM -0600, Brandon Maier wrote:
> > Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> > ---
> >  board/qemu/riscv64-virt-efi/genimage.cfg | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/board/qemu/riscv64-virt-efi/genimage.cfg b/board/qemu/riscv64-virt-efi/genimage.cfg
> > index 46950591e0a3d4c3fb14f81d71a6c2ccf245d564..a7d5420d78dc637a0c18fe7ce2ff86378b55741a 100644
> > --- a/board/qemu/riscv64-virt-efi/genimage.cfg
> > +++ b/board/qemu/riscv64-virt-efi/genimage.cfg
> > @@ -28,7 +28,7 @@ image disk.img {
> >               # For partition-type-uuid value, see:
> >               # https://uapi-group.org/specifications/specs/discoverable_partitions_specification/
> >               # SD_GPT_ROOT_RISCV64
>
> I would kill the comment above.
> Now when using the shortcut, it is self explanatory.

Agreed, I will update in v2

Thanks!
Brandon Maier

>
>
> Kind regards,
> Niklas
>
> > -             partition-type-uuid = 72ec70a6-cf74-40e6-bd49-4bda08e8f224
> > +             partition-type-uuid = root-riscv64
> >               image = "rootfs.ext2"
> >       }
> >  }
> >
> > --
> > 2.47.0
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/17] docs/manual/writing-rules: add shortcuts for genimage partition-type-uuid

[Niklas Cassel via buildroot]

On Mon, Nov 11, 2024 at 08:26:39AM -0600, Brandon Maier wrote:
> Hi Niklas
> 
> On Mon, Nov 11, 2024 at 7:11 AM Niklas Cassel <Niklas.Cassel@wdc.com> wrote:
> >
> > Like you wrote in the cover letter, this series is only partially
> > implementing Thomas' suggestion, which was:
> > "My point is that we want *consistency*. So either we use "L" for all
> > rootfs partitions. Or we use root-${ARCH} for all rootfs partitions."
> >
> >
> > While this series is just converting GUIDs to use a shortcut, if there is
> > one available, I still think that we can update the documentation to be
> > even stricter, something like:
> >
> > "For the rootfs partition, the partition type GUID should be set to the
> > architecture-specific shortcut (e.g. root-arm64), rather than the generic
> > +L+ shortcut (generic Linux rootfs). An explicit partition type GUID should
> > always be specified for the rootfs partition."
> 
> I left it out of this series as I haven't looked too closely into
> which of "L" or "root-*" is better. It doesn't seem like a simple
> choice, as U-Boot has a lot of board-specific settings.
> 
> Do you and Thomas feel confident that root-$ARCH should be the preferred type?

For new boards being added to buildroot, definitely.


Both me and Thomas tried to grep in the u-boot source code, and couldn't
find anything other than fastboot stuff that was making use of the
generic Linux rootfs partition type GUID, so it *should* be safe to change
for all buildroot boards making use of u-boot.

I didn't grep in the edk2 source code.


Kind regards,
Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 00/17] board: cleanup genimage partition-type-uuid shortcuts

[Brandon Maier]

Hi Niklas,

On Mon, Nov 11, 2024 at 7:34 AM Niklas Cassel <Niklas.Cassel@wdc.com> wrote:
>
> On Sat, Nov 09, 2024 at 04:16:14PM -0600, Brandon Maier wrote:
> > Buildroot boards using genimage's "partition-type-uuid" can use either a
> > full GUID or one of the shortcuts defined in genimage[1]. The Buildroot
> > manual recommends using the "L", "U", or "F" shortcuts over a full GUID;
> > but does not specify how any other GUID should be defined.
> >
> > This series tries to bring consistency to partition-type-uuid by making
> > shortcuts the preferred method. First we update the Buildroot manual to
> > say shortcuts should be preferred when available. Then we update all
> > boards to use shortcuts.
> >
> > This series is partially implementing Thomas suggestion to have
> > consistency when using "L" vs "root-${ARCH}" vs full GUIDs[2].
> >
> > [1] https://github.com/pengutronix/genimage/blob/master/image-hd.c#L264
> > [2] https://lore.kernel.org/buildroot/20241022224945.4dc67b89@windsurf/
>
> Other than some minor comments, the series looks good to me.
> Good job!
>
>
> You seem to have missed one conversion though:
> board/radxa/rock5b/genimage.cfg:
>
> partition-type-uuid = 3de21764-95bd-54bd-a5c3-4abe786f38a8
>
> can use shortcut:
> partition-type-uuid = u-boot-env
>
>
> But now when I look at it, it was you who added this to genimage just a
> week ago:
> https://github.com/pengutronix/genimage/commit/3e0a2aea8d10431f8c8f652129f73544cfa16af2
>
> So we might need to bump genimage in buildroot before we can make use of
> that shortcut. (And for that we probably want to wait for a new tagged
> release of genimage.)

Yep! I was going to wait until this series was accepted, then update
genimage to support u-boot-env.I left it out of this series to keep it
from getting too complicated.

My eventual goal is to switch the Xilinx boards to using u-boot-env.
Having the env in a separate partition is a useful feature :)

Thanks for reviewing the series!
Brandon Maier

>
>
> Kind regards,
> Niklas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 02/17] board/beagleboard: use partition-type-uuid "L"

[Thomas Petazzoni via buildroot]

On Sat, 09 Nov 2024 16:16:16 -0600
Brandon Maier <brandon.maier@gmail.com> wrote:

> Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> ---
>  board/beagleboard/beaglev_fire/genimage.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/beagleboard/beaglev_fire/genimage.cfg b/board/beagleboard/beaglev_fire/genimage.cfg
> index ef650704c65f24eea37fb1fa8d53b5759062d570..0241480ad6041883a799ed68c6f080d8a3b29cae 100644
> --- a/board/beagleboard/beaglev_fire/genimage.cfg
> +++ b/board/beagleboard/beaglev_fire/genimage.cfg
> @@ -24,7 +24,7 @@ image sdcard.img {
>  	}
>  
>  	partition kernel {
> -		partition-type-uuid = 0FC63DAF-8483-4772-8E79-3D69D8477DE4
> +		partition-type-uuid = L
>  		bootable = "true"
>  		image = "boot.vfat"

Considering it's FAT partition, and not the root filesystem, this
change doesn't really match your documentation update in PATCH 01/17,
where you state:

+** +F+ for a FAT partition (expanded to +ebd0a0a2-b9e5-4433-87c0-68b6b72699c7+
+   by _genimage_)
+
+** +L+ for the root filesystem or other filesystems (expanded to
+   +0fc63daf-8483-4772-8e79-3d69d8477de4+ by _genimage_).

So I would rather be expecting F here, and not L.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/17] docs/manual/writing-rules: add shortcuts for genimage partition-type-uuid

[Thomas Petazzoni via buildroot]

Hello,

On Mon, 11 Nov 2024 14:31:38 +0000
Niklas Cassel via buildroot <buildroot@buildroot.org> wrote:

> > I left it out of this series as I haven't looked too closely into
> > which of "L" or "root-*" is better. It doesn't seem like a simple
> > choice, as U-Boot has a lot of board-specific settings.
> > 
> > Do you and Thomas feel confident that root-$ARCH should be the preferred type?  
> 
> For new boards being added to buildroot, definitely.

I don't have a strong feeling at this point, but it looks like the
Discoverable Partition Specification is getting quite well standardized
(https://uapi-group.org/specifications/specs/discoverable_partitions_specification/)
and adopted. And genimage indeed supports those now, so we should
probably move in this direction.

That being said, having as a first step our defconfigs comply with our
existing policy would already be good.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 05/17] board/pc: use partition-type-uuid "root-x86"

[Thomas Petazzoni via buildroot]

On Sat, 09 Nov 2024 16:16:19 -0600
Brandon Maier <brandon.maier@gmail.com> wrote:

> Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> ---
>  board/pc/genimage-efi.cfg | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/pc/genimage-efi.cfg b/board/pc/genimage-efi.cfg
> index c231e1b9b2626c5a788c85511b1f1e9d12759d33..7d3d69bd067c2c39f5188d82d2e1fd11088657e1 100644
> --- a/board/pc/genimage-efi.cfg
> +++ b/board/pc/genimage-efi.cfg
> @@ -25,7 +25,7 @@ image disk.img {
>  	}
>  
>  	partition root {
> -		partition-type-uuid = 44479540-f297-41b2-9af7-d131d5f0458a
> +		partition-type-uuid = root-x86

I don't understand how this lines up with the policy you have updated
in PATCH 01/17.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 00/17] board: cleanup genimage partition-type-uuid shortcuts

[Thomas Petazzoni via buildroot]

Hello Brandon,

On Sat, 09 Nov 2024 16:16:14 -0600
Brandon Maier <brandon.maier@gmail.com> wrote:

> Buildroot boards using genimage's "partition-type-uuid" can use either a
> full GUID or one of the shortcuts defined in genimage[1]. The Buildroot
> manual recommends using the "L", "U", or "F" shortcuts over a full GUID;
> but does not specify how any other GUID should be defined.
> 
> This series tries to bring consistency to partition-type-uuid by making
> shortcuts the preferred method. First we update the Buildroot manual to
> say shortcuts should be preferred when available. Then we update all
> boards to use shortcuts.
> 
> This series is partially implementing Thomas suggestion to have
> consistency when using "L" vs "root-${ARCH}" vs full GUIDs[2].

Thanks for working on this! However, I'm slightly confused as to what
the goal of this series is in the overall process of making things more
consistent.

With your series enabled, some root filesystems still use L, some use
root-*, which isn't very consistent. Is your series "only" about
replacing full GUID by shortcuts, for the moment?

I'm fine with going this way, but then the PATCH 01/17 should be
accurate about what's recommended nowadays. Because saying in the doc
we want L for the rootfs, but many genimage.cfg use root-* isn't really
great.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 05/17] board/pc: use partition-type-uuid "root-x86"

[Brandon Maier]

Hi Thomas,

On Mon Nov 11, 2024 at 3:02 PM CST, Thomas Petazzoni wrote:
> On Sat, 09 Nov 2024 16:16:19 -0600
> Brandon Maier <brandon.maier@gmail.com> wrote:
>
> > Signed-off-by: Brandon Maier <brandon.maier@gmail.com>
> > ---
> >  board/pc/genimage-efi.cfg | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/board/pc/genimage-efi.cfg b/board/pc/genimage-efi.cfg
> > index c231e1b9b2626c5a788c85511b1f1e9d12759d33..7d3d69bd067c2c39f5188d82d2e1fd11088657e1 100644
> > --- a/board/pc/genimage-efi.cfg
> > +++ b/board/pc/genimage-efi.cfg
> > @@ -25,7 +25,7 @@ image disk.img {
> >  	}
> >  
> >  	partition root {
> > -		partition-type-uuid = 44479540-f297-41b2-9af7-d131d5f0458a
> > +		partition-type-uuid = root-x86
>
> I don't understand how this lines up with the policy you have updated
> in PATCH 01/17.

My intention for this series wasn't for the policy to be "prefer using
L" or "prefer using root-$ARCH". It was to be "prefer using shortcuts
over the full GUID", with the intent of having a second patch series
that would convert L to root-$ARCH.

Niklas also thought my changes to the docs meant "prefer using L", so I
am not communicating clearly, my apologies. I will try to make the
intent clearer in v2.

Thank you,
Brandon

>
> Thomas

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 00/17] board: cleanup genimage partition-type-uuid shortcuts

[Brandon Maier]

On Mon Nov 11, 2024 at 3:12 PM CST, Thomas Petazzoni wrote:
> Hello Brandon,
>
> On Sat, 09 Nov 2024 16:16:14 -0600
> Brandon Maier <brandon.maier@gmail.com> wrote:
>
> > Buildroot boards using genimage's "partition-type-uuid" can use either a
> > full GUID or one of the shortcuts defined in genimage[1]. The Buildroot
> > manual recommends using the "L", "U", or "F" shortcuts over a full GUID;
> > but does not specify how any other GUID should be defined.
> >
> > This series tries to bring consistency to partition-type-uuid by making
> > shortcuts the preferred method. First we update the Buildroot manual to
> > say shortcuts should be preferred when available. Then we update all
> > boards to use shortcuts.
> >
> > This series is partially implementing Thomas suggestion to have
> > consistency when using "L" vs "root-${ARCH}" vs full GUIDs[2].
>
> Thanks for working on this! However, I'm slightly confused as to what
> the goal of this series is in the overall process of making things more
> consistent.
>
> With your series enabled, some root filesystems still use L, some use
> root-*, which isn't very consistent. Is your series "only" about
> replacing full GUID by shortcuts, for the moment?

You are correct, this was my goal. I wanted to go from where we are
today which is a mix of "L", "root-$ARCH", and "full GUID (both L and
root-$ARCH)", to just "L" and "root-$ARCH".

This is an easy first step to implement and review, and makes the future
transition from L -> root-$ARCH easier.

>
> I'm fine with going this way, but then the PATCH 01/17 should be
> accurate about what's recommended nowadays. Because saying in the doc
> we want L for the rootfs, but many genimage.cfg use root-* isn't really
> great.

Agreed, I was trying to avoid saying "prefer L" or "prefer root-$ARCH"
in that commit, as I did not have a strong understanding of which would
be preferable. However based on yours and Niklas feedback I didn't
communicate that clearly.

Based on feedback, it sounds like we would prefer to migrate to
root-$ARCH, so I will reword the docs accordingly. I would still prefer
to defer updating L -> root-$ARCH for a second patch series however, we
will likely need to split that into many patch series per-board, so the
developers for each board have a chance to test them.

Thank you!
Brandon

>
> Thanks!
>
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 01/17] docs/manual/writing-rules: add shortcuts for genimage partition-type-uuid

[Brandon Maier]

On Mon Nov 11, 2024 at 3:00 PM CST, Thomas Petazzoni wrote:
> Hello,
>
> On Mon, 11 Nov 2024 14:31:38 +0000
> Niklas Cassel via buildroot <buildroot@buildroot.org> wrote:
>
> > > I left it out of this series as I haven't looked too closely into
> > > which of "L" or "root-*" is better. It doesn't seem like a simple
> > > choice, as U-Boot has a lot of board-specific settings.
> > >
> > > Do you and Thomas feel confident that root-$ARCH should be the preferred type?
> >
> > For new boards being added to buildroot, definitely.
>
> I don't have a strong feeling at this point, but it looks like the
> Discoverable Partition Specification is getting quite well standardized
> (https://uapi-group.org/specifications/specs/discoverable_partitions_specification/)
> and adopted. And genimage indeed supports those now, so we should
> probably move in this direction.

If there aren't any hard blockers to using L or root-$ARCH. Then I agree
a written specification is a great reason to prefer root-$ARCH, thanks
for digging that up! I will add a link to this specification in the docs
as well.

>
> That being said, having as a first step our defconfigs comply with our
> existing policy would already be good.

Yes I would like to bring them all into alignment. The intent for this
patch series was just to get rid of the "full GUID" to make things
simpler. I intend to have a second patch series to then update
L/root-$ARCH.

Thank you for the feedback!
Brandon

>
> Thomas
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot