Re: [PATCH i-g-t v3 06/11] tests/intel/kms_fbcon_fbt: use a bigger buffer for fbc status

["Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>]

LGTM
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>

On 16-04-2026 14:55, Vinod Govindapillai wrote:
> As the FBC status now include plane specific FBC status as well, we
> need a bigger buffer to capture the complete FBC status. Use the
> already defined buffer length to assess the FBC status
> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
>   tests/intel/kms_fbcon_fbt.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/intel/kms_fbcon_fbt.c b/tests/intel/kms_fbcon_fbt.c
> index e44be15f6..b36582011 100644
> --- a/tests/intel/kms_fbcon_fbt.c
> +++ b/tests/intel/kms_fbcon_fbt.c
> @@ -33,6 +33,7 @@
>    * Mega feature: General Display Features
>    */
>   
> +#include "i915/intel_fbc.h"
>   #include "igt.h"
>   #include "igt_device.h"
>   #include "igt_psr.h"
> @@ -81,7 +82,7 @@ static void wait_user(const char *msg)
>   
>   static bool fbc_supported_on_chipset(int device, int debugfs_fd)
>   {
> -	char buf[128];
> +	char buf[FBC_STATUS_BUF_LEN];
>   	int ret;
>   
>   	ret = igt_debugfs_simple_read(debugfs_fd, "i915_fbc_status",
> @@ -100,7 +101,7 @@ static bool connector_can_fbc(drmModeConnectorPtr connector)
>   
>   static void fbc_print_status(int debugfs_fd)
>   {
> -	static char buf[128];
> +	static char buf[FBC_STATUS_BUF_LEN];
>   
>   	igt_debugfs_simple_read(debugfs_fd, "i915_fbc_status", buf,
>   				sizeof(buf));
> @@ -109,7 +110,7 @@ static void fbc_print_status(int debugfs_fd)
>   
>   static bool fbc_check_status(int debugfs_fd, bool enabled)
>   {
> -	char buf[128];
> +	char buf[FBC_STATUS_BUF_LEN];
>   
>   	igt_debugfs_simple_read(debugfs_fd, "i915_fbc_status", buf,
>   				sizeof(buf));
> @@ -310,7 +311,7 @@ static void fbc_skips_on_fbcon(int debugfs_fd)
>   		"plane height + offset is non-modulo of 4"
>   	};
>   	bool skip = false;
> -	char buf[128];
> +	char buf[FBC_STATUS_BUF_LEN];
>   	int i;
>   
>   	igt_debugfs_simple_read(debugfs_fd, "i915_fbc_status", buf, sizeof(buf));