Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Govindapillai, Vinod" <vinod.govindapillai@intel.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
	"Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
	"Sharma, Swati2" <swati2.sharma@intel.com>
Subject: Re: [PATCH i-g-t v3 03/11] tests/intel/kms_frontbuffer_tracking: update the outdated fbc status reasons
Date: Thu, 30 Apr 2026 07:05:02 +0000	[thread overview]
Message-ID: <8f0315369761db097a299fac068cc02f12256002.camel@intel.com> (raw)
In-Reply-To: <d37a835b-69e5-4eaa-a6d8-fd98b02df74a@intel.com>

On Thu, 2026-04-30 at 09:07 +0530, Reddy Guddati, Santhosh wrote:
> 
> 
> On 16-04-2026 14:55, Vinod Govindapillai wrote:
> > Replace the fbc status check for "mode too large for compression"
> > wchich
> > is no longer being set by the driver with "plane size too big" and
> > "surface size too big" fbc status checks.
> > 
> > Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> > ---
> >   tests/intel/kms_frontbuffer_tracking.c | 18 ++++++++++++++----
> >   1 file changed, 14 insertions(+), 4 deletions(-)
> > 
> > diff --git a/tests/intel/kms_frontbuffer_tracking.c
> > b/tests/intel/kms_frontbuffer_tracking.c
> > index b01959d2c..5bdfbd105 100644
> > --- a/tests/intel/kms_frontbuffer_tracking.c
> > +++ b/tests/intel/kms_frontbuffer_tracking.c
> > @@ -1667,16 +1667,25 @@ static bool fbc_stride_not_supported(void)
> >   
> >   	intel_fbc_get_fbc_status(prim_mode_params.crtc,
> > fbc_status, sizeof(fbc_status));
> >   
> > -	return strstr(fbc_status, "FBC disabled: framebuffer
> > stride not supported\n");
> > +	return strstr(fbc_status, "FBC disabled: stride not
> > supported\n");
> >   }
> >   
> > -static bool fbc_mode_too_large(void)
> > +static bool fbc_plane_size_too_big(void)
> >   {
> >   	char fbc_status[128];
> >   
> >   	intel_fbc_get_fbc_status(prim_mode_params.crtc,
> > fbc_status, sizeof(fbc_status));
> >   
> > -	return strstr(fbc_status, "FBC disabled: mode too large
> > for compression\n");
> > +	return strstr(fbc_status, "FBC disabled: plane size too
> > big\n");
> > +}
> > +
> > +static bool fbc_surface_size_too_big(void)
> 
> Same here, The next commit deletes all this code and replace all this
> with intel_fbc_found_skip_reason(). Imho, we should squash this
> commit.

These are basically separate changes - one patch one logical change. In
that way it would be easier to track/debug - bisect etc. Well.. this is
how I have seen how Ville/Jani have been approaching the changes in the
driver.. so following that approach. 

BR
Vinod 


  reply	other threads:[~2026-04-30  7:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16  9:25 [PATCH i-g-t v3 00/11] updates to fbc tests Vinod Govindapillai
2026-04-16  9:25 ` [PATCH i-g-t v3 01/11] lib/i915/fbc: extract intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-30  2:56   ` Reddy Guddati, Santhosh
2026-04-16  9:25 ` [PATCH i-g-t v3 02/11] tests/intel/kms_frontbuffer_tracking: use intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-30  3:18   ` Reddy Guddati, Santhosh
2026-04-16  9:25 ` [PATCH i-g-t v3 03/11] tests/intel/kms_frontbuffer_tracking: update the outdated fbc status reasons Vinod Govindapillai
2026-04-30  3:37   ` Reddy Guddati, Santhosh
2026-04-30  7:05     ` Govindapillai, Vinod [this message]
2026-04-30  8:30       ` Jani Nikula
2026-04-16  9:25 ` [PATCH i-g-t v3 04/11] tests/intel/kms_frontbuffer_tracking: consolidate fbc tests skip checks Vinod Govindapillai
2026-04-30  4:35   ` Reddy Guddati, Santhosh
2026-04-30  7:12     ` Govindapillai, Vinod
2026-04-16  9:25 ` [PATCH i-g-t v3 05/11] tests/intel/kms_frontbuffer_tracking: use a bigger buffer for fbc status Vinod Govindapillai
2026-04-30  3:45   ` Reddy Guddati, Santhosh
2026-04-16  9:25 ` [PATCH i-g-t v3 06/11] tests/intel/kms_fbcon_fbt: " Vinod Govindapillai
2026-04-30  3:46   ` Reddy Guddati, Santhosh
2026-04-16  9:25 ` [PATCH i-g-t v3 07/11] tests/intel/kms_fbcon_fbt: update the outdated fbc skip reasons Vinod Govindapillai
2026-04-30  3:56   ` Reddy Guddati, Santhosh
2026-04-30  7:11     ` Govindapillai, Vinod
2026-04-16  9:25 ` [PATCH i-g-t v3 08/11] tests/intel/kms_fbcon_fbt: refactor the code to get the right fbc status Vinod Govindapillai
2026-04-16  9:25 ` [PATCH i-g-t v3 09/11] tests/intel/kms_fbcon_fbt: find and store the crtc index Vinod Govindapillai
2026-04-16  9:25 ` [PATCH i-g-t v3 10/11] tests/intel/kms_fbcon_fbt: find the correct fbc status of a pipe Vinod Govindapillai
2026-04-16  9:25 ` [PATCH i-g-t v3 11/11] tests/intel/kms_fbcon_fbt: use common routine to skip tests on fbc status Vinod Govindapillai
2026-04-30  4:06   ` Reddy Guddati, Santhosh
2026-04-16 16:24 ` ✓ i915.CI.BAT: success for updates to fbc tests (rev3) Patchwork
2026-04-16 16:24 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-16 18:08 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-17  4:43 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f0315369761db097a299fac068cc02f12256002.camel@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=santhosh.reddy.guddati@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox