Re: [PATCH i-g-t v3 03/11] tests/intel/kms_frontbuffer_tracking: update the outdated fbc status reasons

["Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>]

On 16-04-2026 14:55, Vinod Govindapillai wrote:
> Replace the fbc status check for "mode too large for compression" wchich
> is no longer being set by the driver with "plane size too big" and
> "surface size too big" fbc status checks.
> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
>   tests/intel/kms_frontbuffer_tracking.c | 18 ++++++++++++++----
>   1 file changed, 14 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index b01959d2c..5bdfbd105 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -1667,16 +1667,25 @@ static bool fbc_stride_not_supported(void)
>   
>   	intel_fbc_get_fbc_status(prim_mode_params.crtc, fbc_status, sizeof(fbc_status));
>   
> -	return strstr(fbc_status, "FBC disabled: framebuffer stride not supported\n");
> +	return strstr(fbc_status, "FBC disabled: stride not supported\n");
>   }
>   
> -static bool fbc_mode_too_large(void)
> +static bool fbc_plane_size_too_big(void)
>   {
>   	char fbc_status[128];
>   
>   	intel_fbc_get_fbc_status(prim_mode_params.crtc, fbc_status, sizeof(fbc_status));
>   
> -	return strstr(fbc_status, "FBC disabled: mode too large for compression\n");
> +	return strstr(fbc_status, "FBC disabled: plane size too big\n");
> +}
> +
> +static bool fbc_surface_size_too_big(void)

Same here, The next commit deletes all this code and replace all this 
with intel_fbc_found_skip_reason(). Imho, we should squash this commit.

> +{
> +	char fbc_status[128];
> +
> +	intel_fbc_get_fbc_status(prim_mode_params.crtc, fbc_status, sizeof(fbc_status));
> +
> +	return strstr(fbc_status, "FBC disabled: surface size too big\n");
>   }
>   
>   static bool fbc_psr_not_possible(void)
> @@ -2362,7 +2371,8 @@ static void do_status_assertions(int flags)
>   	if (flags & ASSERT_FBC_ENABLED) {
>   		igt_require(!fbc_not_enough_stolen());
>   		igt_require(!fbc_stride_not_supported());
> -		igt_require(!fbc_mode_too_large());
> +		igt_require(!fbc_plane_size_too_big());
> +		igt_require(!fbc_surface_size_too_big());
>   		igt_require(!fbc_psr_not_possible());
>   		if (!intel_fbc_wait_until_enabled(prim_mode_params.crtc)) {
>   			igt_assert_f(intel_fbc_is_enabled(prim_mode_params.crtc, IGT_LOG_WARN),