From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, santhosh.reddy.guddati@intel.com,
swati2.sharma@intel.com, jani.nikula@intel.com
Subject: [PATCH i-g-t v3 11/11] tests/intel/kms_fbcon_fbt: use common routine to skip tests on fbc status
Date: Thu, 16 Apr 2026 12:25:59 +0300 [thread overview]
Message-ID: <20260416092559.88735-12-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20260416092559.88735-1-vinod.govindapillai@intel.com>
Use the common intel_fbc_found_skip_reason() defined as part of the fbc
library functions to check and assess the fbc skip reasons. The "no fbc
reasons" are appended based on the reasons defined in the kms_fbcon_fbt
tests.
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
lib/i915/intel_fbc.c | 7 +++++++
tests/intel/kms_fbcon_fbt.c | 26 ++------------------------
2 files changed, 9 insertions(+), 24 deletions(-)
diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
index fde9ef03b..30584925f 100644
--- a/lib/i915/intel_fbc.c
+++ b/lib/i915/intel_fbc.c
@@ -77,10 +77,17 @@ bool intel_fbc_found_skip_reason(int device, int crtc_index)
{
const char *const no_fbc_reasons[] = {
"FBC disabled: not enough stolen memory",
+ "FBC disabled: pixel format not supported",
+ "FBC disabled: tiling not supported",
+ "FBC disabled: rotation not supported",
"FBC disabled: stride not supported",
+ "FBC disabled: per-pixel alpha not supported",
"FBC disabled: plane size too big",
"FBC disabled: surface size too big",
"FBC disabled: PSR1 enabled (Wa_14016291713)"
+ "FBC disabled: plane start Y offset misaligned",
+ "FBC disabled: plane end Y offset misaligned",
+ "FBC disabled: pixel rate too high"
};
bool found_reason = false;
char fbc_status[FBC_STATUS_BUF_LEN];
diff --git a/tests/intel/kms_fbcon_fbt.c b/tests/intel/kms_fbcon_fbt.c
index f738e243f..470027a84 100644
--- a/tests/intel/kms_fbcon_fbt.c
+++ b/tests/intel/kms_fbcon_fbt.c
@@ -297,30 +297,8 @@ static inline void psr_debugfs_enable(struct drm_info *drm)
static void fbc_skips_on_fbcon(struct drm_info *drm)
{
- const char *reasons[] = {
- "pixel format not supported",
- "tiling not supported",
- "rotation not supported",
- "stride not supported",
- "per-pixel alpha not supported",
- "plane size too big",
- "surface size too big",
- "plane start Y offset misaligned",
- "plane end Y offset misaligned",
- "pixel rate too high"
- };
- bool skip = false;
- char buf[FBC_STATUS_BUF_LEN];
- int i;
-
- igt_debugfs_simple_read(drm->debugfs_fd, "i915_fbc_status", buf, sizeof(buf));
- if (strstr(buf, "FBC enabled\n"))
- return;
-
- for (i = 0; skip == false && i < ARRAY_SIZE(reasons); i++)
- skip = strstr(buf, reasons[i]);
-
- igt_skip_on_f(skip, "fbcon modeset is not compatible with FBC\n");
+ igt_skip_on_f(intel_fbc_found_skip_reason(drm->fd, drm->crtc_index),
+ "fbcon modeset is not compatible with FBC\n");
}
static void psr_skips_on_fbcon(struct drm_info *drm)
--
2.43.0
next prev parent reply other threads:[~2026-04-16 9:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 9:25 [PATCH i-g-t v3 00/11] updates to fbc tests Vinod Govindapillai
2026-04-16 9:25 ` [PATCH i-g-t v3 01/11] lib/i915/fbc: extract intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-30 2:56 ` Reddy Guddati, Santhosh
2026-04-16 9:25 ` [PATCH i-g-t v3 02/11] tests/intel/kms_frontbuffer_tracking: use intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-30 3:18 ` Reddy Guddati, Santhosh
2026-04-16 9:25 ` [PATCH i-g-t v3 03/11] tests/intel/kms_frontbuffer_tracking: update the outdated fbc status reasons Vinod Govindapillai
2026-04-30 3:37 ` Reddy Guddati, Santhosh
2026-04-30 7:05 ` Govindapillai, Vinod
2026-04-30 8:30 ` Jani Nikula
2026-04-16 9:25 ` [PATCH i-g-t v3 04/11] tests/intel/kms_frontbuffer_tracking: consolidate fbc tests skip checks Vinod Govindapillai
2026-04-30 4:35 ` Reddy Guddati, Santhosh
2026-04-30 7:12 ` Govindapillai, Vinod
2026-04-16 9:25 ` [PATCH i-g-t v3 05/11] tests/intel/kms_frontbuffer_tracking: use a bigger buffer for fbc status Vinod Govindapillai
2026-04-30 3:45 ` Reddy Guddati, Santhosh
2026-04-16 9:25 ` [PATCH i-g-t v3 06/11] tests/intel/kms_fbcon_fbt: " Vinod Govindapillai
2026-04-30 3:46 ` Reddy Guddati, Santhosh
2026-04-16 9:25 ` [PATCH i-g-t v3 07/11] tests/intel/kms_fbcon_fbt: update the outdated fbc skip reasons Vinod Govindapillai
2026-04-30 3:56 ` Reddy Guddati, Santhosh
2026-04-30 7:11 ` Govindapillai, Vinod
2026-04-16 9:25 ` [PATCH i-g-t v3 08/11] tests/intel/kms_fbcon_fbt: refactor the code to get the right fbc status Vinod Govindapillai
2026-04-16 9:25 ` [PATCH i-g-t v3 09/11] tests/intel/kms_fbcon_fbt: find and store the crtc index Vinod Govindapillai
2026-04-16 9:25 ` [PATCH i-g-t v3 10/11] tests/intel/kms_fbcon_fbt: find the correct fbc status of a pipe Vinod Govindapillai
2026-04-16 9:25 ` Vinod Govindapillai [this message]
2026-04-30 4:06 ` [PATCH i-g-t v3 11/11] tests/intel/kms_fbcon_fbt: use common routine to skip tests on fbc status Reddy Guddati, Santhosh
2026-04-16 16:24 ` ✓ i915.CI.BAT: success for updates to fbc tests (rev3) Patchwork
2026-04-16 16:24 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-16 18:08 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-17 4:43 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416092559.88735-12-vinod.govindapillai@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=santhosh.reddy.guddati@intel.com \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox