Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, santhosh.reddy.guddati@intel.com,
	swati2.sharma@intel.com, jani.nikula@intel.com
Subject: [PATCH i-g-t v3 01/11] lib/i915/fbc: extract intel_fbc_get_fbc_status()
Date: Thu, 16 Apr 2026 12:25:49 +0300	[thread overview]
Message-ID: <20260416092559.88735-2-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20260416092559.88735-1-vinod.govindapillai@intel.com>

Code to read the FBC status from the debugfs is being duplicated
in many places. Extract intel_fbc_get_fbc_status() to be used as
the single source to read the current FBC status.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 lib/i915/intel_fbc.c | 55 ++++++++++++++++++++++++++++++++++++--------
 lib/i915/intel_fbc.h |  3 +++
 2 files changed, 48 insertions(+), 10 deletions(-)

diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
index b8c714d43..47f0e2fc1 100644
--- a/lib/i915/intel_fbc.c
+++ b/lib/i915/intel_fbc.c
@@ -22,6 +22,47 @@ void intel_fbc_disable(igt_display_t *display)
 	igt_set_module_param_int(display->drm_fd, "enable_fbc", 0);
 }
 
+/**
+ * intel_fbc_get_fbc_status_crtc_index
+ * @device: fd of the device
+ * @crtc: crtc index
+ * @fbc_status: Buffer to fill the current fbc status
+ * @buf_size: Size of the buffer to be filled
+ *
+ * Read the debugfs entry for current fbc status of a crtc
+ *
+ * Returns:
+ * None
+ */
+void intel_fbc_get_fbc_status_crtc_index(int device, int crtc_index,
+					 char *fbc_status, int buf_size)
+{
+	int dir;
+
+	dir = igt_debugfs_crtc_dir(device, crtc_index);
+	igt_require_fd(dir);
+	igt_debugfs_simple_read(dir, "i915_fbc_status", fbc_status, buf_size);
+	close(dir);
+}
+
+/**
+ * intel_fbc_get_fbc_status
+ * @crtc: CRTC
+ * @fbc_status: Buffer to fill the current fbc status
+ * @buf_size: Size of the buffer to be filled
+ *
+ * Read the debugfs entry for current fbc status of a crtc
+ *
+ * Returns:
+ * None
+ */
+void intel_fbc_get_fbc_status(igt_crtc_t *crtc, char *fbc_status, int buf_size)
+{
+	intel_fbc_get_fbc_status_crtc_index(crtc->display->drm_fd,
+					    crtc->crtc_index, fbc_status,
+					    buf_size);
+}
+
 /**
  * intel_fbc_supported:
  * @crtc: CRTC
@@ -34,12 +75,9 @@ void intel_fbc_disable(igt_display_t *display)
 bool intel_fbc_supported(igt_crtc_t *crtc)
 {
 	char buf[FBC_STATUS_BUF_LEN];
-	int dir;
 
-	dir = igt_crtc_debugfs_dir(crtc);
-	igt_require_fd(dir);
-	igt_debugfs_simple_read(dir, "i915_fbc_status", buf, sizeof(buf));
-	close(dir);
+	intel_fbc_get_fbc_status(crtc, buf, sizeof(buf));
+
 	if (*buf == '\0')
 		return false;
 
@@ -51,12 +89,9 @@ static bool _intel_fbc_is_enabled(igt_crtc_t *crtc, int log_level, char *last_fb
 {
 	char buf[FBC_STATUS_BUF_LEN];
 	bool print = true;
-	int dir;
 
-	dir = igt_crtc_debugfs_dir(crtc);
-	igt_require_fd(dir);
-	igt_debugfs_simple_read(dir, "i915_fbc_status", buf, sizeof(buf));
-	close(dir);
+	intel_fbc_get_fbc_status(crtc, buf, sizeof(buf));
+
 	if (log_level != IGT_LOG_DEBUG)
 		last_fbc_buf[0] = '\0';
 	else if (strcmp(last_fbc_buf, buf))
diff --git a/lib/i915/intel_fbc.h b/lib/i915/intel_fbc.h
index 8e2662824..f8a506f23 100644
--- a/lib/i915/intel_fbc.h
+++ b/lib/i915/intel_fbc.h
@@ -17,5 +17,8 @@ bool intel_fbc_wait_until_enabled(igt_crtc_t *crtc);
 bool intel_fbc_is_enabled(igt_crtc_t *crtc, int log_level);
 bool intel_fbc_plane_size_supported(igt_display_t *display, uint32_t width, uint32_t height);
 bool intel_fbc_supported_for_psr_mode(igt_display_t *display, enum psr_mode mode);
+void intel_fbc_get_fbc_status_crtc_index(int device, int crtc_index,
+					 char *fbc_status, int buf_size);
+void intel_fbc_get_fbc_status(igt_crtc_t *crtc, char *fbc_status, int buf_size);
 
 #endif
-- 
2.43.0


  reply	other threads:[~2026-04-16  9:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16  9:25 [PATCH i-g-t v3 00/11] updates to fbc tests Vinod Govindapillai
2026-04-16  9:25 ` Vinod Govindapillai [this message]
2026-04-30  2:56   ` [PATCH i-g-t v3 01/11] lib/i915/fbc: extract intel_fbc_get_fbc_status() Reddy Guddati, Santhosh
2026-04-16  9:25 ` [PATCH i-g-t v3 02/11] tests/intel/kms_frontbuffer_tracking: use intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-30  3:18   ` Reddy Guddati, Santhosh
2026-04-16  9:25 ` [PATCH i-g-t v3 03/11] tests/intel/kms_frontbuffer_tracking: update the outdated fbc status reasons Vinod Govindapillai
2026-04-30  3:37   ` Reddy Guddati, Santhosh
2026-04-30  7:05     ` Govindapillai, Vinod
2026-04-30  8:30       ` Jani Nikula
2026-04-16  9:25 ` [PATCH i-g-t v3 04/11] tests/intel/kms_frontbuffer_tracking: consolidate fbc tests skip checks Vinod Govindapillai
2026-04-30  4:35   ` Reddy Guddati, Santhosh
2026-04-30  7:12     ` Govindapillai, Vinod
2026-04-16  9:25 ` [PATCH i-g-t v3 05/11] tests/intel/kms_frontbuffer_tracking: use a bigger buffer for fbc status Vinod Govindapillai
2026-04-30  3:45   ` Reddy Guddati, Santhosh
2026-04-16  9:25 ` [PATCH i-g-t v3 06/11] tests/intel/kms_fbcon_fbt: " Vinod Govindapillai
2026-04-30  3:46   ` Reddy Guddati, Santhosh
2026-04-16  9:25 ` [PATCH i-g-t v3 07/11] tests/intel/kms_fbcon_fbt: update the outdated fbc skip reasons Vinod Govindapillai
2026-04-30  3:56   ` Reddy Guddati, Santhosh
2026-04-30  7:11     ` Govindapillai, Vinod
2026-04-16  9:25 ` [PATCH i-g-t v3 08/11] tests/intel/kms_fbcon_fbt: refactor the code to get the right fbc status Vinod Govindapillai
2026-04-16  9:25 ` [PATCH i-g-t v3 09/11] tests/intel/kms_fbcon_fbt: find and store the crtc index Vinod Govindapillai
2026-04-16  9:25 ` [PATCH i-g-t v3 10/11] tests/intel/kms_fbcon_fbt: find the correct fbc status of a pipe Vinod Govindapillai
2026-04-16  9:25 ` [PATCH i-g-t v3 11/11] tests/intel/kms_fbcon_fbt: use common routine to skip tests on fbc status Vinod Govindapillai
2026-04-30  4:06   ` Reddy Guddati, Santhosh
2026-04-16 16:24 ` ✓ i915.CI.BAT: success for updates to fbc tests (rev3) Patchwork
2026-04-16 16:24 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-16 18:08 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-17  4:43 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260416092559.88735-2-vinod.govindapillai@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=santhosh.reddy.guddati@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox