Re: [PATCH i-g-t v3 04/11] tests/intel/kms_frontbuffer_tracking: consolidate fbc tests skip checks

["Govindapillai, Vinod" <vinod.govindapillai@intel.com>]

On Thu, 2026-04-30 at 10:05 +0530, Reddy Guddati, Santhosh wrote:
> Hi Vinod,
> 
> On 16-04-2026 14:55, Vinod Govindapillai wrote:
> > While looking for "no fbc reasons" and decide whether to skip any
> > specific
> > fbc related test, read the debugfs fbc status only once and look
> > for any
> > skip reasons. Move this as a library function so that other FBC
> > specific
> > tests could use the same library and all the skips reasons can be
> > maintained in a single place.
> > 
> > Suggested-by: Jani Nikula <jani.nikula@intel.com>
> > Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> > ---
> >   lib/i915/intel_fbc.c                   | 37 +++++++++++++++
> >   lib/i915/intel_fbc.h                   |  1 +
> >   tests/intel/kms_frontbuffer_tracking.c | 63 ++++-----------------
> > -----
> >   3 files changed, 47 insertions(+), 54 deletions(-)
> > 
> > diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
> > index 47f0e2fc1..e2fbe3680 100644
> > --- a/lib/i915/intel_fbc.c
> > +++ b/lib/i915/intel_fbc.c
> > @@ -63,6 +63,43 @@ void intel_fbc_get_fbc_status(igt_crtc_t *crtc,
> > char *fbc_status, int buf_size)
> >   					    buf_size);
> >   }
> >   
> > +/**
> > + * intel_fbc_found_skip_reason
> > + * @device: fd of the device
> > + * @crtc_index: crtc index
> > + *
> > + * Read the debugfs entry for current fbc status of a crtc and
> > check for any reasons
> > + * why FBC cannot be enabled. This helps in skipping FBC test
> > cases where FBC cannot
> > + * be enabled. These no fbc reasons are defined by the driver.
> > + *
> > + * Returns:
> > + * True if there is a reason that FBC cannot be enabled otherwise
> > false.
> > + */
> > +bool intel_fbc_found_skip_reason(int device, int crtc_index)
> > +{
> > +	const char *const no_fbc_reasons[] = {
> > +		"FBC disabled: not enough stolen memory",
> > +		"FBC disabled: stride not supported",
> > +		"FBC disabled: plane size too big",
> > +		"FBC disabled: surface size too big",
> > +		"FBC disabled: PSR1 enabled (Wa_14016291713)"
> > +	};
> > +	bool found_reason = false;
> > +	char fbc_status[FBC_STATUS_BUF_LEN];
> > +	int i;
> > +
> > +	intel_fbc_get_fbc_status_crtc_index(device, crtc_index,
> > fbc_status,
> > +					    sizeof(fbc_status));
> > +
> > +	if (strstr(fbc_status, "FBC Enabled\n"))
> 
> This should be "FBC enabled" as debugfs reports it as "enabled".
> 
> 
Thanks for pointing this and other such issues in other patches.
Will fix that. 

BR
Vinod