Re: [PATCH i-g-t v3 05/11] tests/intel/kms_frontbuffer_tracking: use a bigger buffer for fbc status

["Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>]

LGTM
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>

On 16-04-2026 14:55, Vinod Govindapillai wrote:
> As the FBC status now include plane specific FBC status as well, we
> need a bigger buffer to capture the complete FBC status. Define the
> buffer length in a single place and use it across places where the
> test need to assess the FBC status
> 
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
>   lib/i915/intel_fbc.c                   | 2 --
>   lib/i915/intel_fbc.h                   | 2 ++
>   tests/intel/kms_frontbuffer_tracking.c | 6 +++---
>   3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
> index e2fbe3680..fde9ef03b 100644
> --- a/lib/i915/intel_fbc.c
> +++ b/lib/i915/intel_fbc.c
> @@ -10,8 +10,6 @@
>   
>   #include "intel_fbc.h"
>   
> -#define FBC_STATUS_BUF_LEN 128
> -
>   void intel_fbc_enable(igt_display_t *display)
>   {
>   	igt_set_module_param_int(display->drm_fd, "enable_fbc", 1);
> diff --git a/lib/i915/intel_fbc.h b/lib/i915/intel_fbc.h
> index e4b9e5529..f83818aff 100644
> --- a/lib/i915/intel_fbc.h
> +++ b/lib/i915/intel_fbc.h
> @@ -8,6 +8,8 @@
>   
>   #include "igt.h"
>   
> +#define FBC_STATUS_BUF_LEN 512
> +
>   enum psr_mode;
>   
>   void intel_fbc_enable(igt_display_t *display);
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index 4fa185e76..fd3b75b02 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -1570,7 +1570,7 @@ static void drrs_print_status(void)
>   static struct timespec fbc_get_last_action(void)
>   {
>   	struct timespec ret = { 0, 0 };
> -	char fbc_status[128];
> +	char fbc_status[FBC_STATUS_BUF_LEN];
>   	char *action;
>   	ssize_t n_read;
>   
> @@ -1620,7 +1620,7 @@ static void fbc_update_last_action(void)
>   static void fbc_setup_last_action(void)
>   {
>   	ssize_t n_read;
> -	char fbc_status[128];
> +	char fbc_status[FBC_STATUS_BUF_LEN];
>   	char *action;
>   
>   	intel_fbc_get_fbc_status(prim_mode_params.crtc, fbc_status, sizeof(fbc_status));
> @@ -1640,7 +1640,7 @@ static void fbc_setup_last_action(void)
>   
>   static bool fbc_is_compressing(void)
>   {
> -	char fbc_status[128];
> +	char fbc_status[FBC_STATUS_BUF_LEN];
>   
>   	intel_fbc_get_fbc_status(prim_mode_params.crtc, fbc_status, sizeof(fbc_status));
>