Re: [Intel-gfx] [PATCH 19/22] drm/i915/sdvo: Do ELD hardware readout

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 11 Oct 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Read out the ELD from the hw so the state checker can verify it.
>
> Cc: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_sdvo.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
> index d9a54ed4623a..b2884fdc2b1c 100644
> --- a/drivers/gpu/drm/i915/display/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
> @@ -1185,6 +1185,21 @@ static void intel_sdvo_get_avi_infoframe(struct intel_sdvo *intel_sdvo,
>  			      frame->any.type, HDMI_INFOFRAME_TYPE_AVI);
>  }
>  
> +static void intel_sdvo_get_eld(struct intel_sdvo *intel_sdvo,
> +			       struct intel_crtc_state *crtc_state)
> +{
> +	struct drm_i915_private *i915 = to_i915(intel_sdvo->base.base.dev);
> +	ssize_t len;
> +
> +	if (!crtc_state->has_audio)
> +		return;
> +
> +	len = intel_sdvo_read_infoframe(intel_sdvo, SDVO_HBUF_INDEX_ELD,
> +					crtc_state->eld, sizeof(crtc_state->eld));
> +	if (len < 0)
> +		drm_dbg_kms(&i915->drm, "failed to read ELD\n");
> +}
> +
>  static bool intel_sdvo_set_tv_format(struct intel_sdvo *intel_sdvo,
>  				     const struct drm_connector_state *conn_state)
>  {
> @@ -1744,6 +1759,8 @@ static void intel_sdvo_get_config(struct intel_encoder *encoder,
>  	}
>  
>  	intel_sdvo_get_avi_infoframe(intel_sdvo, pipe_config);
> +
> +	intel_sdvo_get_eld(intel_sdvo, pipe_config);
>  }
>  
>  static void intel_sdvo_disable_audio(struct intel_sdvo *intel_sdvo)

-- 
Jani Nikula, Intel Open Source Graphics Center