Re: [PATCH v2 20/30] drm/xe/huc: Use scope-based forcewake

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Matt Roper (2025-11-10 20:20:38-03:00)
>Use scope-based forcewake in the HuC code for a small simplification and
>consistency with other parts of the driver.
>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

>---
> drivers/gpu/drm/xe/xe_huc.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_huc.c b/drivers/gpu/drm/xe/xe_huc.c
>index 0a70c8924582..4212162913af 100644
>--- a/drivers/gpu/drm/xe/xe_huc.c
>+++ b/drivers/gpu/drm/xe/xe_huc.c
>@@ -300,19 +300,16 @@ void xe_huc_sanitize(struct xe_huc *huc)
> void xe_huc_print_info(struct xe_huc *huc, struct drm_printer *p)
> {
>         struct xe_gt *gt = huc_to_gt(huc);
>-        unsigned int fw_ref;
> 
>         xe_uc_fw_print(&huc->fw, p);
> 
>         if (!xe_uc_fw_is_enabled(&huc->fw))
>                 return;
> 
>-        fw_ref = xe_force_wake_get(gt_to_fw(gt), XE_FW_GT);
>-        if (!fw_ref)
>+        CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FW_GT);
>+        if (!fw_ref.domains)
>                 return;
> 
>         drm_printf(p, "\nHuC status: 0x%08x\n",
>                    xe_mmio_read32(&gt->mmio, HUC_KERNEL_LOAD_INFO));
>-
>-        xe_force_wake_put(gt_to_fw(gt), fw_ref);
> }
>-- 
>2.51.1
>