Re: [PATCH v2 26/30] drm/xe/hwmon: Use scope-based runtime PM

[Gustavo Sousa <gustavo.sousa@intel.com>]

Quoting Matt Roper (2025-11-10 20:20:44-03:00)
>Use scope-based runtime power management in the hwmon code for
>consistency with other parts of the driver.
>
>Signed-off-by: Matt Roper <matthew.d.roper@intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa@intel.com>

>---
> drivers/gpu/drm/xe/xe_hwmon.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
>index 97879daeefc1..5ad351fad6e2 100644
>--- a/drivers/gpu/drm/xe/xe_hwmon.c
>+++ b/drivers/gpu/drm/xe/xe_hwmon.c
>@@ -502,7 +502,7 @@ xe_hwmon_power_max_interval_show(struct device *dev, struct device_attribute *at
> 
>         int ret = 0;
> 
>-        xe_pm_runtime_get(hwmon->xe);
>+        guard(xe_pm_runtime)(hwmon->xe);
> 
>         mutex_lock(&hwmon->hwmon_lock);
> 
>@@ -521,8 +521,6 @@ xe_hwmon_power_max_interval_show(struct device *dev, struct device_attribute *at
> 
>         mutex_unlock(&hwmon->hwmon_lock);
> 
>-        xe_pm_runtime_put(hwmon->xe);
>-
>         x = REG_FIELD_GET(PWR_LIM_TIME_X, reg_val);
>         y = REG_FIELD_GET(PWR_LIM_TIME_Y, reg_val);
> 
>@@ -604,7 +602,7 @@ xe_hwmon_power_max_interval_store(struct device *dev, struct device_attribute *a
>         rxy = REG_FIELD_PREP(PWR_LIM_TIME_X, x) |
>                                REG_FIELD_PREP(PWR_LIM_TIME_Y, y);
> 
>-        xe_pm_runtime_get(hwmon->xe);
>+        guard(xe_pm_runtime)(hwmon->xe);
> 
>         mutex_lock(&hwmon->hwmon_lock);
> 
>@@ -616,8 +614,6 @@ xe_hwmon_power_max_interval_store(struct device *dev, struct device_attribute *a
> 
>         mutex_unlock(&hwmon->hwmon_lock);
> 
>-        xe_pm_runtime_put(hwmon->xe);
>-
>         return count;
> }
> 
>@@ -1126,7 +1122,7 @@ xe_hwmon_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
>         struct xe_hwmon *hwmon = dev_get_drvdata(dev);
>         int ret;
> 
>-        xe_pm_runtime_get(hwmon->xe);
>+        guard(xe_pm_runtime)(hwmon->xe);
> 
>         switch (type) {
>         case hwmon_temp:
>@@ -1152,8 +1148,6 @@ xe_hwmon_read(struct device *dev, enum hwmon_sensor_types type, u32 attr,
>                 break;
>         }
> 
>-        xe_pm_runtime_put(hwmon->xe);
>-
>         return ret;
> }
> 
>@@ -1164,7 +1158,7 @@ xe_hwmon_write(struct device *dev, enum hwmon_sensor_types type, u32 attr,
>         struct xe_hwmon *hwmon = dev_get_drvdata(dev);
>         int ret;
> 
>-        xe_pm_runtime_get(hwmon->xe);
>+        guard(xe_pm_runtime)(hwmon->xe);
> 
>         switch (type) {
>         case hwmon_power:
>@@ -1178,8 +1172,6 @@ xe_hwmon_write(struct device *dev, enum hwmon_sensor_types type, u32 attr,
>                 break;
>         }
> 
>-        xe_pm_runtime_put(hwmon->xe);
>-
>         return ret;
> }
> 
>-- 
>2.51.1
>