Re: [PATCH 16/23] drm/xe/nvls: Attach MOCS table for NVL-S

[Shekhar Chauhan <shekhar.chauhan@intel.com>]

On 10/14/2025 8:54, Lucas De Marchi wrote:
> From: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>
> The MOCS table for NVL-S is the same of Xe2.

Nitpick: Maybe rephrase it to "The MOCS table for NVL-S is the same as 
that of Xe2". Also, can we have the Bspec listed for this, to assist the 
reviewer.

Aside from this, LGTM,

Reviewed-by: Shekhar Chauhan <shekhar.chauhan@intel.com>

>
> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_mocs.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/xe/xe_mocs.c b/drivers/gpu/drm/xe/xe_mocs.c
> index 7b68c22ff7bbc..e8ec4114302e5 100644
> --- a/drivers/gpu/drm/xe/xe_mocs.c
> +++ b/drivers/gpu/drm/xe/xe_mocs.c
> @@ -576,6 +576,7 @@ static unsigned int get_mocs_settings(struct xe_device *xe,
>   	memset(info, 0, sizeof(struct xe_mocs_info));
>   
>   	switch (xe->info.platform) {
> +	case XE_NOVALAKE_S:
>   	case XE_PANTHERLAKE:
>   	case XE_LUNARLAKE:
>   	case XE_BATTLEMAGE:
>