Re: [PATCH v3 RESEND 5/5] arm64: dts: qcom: Add device tree for SA8797P Ride board

[Shawn Guo <shengchao.guo@oss.qualcomm.com>]

On Tue, Jun 16, 2026 at 01:02:06PM +0200, Konrad Dybcio wrote:
> On 5/26/26 7:13 AM, Shawn Guo wrote:
> > From: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
> > 
> > Add initial device tree for the Qualcomm SA8797P Ride reference board.
> > 
> >  - Configure UART15 as the primary console and UART4 as the secondary
> >    serial port
> >  - Enable UFS storage support
> >  - Define thermal zones for PMIC dies, UFS, and two SDRAM sensors,
> >    all sourced from SCMI sensor protocol on channel 23
> > 
> > Signed-off-by: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>
> > Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> > ---
> 
> [...]
> 
> > +&thermal_zones {
> > +	pm_kobra_thermal: pm-a-die-thermal {
> > +		polling-delay-passive = <100>;
> > +		polling-delay = <0>;
> 
> 0 is the default value, you can drop these lines

Will do.

> 
> [...]
> 
> > +	pm_kai_0_thermal: pm-e-die-thermal {
> 
> s/pm/pmic

Good suggestion!

> 
> > +		polling-delay-passive = <100>;
> > +		polling-delay = <0>;
> > +		thermal-sensors = <&scmi23_sensor 4>;
> > +
> > +		trips {
> > +			trip0 {
> > +				temperature = <115000>;
> > +				hysteresis = <5000>;
> > +				type = "passive";
> > +			};
> > +
> > +			trip1 {
> > +				temperature = <135000>;
> > +				hysteresis = <5000>;
> > +				type = "passive";
> > +			};
> 
> Do we need two passive trip points?

The trips are indeed problematic. After consulting internally, we will
make the following changes.

- Drop 135 C trip point from PMIC thermal zones as hardware will shutdown
  at 125 C
- Have trip0 at 105 C as passive and trip1 at 115 C as critical for UFS
  and SDRAM thermal zones

Shawn