Linux IIO development
 help / color / mirror / Atom feed
From: Francesco Lavra <flavra@baylibre.com>
To: "Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 6/9] iio: imu: st_lsm6dsx: remove event_threshold field from hw struct
Date: Thu, 30 Oct 2025 08:27:49 +0100	[thread overview]
Message-ID: <20251030072752.349633-7-flavra@baylibre.com> (raw)
In-Reply-To: <20251030072752.349633-1-flavra@baylibre.com>

This field is used to store the wakeup event detection threshold
value. When adding support for more event types, some of which may
have different threshold values for different axes, storing all
threshold values for all event sources would be cumbersome. Thus,
remove this field altogether, and read the currently configured
value from the sensor when requested by userspace.

Signed-off-by: Francesco Lavra <flavra@baylibre.com>
---
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h      |  2 --
 drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 12 +++++++++---
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
index ec4efb29c4cc..98aa3cfb711b 100644
--- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx.h
@@ -398,7 +398,6 @@ struct st_lsm6dsx_sensor {
  * @sip: Total number of samples (acc/gyro/ts) in a given pattern.
  * @buff: Device read buffer.
  * @irq_routing: pointer to interrupt routing configuration.
- * @event_threshold: wakeup event threshold.
  * @enable_event: enabled event bitmask.
  * @iio_devs: Pointers to acc/gyro iio_dev instances.
  * @settings: Pointer to the specific sensor settings in use.
@@ -422,7 +421,6 @@ struct st_lsm6dsx_hw {
 	u8 sip;
 
 	u8 irq_routing;
-	u8 event_threshold;
 	u8 enable_event;
 
 	u8 *buff;
diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
index 157bc2615dc6..ea145e15cd36 100644
--- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
@@ -1825,12 +1825,20 @@ static int st_lsm6dsx_read_event(struct iio_dev *iio_dev,
 {
 	struct st_lsm6dsx_sensor *sensor = iio_priv(iio_dev);
 	struct st_lsm6dsx_hw *hw = sensor->hw;
+	const struct st_lsm6dsx_reg *reg;
+	u8 data;
+	int err;
 
 	if (type != IIO_EV_TYPE_THRESH)
 		return -EINVAL;
 
+	reg = &hw->settings->event_settings.sources[ST_LSM6DSX_EVENT_WAKEUP].value;
+	err = st_lsm6dsx_read_locked(hw, reg->addr, &data, sizeof(data));
+	if (err < 0)
+		return err;
+
 	*val2 = 0;
-	*val = hw->event_threshold;
+	*val = (data & reg->mask) >> __ffs(reg->mask);
 
 	return IIO_VAL_INT;
 }
@@ -1862,8 +1870,6 @@ st_lsm6dsx_write_event(struct iio_dev *iio_dev,
 	if (err < 0)
 		return -EINVAL;
 
-	hw->event_threshold = val;
-
 	return 0;
 }
 
-- 
2.39.5


  parent reply	other threads:[~2025-10-30  7:28 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-30  7:27 [PATCH 0/9] st_lsm6dsx: add tap event detection Francesco Lavra
2025-10-30  7:27 ` [PATCH 1/9] iio: imu: st_lsm6dsx: dynamically initialize iio_chan_spec data Francesco Lavra
2025-10-30  7:57   ` Andy Shevchenko
2025-10-30 11:03     ` Francesco Lavra
2025-10-30 16:42   ` Lorenzo Bianconi
2025-10-31  8:04     ` Francesco Lavra
2025-10-31  8:09       ` Andy Shevchenko
2025-10-31  8:26     ` Francesco Lavra
2025-10-31  8:32       ` Andy Shevchenko
2025-10-31 11:43         ` Francesco Lavra
2025-11-02 11:16   ` Jonathan Cameron
2025-11-03  9:24     ` Francesco Lavra
2025-11-09 13:32       ` Jonathan Cameron
2025-10-30  7:27 ` [PATCH 2/9] iio: imu: st_lsm6dsx: make event_settings more generic Francesco Lavra
2025-10-30 16:44   ` Lorenzo Bianconi
2025-10-31  8:08     ` Francesco Lavra
2025-10-30  7:27 ` [PATCH 3/9] iio: imu: st_lsm6dsx: move wakeup event enable mask to event_src Francesco Lavra
2025-10-30  7:59   ` Andy Shevchenko
2025-10-30  7:27 ` [PATCH 4/9] iio: imu: st_lsm6dsx: dynamically allocate iio_event_spec structs Francesco Lavra
2025-11-02 11:22   ` Jonathan Cameron
2025-10-30  7:27 ` [PATCH 5/9] iio: imu: st_lsm6dsx: rework code to check for enabled events Francesco Lavra
2025-10-30  7:27 ` Francesco Lavra [this message]
2025-10-30  8:01   ` [PATCH 6/9] iio: imu: st_lsm6dsx: remove event_threshold field from hw struct Andy Shevchenko
2025-10-30 11:10     ` Francesco Lavra
2025-10-30 13:49       ` Andy Shevchenko
2025-11-02 11:29         ` Jonathan Cameron
2025-11-02 13:45           ` Andy Shevchenko
2025-11-03  9:34             ` Francesco Lavra
2025-11-03  9:40               ` Andy Shevchenko
2025-11-03 14:53               ` David Lechner
2025-11-09 13:31                 ` Jonathan Cameron
2025-10-30  7:27 ` [PATCH 7/9] iio: imu: st_lsm6dsx: make event management functions generic Francesco Lavra
2025-10-30  8:15   ` Andy Shevchenko
2025-10-30 11:17     ` Francesco Lavra
2025-10-30 13:36       ` Andy Shevchenko
2025-11-02 11:33   ` Jonathan Cameron
2025-10-30  7:27 ` [PATCH 8/9] iio: imu: st_lsm6dsx: add event configurability on a per axis basis Francesco Lavra
2025-10-30  8:24   ` Andy Shevchenko
2025-10-30 11:23     ` Francesco Lavra
2025-10-30 13:56       ` Andy Shevchenko
2025-11-17 19:23         ` Francesco Lavra
2025-11-18 10:44           ` Andy Shevchenko
2025-11-18 11:01             ` Francesco Lavra
2025-11-20  9:05               ` Andy Shevchenko
2025-11-20 11:43                 ` Francesco Lavra
2025-11-20 13:59                   ` Andy Shevchenko
2025-11-20 18:31                     ` Andy Shevchenko
2025-11-21  9:14                       ` Francesco Lavra
2025-11-21  9:31                         ` Andy Shevchenko
2025-11-21 14:57                           ` Francesco Lavra
2025-12-07 15:11                             ` Jonathan Cameron
2025-10-30  7:27 ` [PATCH 9/9] iio: imu: st_lsm6dsx: add tap event detection Francesco Lavra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251030072752.349633-7-flavra@baylibre.com \
    --to=flavra@baylibre.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox