From: Ruediger Meier <sweet_f_a@gmx.de>
To: Karel Zak <kzak@redhat.com>
Cc: "Thomas Bächler" <thomas@archlinux.org>, util-linux@vger.kernel.org
Subject: Re: [PATCH] fstrim: add systemd units
Date: Tue, 8 Apr 2014 12:25:21 +0200 [thread overview]
Message-ID: <201404081225.21563.sweet_f_a@gmx.de> (raw)
In-Reply-To: <20140407104304.GJ22126@x2.net.home>
On Monday 07 April 2014, Karel Zak wrote:
> On Thu, Apr 03, 2014 at 11:41:51PM +0200, Thomas Bächler wrote:
> > sys-utils/.gitignore | 1 +
> > sys-utils/Makemodule.am | 6 ++++++
> > sys-utils/fstrim.service.in | 6 ++++++
> > sys-utils/fstrim.timer | 10 ++++++++++
> > 4 files changed, 23 insertions(+)
> > create mode 100644 sys-utils/fstrim.service.in
> > create mode 100644 sys-utils/fstrim.timer
>
> Applied, thanks.
Hm, isn't this a bit over the top? Adding a script just to
call "fstrim -a" automatically?
Should we also add scripts for "mount -a" or "fsck -a" or "swapon -a"?
And wouldn't we also need to add "example crontab" lines for non-systemd
systems! Sounds a bit ridiculous, right?
I think it's the distro's or admin's job to write and add the scripts
for filesystems maintenance etc.
BTW fstrim.timer is missing in "make dist" tar ball.
cu,
Rudi
next prev parent reply other threads:[~2014-04-08 10:25 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 21:41 [PATCH] fstrim: add systemd units Thomas Bächler
2014-04-07 10:43 ` Karel Zak
2014-04-08 10:25 ` Ruediger Meier [this message]
2014-04-08 10:57 ` Thomas Bächler
2014-04-08 12:07 ` Ruediger Meier
2014-04-08 15:42 ` Dave Reisner
2014-04-08 17:12 ` Ruediger Meier
2014-04-09 7:52 ` Karel Zak
2014-04-09 10:07 ` Ruediger Meier
2014-04-09 11:02 ` Karel Zak
2014-04-09 12:12 ` Ruediger Meier
2014-04-09 12:49 ` Thomas Bächler
2014-04-09 15:16 ` Ruediger Meier
2014-04-09 15:24 ` Thomas Bächler
2014-04-09 15:44 ` Ruediger Meier
2014-04-09 14:02 ` Markus Trippelsdorf
2014-04-09 15:48 ` Ruediger Meier
2014-04-09 15:55 ` Markus Trippelsdorf
2014-04-09 18:39 ` Theodore Ts'o
2014-04-10 8:05 ` Karel Zak
2014-04-10 9:17 ` Ruediger Meier
2014-04-10 12:49 ` Karel Zak
2014-04-10 13:16 ` Ruediger Meier
2014-04-10 13:22 ` Ruediger Meier
2014-04-08 17:26 ` Karel Zak
2014-04-08 17:30 ` Thomas Bächler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201404081225.21563.sweet_f_a@gmx.de \
--to=sweet_f_a@gmx.de \
--cc=kzak@redhat.com \
--cc=thomas@archlinux.org \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox