Re: [PATCH] fstrim: add systemd units

["Thomas Bächler" <thomas@archlinux.org>]

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

Am 08.04.2014 12:25, schrieb Ruediger Meier:
> Hm, isn't this a bit over the top? Adding a script just to 
> call "fstrim -a" automatically?

It's a common task. I was getting tired of having to add this on every
single machine that I set up.

> Should we also add scripts for "mount -a" or "fsck -a" or "swapon -a"?

And what purpose would that serve? Did you just take random commands and
add '-a' to prove a point?

> And wouldn't we also need to add "example crontab" lines for non-systemd 
> systems! Sounds a bit ridiculous, right?

You can add them if you feel like it. But this is not an "example" file,
it is ready to be used.

> I think it's the distro's or admin's job to write and add the scripts 
> for filesystems maintenance etc.

That's ridiculous. We finally, for the first time ever, have a unified
way of creating service definitions that can be used unchanged in all
relevant distributions (except Gentoo and Slackware, of course). The
main advantage of this unification is that they can be shipped and
maintained by upstream projects - after all, the upstream projects know
what services make sense and how to start them properly.

> BTW fstrim.timer is missing in "make dist" tar ball.

Sorry, you are right. I'm a bit lost in this build system, Karel
probably knows how to fix this.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]