Re: [PATCH] fstrim: add systemd units

["Thomas Bächler" <thomas@archlinux.org>]

[-- Attachment #1: Type: text/plain, Size: 1978 bytes --]

Am 09.04.2014 17:16, schrieb Ruediger Meier:
> On Wednesday 09 April 2014, Thomas Bächler wrote:
>> Am 09.04.2014 14:12, schrieb Ruediger Meier:
>>>> well, "fstrim -a" contains heruistic to select the right filestems
>>>> (it really does not call trim for all devices), it has been
>>>> implemented to *avoid* sysadmins creativity. If you don't like it,
>>>> you can use "fstrim <device>" (for example from crontab).
>>>
>>> I'd like the documentation more detailed.
>>> Does it really run on all mounts or only /etc/fstab?
>>> Does it write on automounted devices which are probably not owned
>>> by the admin? Does it affect read-only mounts?
>>
>> The documentation is precise here:
>>
>> 'Trim all mounted filesystems on devices that support the discard
>> operation.'
> 
> If this is 100% true then Karel's statement 10 lines above would be 
> wrong.

There is no contradiction between this and what Karel said. I think you
are confused and should read both statements again.

> Also this doc line indicates that even read-only mounts could be trimmed 
> (if FS supports it) which would be at least dangerous if it runs 
> automatically while admin is trying to repair a broken filesystem.

The documentation says nothing about excluding read-only file systems,
that should probably be changed (but it is not something that I,
personally, am terribly concerned about).

>> It is not complicated, it is just a task that shouldn't be repeated
>> countless times.
> 
> Now you still need to enable it "countless times" which I would do using 
> rsync or git anyway like I would sync self created timers, crontabs or 
> whatever config files with same effort.

This is getting annoying. It is your opinion that we should not add
useful things because we haven't done so in the past, or because someone
might want to do it slightly differently.

I submitted it, Karel added it, period. There's no point continuing this
argument.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]