All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] PV driver compatibility
@ 2010-01-20 16:02 Ky Srinivasan
  2010-01-20 16:07 ` Keir Fraser
  0 siblings, 1 reply; 14+ messages in thread
From: Ky Srinivasan @ 2010-01-20 16:02 UTC (permalink / raw)
  To: xen-devel

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

The attached patch fixes what I believe is a typo and permits guests running the latest PV drivers to correctly interact with older back-ends.

Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com>


[-- Attachment #2: magic_ioport_compat.patch --]
[-- Type: text/plain, Size: 809 bytes --]

Make our PV drivers work  with older hosts that do not recognize the new PV driver protocol. 

Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com>

Index: xen-4.0.0-testing/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c
===================================================================
--- xen-4.0.0-testing.orig/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c	2009-12-22 06:23:01.000000000 -0700
+++ xen-4.0.0-testing/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c	2010-01-06 12:50:53.000000000 -0700
@@ -284,7 +284,10 @@
 
 	if (magic != XEN_IOPORT_MAGIC_VAL) {
 		dev_err(dev, "invalid magic %#x", magic);
-		return -ENODEV;
+		/* 
+		 * Older backend; just return 0 to be compatible.
+		 */
+		return 0;
 	}
 
 	protocol = inb(XEN_IOPORT_PROTOVER);

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-20 16:02 [PATCH] PV driver compatibility Ky Srinivasan
@ 2010-01-20 16:07 ` Keir Fraser
  2010-01-21 20:38   ` Ian Campbell
  0 siblings, 1 reply; 14+ messages in thread
From: Keir Fraser @ 2010-01-20 16:07 UTC (permalink / raw)
  To: Ky Srinivasan, xen-devel@lists.xensource.com; +Cc: Ian Campbell

On 20/01/2010 16:02, "Ky Srinivasan" <ksrinivasan@novell.com> wrote:

> The attached patch fixes what I believe is a typo and permits guests running
> the latest PV drivers to correctly interact with older back-ends.
> 
> Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com>

Ian,

You introduced the magic port value check, in xen-unstable:19964. Can you
ack/nack this please?

 -- Keir

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-20 16:07 ` Keir Fraser
@ 2010-01-21 20:38   ` Ian Campbell
  2010-01-21 21:46     ` Keir Fraser
  0 siblings, 1 reply; 14+ messages in thread
From: Ian Campbell @ 2010-01-21 20:38 UTC (permalink / raw)
  To: Keir Fraser; +Cc: ksrinivasan, xen-devel@lists.xensource.com

On Wed, 2010-01-20 at 16:07 +0000, Keir Fraser wrote: 
> On 20/01/2010 16:02, "Ky Srinivasan" <ksrinivasan@novell.com> wrote:
> 
> > The attached patch fixes what I believe is a typo and permits guests running
> > the latest PV drivers to correctly interact with older back-ends.
> > 
> > Signed-off-by: K. Y. Srinivasan <ksrinivasan@novell.com>
> 
> Ian,
> 
> You introduced the magic port value check, in xen-unstable:19964.

I'm guilty of pretty poor changelogging there, aren't I, I've no idea
how the unmodified drivers part of the change relates to the comment :-(

> Can you ack/nack this please?

What vintage of older back-ends are we talking about?

What is their behaviour when reading from that port? Can we test for a
specific value instead of anything != MAGIC or is there some other way
to identify them? 

Without some sort of unplugging mechanism we run the risk of having both
PV and Emulated disk controllers active, accessing the same virtual disk
and with drivers loaded in the guest, which is potentially very
dangerous for the user's data. Did those older backends implement some
alternative unplugging mechanism we should be trying?

The whole point of this magic check is to ensure we are running on a
backend which is new enough to do the unplugging in a safe way, so I
think failing to switch to PV and sticking with emulated on such
platforms the safe approach.

I'd suggest that this issue should be fixed by backporting the backend
support for the safe unplug protocol -- I don't think the patch for such
minimal support is that big or risky. Failing that perhaps it could at
least be something you need to explicitly ask for if you have somehow
verified that there is no danger of the emulated and PV backends
trampling each other, e.g. via a frontend module parameter.

Ian.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-21 20:38   ` Ian Campbell
@ 2010-01-21 21:46     ` Keir Fraser
  2010-01-22  7:31       ` Ian Campbell
  0 siblings, 1 reply; 14+ messages in thread
From: Keir Fraser @ 2010-01-21 21:46 UTC (permalink / raw)
  To: Ian Campbell; +Cc: ksrinivasan, xen-devel@lists.xensource.com

On 21/01/2010 20:38, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote:

>> You introduced the magic port value check, in xen-unstable:19964.
> 
> I'm guilty of pretty poor changelogging there, aren't I, I've no idea
> how the unmodified drivers part of the change relates to the comment :-(

Yes, I wonder if it was even meant to be checked in. Or if it's an
accidental merge of two patches both of which you intended to go in.

I'm not sure unconditional unplug, as implemented, is a good idea. I can
imagine people with setups in which emulated devices coexist with pv
devices. Such a setup breaks if emulated devices all get unplugged when pv
drivers load. Presumably in the environment this patch came from (Citrix
XenServer) such a situation is disallowed, but I'm not so sure about
proscribing it more generally.

Some people do want unplug though, so I think making it a non-default module
option is a good idea.

 -- Keir

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
       [not found] <4B586E2D020000300007DDE1@sinclair.provo.novell.com>
@ 2010-01-21 23:04 ` Ky Srinivasan
  2010-01-22  7:37   ` Ian Campbell
  0 siblings, 1 reply; 14+ messages in thread
From: Ky Srinivasan @ 2010-01-21 23:04 UTC (permalink / raw)
  To: Ian.Campbell, Keir.Fraser; +Cc: xen-devel



>>> On 1/21/2010 at  3:38 PM, in message
<  1264106300.21707.57.camel@localhost.localdomain  >, Ian Campbell
<  Ian.Campbell@citrix.com  > wrote: 
> On Wed, 2010-01-20 at 16:07 +0000, Keir Fraser wrote: 
>> On 20/01/2010 16:02, "Ky Srinivasan" <  ksrinivasan@novell.com  > wrote:
>> 
>> > The attached patch fixes what I believe is a typo and permits guests 
> running
>> > the latest PV drivers to correctly interact with older back-ends.
>> > 
>> > Signed-off-by: K. Y. Srinivasan <  ksrinivasan@novell.com  >
>> 
>> Ian,
>> 
>> You introduced the magic port value check, in xen-unstable:19964.
> 
> I'm guilty of pretty poor changelogging there, aren't I, I've no idea
> how the unmodified drivers part of the change relates to the comment :-(
> 
>> Can you ack/nack this please?
> 
> What vintage of older back-ends are we talking about?
We shipped sles11 on xen-3.3.1 and this is where we encountered the problem - hosting a sles11 sp1 (based on xen-4.0.0)  guest on a sles11  host. 
> 
> What is their behaviour when reading from that port? Can we test for a
> specific value instead of anything != MAGIC or is there some other way
> to identify them? 

Looking at your documentation for this new protocol, I recall seeing that if the magic value was not read, it was ok to silently return to be compatible.
> 
> Without some sort of unplugging mechanism we run the risk of having both
> PV and Emulated disk controllers active, accessing the same virtual disk
> and with drivers loaded in the guest, which is potentially very
> dangerous for the user's data. Did those older backends implement some
> alternative unplugging mechanism we should be trying?
We have had a mechanism for disabling the emulation when the PV drivers are loaded for some time now.
> 
> The whole point of this magic check is to ensure we are running on a
> backend which is new enough to do the unplugging in a safe way, so I
> think failing to switch to PV and sticking with emulated on such
> platforms the safe approach.

This breaks the compatibility with systems that have already been shipped in the sense we cannot run the guests with PV drivers. The proposed patch fixes the problem.

Regards,

K. Y
> 
> I'd suggest that this issue should be fixed by backporting the backend
> support for the safe unplug protocol -- I don't think the patch for such
> minimal support is that big or risky. Failing that perhaps it could at
> least be something you need to explicitly ask for if you have somehow
> verified that there is no danger of the emulated and PV backends
> trampling each other, e.g. via a frontend module parameter.
> 
> Ian.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-21 21:46     ` Keir Fraser
@ 2010-01-22  7:31       ` Ian Campbell
  2010-01-22  8:03         ` Keir Fraser
  0 siblings, 1 reply; 14+ messages in thread
From: Ian Campbell @ 2010-01-22  7:31 UTC (permalink / raw)
  To: Keir Fraser; +Cc: ksrinivasan, xen-devel@lists.xensource.com

On Thu, 2010-01-21 at 21:46 +0000, Keir Fraser wrote: 
> On 21/01/2010 20:38, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote:
> 
> >> You introduced the magic port value check, in xen-unstable:19964.
> > 
> > I'm guilty of pretty poor changelogging there, aren't I, I've no idea
> > how the unmodified drivers part of the change relates to the comment :-(
> 
> Yes, I wonder if it was even meant to be checked in. Or if it's an
> accidental merge of two patches both of which you intended to go in.

Yes, that's possible. I notice that I defined XEN_IOPORT_LINUX_PRODNUM
and XEN_IOPORT_LINUX_DRVVER but then hardcode 0xdead and 0xbeef where
they should be used, which suggests I wasn't quite ready to send the
patch...

> 
> I'm not sure unconditional unplug, as implemented, is a good idea. I can
> imagine people with setups in which emulated devices coexist with pv
> devices. Such a setup breaks if emulated devices all get unplugged when pv
> drivers load. Presumably in the environment this patch came from (Citrix
> XenServer) such a situation is disallowed, but I'm not so sure about
> proscribing it more generally.

The protocol allows for coarse grained selection of which devices to
unplug:
6) The drivers write a two-byte bitmask of devices to unplug to IO
   port 0x10.  The defined fields are:

   1 -- All IDE disks (not including CD drives)
   2 -- All emulated NICs
   4 -- All IDE disks except for the primary master (not including CD
        drives)

There is scope for extending this to a more explicit bitmask allowing
individual devices to be selected, if people are interested in that.

> Some people do want unplug though, so I think making it a non-default module
> option is a good idea.
> 
>  -- Keir
> 
> 

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-21 23:04 ` Ky Srinivasan
@ 2010-01-22  7:37   ` Ian Campbell
  0 siblings, 0 replies; 14+ messages in thread
From: Ian Campbell @ 2010-01-22  7:37 UTC (permalink / raw)
  To: Ky Srinivasan; +Cc: xen-devel@lists.xensource.com, Keir Fraser

On Thu, 2010-01-21 at 23:04 +0000, Ky Srinivasan wrote: 
> 
> >>> On 1/21/2010 at  3:38 PM, in message
> <  1264106300.21707.57.camel@localhost.localdomain  >, Ian Campbell
> <  Ian.Campbell@citrix.com  > wrote: 
> > On Wed, 2010-01-20 at 16:07 +0000, Keir Fraser wrote: 
> >> On 20/01/2010 16:02, "Ky Srinivasan" <  ksrinivasan@novell.com  > wrote:
> >> 
> >> > The attached patch fixes what I believe is a typo and permits guests 
> > running
> >> > the latest PV drivers to correctly interact with older back-ends.
> >> > 
> >> > Signed-off-by: K. Y. Srinivasan <  ksrinivasan@novell.com  >
> >> 
> >> Ian,
> >> 
> >> You introduced the magic port value check, in xen-unstable:19964.
> > 
> > I'm guilty of pretty poor changelogging there, aren't I, I've no idea
> > how the unmodified drivers part of the change relates to the comment :-(
> > 
> >> Can you ack/nack this please?
> > 
> > What vintage of older back-ends are we talking about?

> We shipped sles11 on xen-3.3.1 and this is where we encountered the
> problem - hosting a sles11 sp1 (based on xen-4.0.0)  guest on a sles11
> host. 

OK, so not ancient.

> > 
> > What is their behaviour when reading from that port? Can we test for a
> > specific value instead of anything != MAGIC or is there some other way
> > to identify them? 
> 
> Looking at your documentation for this new protocol, I recall seeing
> that if the magic value was not read, it was ok to silently return to
> be compatible.

Which docs? i386-dm/README.hvm-pv-magic-ioport-disable in the qemu-xen
tree says:
1) When the drivers first come up, they check whether the unplug logic
   is available by reading a two-byte magic number from IO port 0x10.
   These should be 0x49d2.  If the magic number doesn't match, the
   drivers don't do anything.

I take that to mean the drivers should not load if the magic value
doesn't match.

> > Without some sort of unplugging mechanism we run the risk of having both
> > PV and Emulated disk controllers active, accessing the same virtual disk
> > and with drivers loaded in the guest, which is potentially very
> > dangerous for the user's data. Did those older backends implement some
> > alternative unplugging mechanism we should be trying?
> We have had a mechanism for disabling the emulation when the PV
> drivers are loaded for some time now.

What is the mechanism? Why doesn't your patch add support for that
mechanism instead of just nobbling the current one?

> > The whole point of this magic check is to ensure we are running on a
> > backend which is new enough to do the unplugging in a safe way, so I
> > think failing to switch to PV and sticking with emulated on such
> > platforms the safe approach.
> 
> This breaks the compatibility with systems that have already been
> shipped in the sense we cannot run the guests with PV drivers. The
> proposed patch fixes the problem.

The guest still work though, right? Just with emulated drivers.

If you add a module option override instead of just skipping the safety
latch which the current mechanism implements then this patch would be OK
and it would be a simple guest tweak to switch PV drivers back on if you
have arranged out-of-band for the emulated devices to be unplugged.

Ian.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-22  7:31       ` Ian Campbell
@ 2010-01-22  8:03         ` Keir Fraser
  2010-01-22  8:43           ` Ian Campbell
  0 siblings, 1 reply; 14+ messages in thread
From: Keir Fraser @ 2010-01-22  8:03 UTC (permalink / raw)
  To: Ian Campbell; +Cc: ksrinivasan, xen-devel@lists.xensource.com

On 22/01/2010 07:31, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote:

> Yes, that's possible. I notice that I defined XEN_IOPORT_LINUX_PRODNUM
> and XEN_IOPORT_LINUX_DRVVER but then hardcode 0xdead and 0xbeef where
> they should be used, which suggests I wasn't quite ready to send the
> patch...

Hm, do you want to keep the deadbeef, or pick a nicer value, or remove the
patch?

> The protocol allows for coarse grained selection of which devices to
> unplug:
> 6) The drivers write a two-byte bitmask of devices to unplug to IO
>    port 0x10.  The defined fields are:

Well, the flexibility is nice, but not a feature that driver currently
actually uses.

My default action right now will be to add a module option to specify
selective or complete flushing, keep the patch, but only fail to load
drivers if flush is requested but not possible, otherwise just warn.

 -- Keir

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-22  8:03         ` Keir Fraser
@ 2010-01-22  8:43           ` Ian Campbell
  2010-01-22  9:07             ` Keir Fraser
  2010-01-22 10:45             ` Keir Fraser
  0 siblings, 2 replies; 14+ messages in thread
From: Ian Campbell @ 2010-01-22  8:43 UTC (permalink / raw)
  To: Keir Fraser; +Cc: ksrinivasan, xen-devel@lists.xensource.com

On Fri, 2010-01-22 at 08:03 +0000, Keir Fraser wrote: 
> On 22/01/2010 07:31, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote:
> 
> > Yes, that's possible. I notice that I defined XEN_IOPORT_LINUX_PRODNUM
> > and XEN_IOPORT_LINUX_DRVVER but then hardcode 0xdead and 0xbeef where
> > they should be used, which suggests I wasn't quite ready to send the
> > patch...
> 
> Hm, do you want to keep the deadbeef, or pick a nicer value, or remove the
> patch?
> 
> > The protocol allows for coarse grained selection of which devices to
> > unplug:
> > 6) The drivers write a two-byte bitmask of devices to unplug to IO
> >    port 0x10.  The defined fields are:
> 
> Well, the flexibility is nice, but not a feature that driver currently
> actually uses.
> 
> My default action right now will be to add a module option to specify
> selective or complete flushing, keep the patch, but only fail to load
> drivers if flush is requested but not possible, otherwise just warn.

Sounds good, what will the default flush setting be?

Could you swap out the 0xdead and 0xbeef for the defines which are
specified right above the function in question while you are there?

Ian.

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-22  8:43           ` Ian Campbell
@ 2010-01-22  9:07             ` Keir Fraser
  2010-01-22 10:45             ` Keir Fraser
  1 sibling, 0 replies; 14+ messages in thread
From: Keir Fraser @ 2010-01-22  9:07 UTC (permalink / raw)
  To: Ian Campbell; +Cc: ksrinivasan, xen-devel@lists.xensource.com

On 22/01/2010 08:43, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote:

>>> The protocol allows for coarse grained selection of which devices to
>>> unplug:
>>> 6) The drivers write a two-byte bitmask of devices to unplug to IO
>>>    port 0x10.  The defined fields are:
>> 
>> Well, the flexibility is nice, but not a feature that driver currently
>> actually uses.
>> 
>> My default action right now will be to add a module option to specify
>> selective or complete flushing, keep the patch, but only fail to load
>> drivers if flush is requested but not possible, otherwise just warn.
> 
> Sounds good, what will the default flush setting be?

None. Those who are switching from emulated to pv should know what they are
doing and specify the module option.

> Could you swap out the 0xdead and 0xbeef for the defines which are
> specified right above the function in question while you are there?

Yep.

 -- Keir

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-22  8:43           ` Ian Campbell
  2010-01-22  9:07             ` Keir Fraser
@ 2010-01-22 10:45             ` Keir Fraser
  2010-01-22 11:16               ` Pasi Kärkkäinen
  1 sibling, 1 reply; 14+ messages in thread
From: Keir Fraser @ 2010-01-22 10:45 UTC (permalink / raw)
  To: Ian Campbell; +Cc: ksrinivasan, xen-devel@lists.xensource.com

[-- Attachment #1: Type: text/plain, Size: 699 bytes --]

On 22/01/2010 08:43, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote:

>> My default action right now will be to add a module option to specify
>> selective or complete flushing, keep the patch, but only fail to load
>> drivers if flush is requested but not possible, otherwise just warn.
> 
> Sounds good, what will the default flush setting be?
> 
> Could you swap out the 0xdead and 0xbeef for the defines which are
> specified right above the function in question while you are there?

Proposed patch is attached. It'd be good if someone could at least
build-test it -- I can't seem to work out how to build PV-on-HVM drivers any
more, against my stock selection of native kernels.

 -- Keir


[-- Attachment #2: 00-pv-magic --]
[-- Type: application/octet-stream, Size: 2848 bytes --]

diff -r c06732ac2392 unmodified_drivers/linux-2.6/platform-pci/platform-pci.c
--- a/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c	Thu Jan 21 15:13:00 2010 +0000
+++ b/unmodified_drivers/linux-2.6/platform-pci/platform-pci.c	Fri Jan 22 10:43:15 2010 +0000
@@ -62,6 +62,13 @@
 MODULE_DESCRIPTION("Xen platform PCI device");
 MODULE_LICENSE("GPL");
 
+/* NB. [aux-]ide-disks options do not unplug IDE CD-ROM drives. */
+/* NB. aux-ide-disks is equiv to ide-disks except ignores primary master. */
+static char *dev_unplug;
+module_param(dev_unplug, charp, 0644);
+MODULE_PARM_DESC(dev_unplug, "Emulated devices to unplug: "
+		 "[all,][ide-disks,][aux-ide-disks,][nics]\n");
+
 struct pci_dev *xen_platform_pdev;
 
 static unsigned long shared_info_frame;
@@ -272,19 +279,43 @@
 #define XEN_IOPORT_LINUX_PRODNUM 0xffff /* NB: register a proper one */
 #define XEN_IOPORT_LINUX_DRVVER  ((LINUX_VERSION_CODE << 8) + 0x0)
 
+#define UNPLUG_ALL_IDE_DISKS 1
+#define UNPLUG_ALL_NICS 2
+#define UNPLUG_AUX_IDE_DISKS 4
+#define UNPLUG_ALL 7
+
 static int check_platform_magic(struct device *dev, long ioaddr, long iolen)
 {
-	short magic;
-	char protocol;
+	short magic, unplug = 0;
+	char protocol, *p, *q, *err;
 
-	if (iolen < 0x16)
-		return -ENODEV;
+	for (p = dev_unplug; p; p = q) {
+		q = strchr(dev_unplug, ',');
+		if (q)
+			*q++ = '\0';
+		if (!strcmp(p, "all"))
+			unplug |= UNPLUG_ALL;
+		else if (!strcmp(p, "ide-disks"))
+			unplug |= UNPLUG_ALL_IDE_DISKS;
+		else if (!strcmp(p, "aux-ide-disks"))
+			unplug |= UNPLUG_AUX_IDE_DISKS;
+		else if (!strcmp(p, "nics"))
+			unplug |= UNPLUG_ALL_NICS;
+		else
+			dev_warn(dev, "unrecognised option '%s' "
+				 "in module parameter 'dev_unplug'\n", p);
+	}
+
+	if (iolen < 0x16) {
+		err = "backend too old";
+		goto no_dev;
+	}
 
 	magic = inw(XEN_IOPORT_MAGIC);
 
 	if (magic != XEN_IOPORT_MAGIC_VAL) {
-		dev_err(dev, "invalid magic %#x", magic);
-		return -ENODEV;
+		err = "unrecognised magic value";
+		goto no_dev;
 	}
 
 	protocol = inb(XEN_IOPORT_PROTOVER);
@@ -293,8 +324,8 @@
 
 	switch (protocol) {
 	case 1:
-		outw(XEN_IOPORT_PRODNUM, 0xbeef);
-		outl(XEN_IOPORT_DRVVER, 0xdead);
+		outw(XEN_IOPORT_PRODNUM, XEN_IOPORT_LINUX_PRODNUM);
+		outl(XEN_IOPORT_DRVVER, XEN_IOPORT_LINUX_DRVVER);
 		if (inw(XEN_IOPORT_MAGIC) != XEN_IOPORT_MAGIC_VAL) {
 			dev_err(dev, "blacklisted by host\n");
 			return -ENODEV;
@@ -304,11 +335,18 @@
 		outw(XEN_IOPORT_UNPLUG, 0xf);
 		break;
 	default:
-		dev_err(dev, "unknown qemu version\n");
-		return -ENODEV;
+		err = "unknown I/O protocol version";
+		goto no_dev;
 	}
 
 	return 0;
+
+ no_dev:
+	dev_warn(dev, "failed backend handshake: %s\n", err);
+	if (!unplug)
+		return 0;
+	dev_err(dev, "failed to execute specified dev_unplug options!\n");
+	return -ENODEV;
 }
 
 static int __devinit platform_pci_init(struct pci_dev *pdev,

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-22 10:45             ` Keir Fraser
@ 2010-01-22 11:16               ` Pasi Kärkkäinen
  2010-01-26 10:12                 ` Pasi Kärkkäinen
  0 siblings, 1 reply; 14+ messages in thread
From: Pasi Kärkkäinen @ 2010-01-22 11:16 UTC (permalink / raw)
  To: Keir Fraser; +Cc: Ian Campbell, ksrinivasan, xen-devel@lists.xensource.com

On Fri, Jan 22, 2010 at 10:45:06AM +0000, Keir Fraser wrote:
> On 22/01/2010 08:43, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote:
> 
> >> My default action right now will be to add a module option to specify
> >> selective or complete flushing, keep the patch, but only fail to load
> >> drivers if flush is requested but not possible, otherwise just warn.
> > 
> > Sounds good, what will the default flush setting be?
> > 
> > Could you swap out the 0xdead and 0xbeef for the defines which are
> > specified right above the function in question while you are there?
> 
> Proposed patch is attached. It'd be good if someone could at least
> build-test it -- I can't seem to work out how to build PV-on-HVM drivers any
> more, against my stock selection of native kernels.
> 

Maybe this blog post helps:

"building unmodified_drivers":
http://wp.colliertech.org/cj/?p=653

That's about the SLES11 2.6.27 kernel.

-- Pasi

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-22 11:16               ` Pasi Kärkkäinen
@ 2010-01-26 10:12                 ` Pasi Kärkkäinen
  2010-01-26 10:19                   ` Keir Fraser
  0 siblings, 1 reply; 14+ messages in thread
From: Pasi Kärkkäinen @ 2010-01-26 10:12 UTC (permalink / raw)
  To: Keir Fraser; +Cc: Ian Campbell, ksrinivasan, xen-devel@lists.xensource.com

On Fri, Jan 22, 2010 at 01:16:29PM +0200, Pasi Kärkkäinen wrote:
> On Fri, Jan 22, 2010 at 10:45:06AM +0000, Keir Fraser wrote:
> > On 22/01/2010 08:43, "Ian Campbell" <Ian.Campbell@eu.citrix.com> wrote:
> > 
> > >> My default action right now will be to add a module option to specify
> > >> selective or complete flushing, keep the patch, but only fail to load
> > >> drivers if flush is requested but not possible, otherwise just warn.
> > > 
> > > Sounds good, what will the default flush setting be?
> > > 
> > > Could you swap out the 0xdead and 0xbeef for the defines which are
> > > specified right above the function in question while you are there?
> > 
> > Proposed patch is attached. It'd be good if someone could at least
> > build-test it -- I can't seem to work out how to build PV-on-HVM drivers any
> > more, against my stock selection of native kernels.
> > 
> 
> Maybe this blog post helps:
> 
> "building unmodified_drivers":
> http://wp.colliertech.org/cj/?p=653
> 
> That's about the SLES11 2.6.27 kernel.
> 

Btw against what kernels did you try to build? 

-- Pasi

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [PATCH] PV driver compatibility
  2010-01-26 10:12                 ` Pasi Kärkkäinen
@ 2010-01-26 10:19                   ` Keir Fraser
  0 siblings, 0 replies; 14+ messages in thread
From: Keir Fraser @ 2010-01-26 10:19 UTC (permalink / raw)
  To: Pasi Kärkkäinen
  Cc: Ian Campbell, ksrinivasan, xen-devel@lists.xensource.com

On 26/01/2010 10:12, "Pasi Kärkkäinen" <pasik@iki.fi> wrote:

>>> Proposed patch is attached. It'd be good if someone could at least
>>> build-test it -- I can't seem to work out how to build PV-on-HVM drivers any
>>> more, against my stock selection of native kernels.
>>> 
>> 
>> Maybe this blog post helps:
>> 
>> "building unmodified_drivers":
>> http://wp.colliertech.org/cj/?p=653
>> 
>> That's about the SLES11 2.6.27 kernel.
>> 
> 
> Btw against what kernels did you try to build?

Vanilla 2.6.19 and vanilla 2.6.27.

 -- Keir

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2010-01-26 10:19 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-20 16:02 [PATCH] PV driver compatibility Ky Srinivasan
2010-01-20 16:07 ` Keir Fraser
2010-01-21 20:38   ` Ian Campbell
2010-01-21 21:46     ` Keir Fraser
2010-01-22  7:31       ` Ian Campbell
2010-01-22  8:03         ` Keir Fraser
2010-01-22  8:43           ` Ian Campbell
2010-01-22  9:07             ` Keir Fraser
2010-01-22 10:45             ` Keir Fraser
2010-01-22 11:16               ` Pasi Kärkkäinen
2010-01-26 10:12                 ` Pasi Kärkkäinen
2010-01-26 10:19                   ` Keir Fraser
     [not found] <4B586E2D020000300007DDE1@sinclair.provo.novell.com>
2010-01-21 23:04 ` Ky Srinivasan
2010-01-22  7:37   ` Ian Campbell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.