Re: [PATCH 07/24] drm/i915: show unknown sdvox registers on hdmi init

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Thu, 26 Apr 2012 15:21:02 -0300
Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:

> This will throw a DRM_ERROR message when an unknown sdvox register is
> given to intel_hdmi_init. When this happens, things could going to be pretty
> much broken afterwards, so we better detect this as soon as possible.
> 
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_hdmi.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index f6a9b83..d73a16c 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -606,6 +606,8 @@ void intel_hdmi_init(struct drm_device *dev, int sdvox_reg)
>  		intel_encoder->clone_mask = (1 << INTEL_HDMIF_CLONE_BIT);
>  		intel_hdmi->ddc_bus = GMBUS_PORT_DPD;
>  		dev_priv->hotplug_supported_mask |= HDMID_HOTPLUG_INT_STATUS;
> +	} else {
> +		DRM_ERROR("Unknown sdvox register on HDMI init: %x\n", sdvox_reg);
>  	}
>  
>  	intel_hdmi->sdvox_reg = sdvox_reg;

BUG_ON then?  At least if this is purely a driver sanity check...

-- 
Jesse Barnes, Intel Open Source Technology Center