Re: [PATCH 08/24] drm/i915: do not use fdi_normal_train on haswell

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Thu, 26 Apr 2012 15:21:03 -0300
Eugeni Dodonov <eugeni.dodonov@intel.com> wrote:

> This should be already configured when FDI auto-negotiation is done.
> 
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 27f384d..758173d 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -2700,7 +2700,8 @@ static void ironlake_pch_enable(struct drm_crtc *crtc)
>  	I915_WRITE(TRANS_VSYNC(pipe),  I915_READ(VSYNC(pipe)));
>  	I915_WRITE(TRANS_VSYNCSHIFT(pipe),  I915_READ(VSYNCSHIFT(pipe)));
>  
> -	intel_fdi_normal_train(crtc);
> +	if (!IS_HASWELL(dev))
> +		intel_fdi_normal_train(crtc);
>  
>  	/* For PCH DP, enable TRANS_DP_CTL */
>  	if (HAS_PCH_CPT(dev) &&

We could probably try autotraining on IVB too, just for fun.

But until then, the HSW check is fine.

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center