Re: [PATCH 2/9] cxl/port: Reduce number of @dport variables in cxl_port_add_dport()

[<dan.j.williams@intel.com>]

Jonathan Cameron wrote:
> On Wed, 21 Jan 2026 19:33:23 -0800
> Dan Williams <dan.j.williams@intel.com> wrote:
> 
> > In preparation for refactoring cxl_port_add_dport() to add RAS register
> > setup, cleanup the number of dport variables with a dport_exists() helper.
> Maybe mention why the driver check is now after the duplicate check.
> If there isn't a reason for that, I'd put them back to reduce churn a tiny
> bit.
> 
> > 
> > Kill the @dport needed to check for duplicates, rename @new_dport to
> > @dport.
> In ideal world I think the helper introduction and the rename
> would be two patches. Still real world, this is fine.
> 
> Assuming you'll address the reorder of checks by comment or
> putting them back,
> 
> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
[..]
> >  static struct cxl_dport *cxl_port_add_dport(struct cxl_port *port,
> >  					    struct device *dport_dev)
> >  {
> > -	struct cxl_dport *dport;
> >  	int rc;
> >  
> >  	device_lock_assert(&port->dev);
> > -	if (!port->dev.driver)
> > -		return ERR_PTR(-ENXIO);
> 
> Diff is a bit of a mess due to the checks (originally driver bind
> then duplicate test) being swapped.
> Is there a reason to do that?

Nope, no reason. Flipped it back.