Re: [RFC] mac80211: Re-enable aggregation

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

On Mon, 2008-10-20 at 02:01 -0700, Luis R. Rodriguez wrote:

> > Well the fact that it's in tx_h_sequence is a bit weird, but we should
> > be able to get around not using an extra bit in skb I think. Especially
> > for this since it's only really between the driver and mac80211, and
> > after a requeue the ampdu status might actually change.
> 
> Good point. I failed to see that. So in that case it should be as
> sujith had it before my suggestion and just handle it as he had it in
> the tx handlers. The problem though is that the RC algorithm should be
> the one to determine if an skb is part of an ampdu for aggregation or
> not IMHO. Actually this is the real question and hot topic.
> 
> When should we aggregate and should mac80211 decide that or be left to the RC.

No, the RC algorithm cannot decided that, the RC algorithm can merely
decide when to set up/tear down aggregation sessions. When a session is
up all packet belonging to that TID should go into it, surely?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]