From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: Sujith <Sujith.Manoharan@atheros.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Luis.Rodriguez@atheros.com, tomasw@gmail.com
Subject: Re: [RFC] mac80211: Re-enable aggregation
Date: Mon, 20 Oct 2008 01:57:02 -0700 [thread overview]
Message-ID: <43e72e890810200157j30e27aden1d8b76ce7fbb8177@mail.gmail.com> (raw)
In-Reply-To: <1224492335.18024.34.camel@johannes.berg>
On Mon, Oct 20, 2008 at 1:45 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Mon, 2008-10-20 at 01:35 -0700, Luis R. Rodriguez wrote:
>
>> >> + * @is_part_ampdu: set to indicate that the wireless core should should
>> >> + * treat this frame as part of an AMPDU
>> >
>> > I thought we said we could keep the flag instead of moving to the skb
>> > here?
>>
>> That was just because the changes required to add this was too much
>> for 2.6.27 but since we don't care about this fix in 2.6.27 we can do
>> whatever is needed to fix this properly.
>
> Right, but adding random stuff into skb isn't really "properly" imho.
> And we don't really need this afaict.
Agreed -- which is why I was suggesting we should consider using
skb->do_not_fragment instead. Although I didn't finish complete review
to ensure that is the only reason we need this. That is a more generic
flag. Thoughts?
Luis
next prev parent reply other threads:[~2008-10-20 8:57 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 8:22 [RFC] mac80211: Re-enable aggregation Sujith
2008-10-20 8:31 ` Johannes Berg
2008-10-20 8:35 ` Luis R. Rodriguez
2008-10-20 8:45 ` Johannes Berg
2008-10-20 8:47 ` Sujith
2008-10-20 8:55 ` Luis R. Rodriguez
2008-10-20 8:57 ` Johannes Berg
2008-10-20 9:01 ` Luis R. Rodriguez
2008-10-20 9:04 ` Johannes Berg
2008-10-20 9:05 ` Luis R. Rodriguez
2008-10-20 9:11 ` Sujith
2008-10-20 8:57 ` Luis R. Rodriguez [this message]
2008-10-20 8:58 ` Sujith
2008-10-20 9:12 ` Johannes Berg
2008-10-20 9:31 ` Sujith
2008-10-20 9:38 ` Johannes Berg
2008-10-20 10:35 ` Sujith
2008-10-20 12:22 ` Johannes Berg
2008-10-20 18:03 ` Sujith
2008-10-20 21:46 ` Tomas Winkler
2008-10-21 6:46 ` Johannes Berg
2008-10-21 7:18 ` Sujith
2008-10-22 10:03 ` Johannes Berg
2008-10-22 11:59 ` Tomas Winkler
2008-10-22 17:22 ` Johannes Berg
2008-10-23 8:57 ` Sujith
2008-10-23 14:46 ` Johannes Berg
2008-10-27 14:25 ` Sujith
2008-10-27 15:04 ` Johannes Berg
2008-10-27 15:56 ` Tomas Winkler
2008-10-27 16:04 ` Johannes Berg
2008-10-28 14:24 ` Tomas Winkler
2008-10-22 10:00 ` Johannes Berg
2008-10-22 11:41 ` Tomas Winkler
2008-10-22 17:24 ` Johannes Berg
2008-10-23 9:31 ` Sujith
2008-10-23 14:45 ` Johannes Berg
2008-10-23 17:23 ` Luis R. Rodriguez
2008-10-23 18:31 ` Tomas Winkler
2008-10-23 20:18 ` Luis R. Rodriguez
2008-10-23 21:17 ` Tomas Winkler
2008-10-31 1:26 ` Luis R. Rodriguez
2008-10-27 14:11 ` Sujith
2008-10-27 15:07 ` Johannes Berg
2008-10-20 9:14 ` Luis R. Rodriguez
2008-10-20 9:24 ` Johannes Berg
2008-10-20 10:07 ` Sujith
2008-10-20 10:15 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e72e890810200157j30e27aden1d8b76ce7fbb8177@mail.gmail.com \
--to=mcgrof@gmail.com \
--cc=Luis.Rodriguez@atheros.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox