Re: [RFC] mac80211: Re-enable aggregation

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]

On Mon, 2008-10-27 at 19:41 +0530, Sujith wrote:

> > > How would mac80211 buffer frames ? 
> > 
> > Well I suppose it would just put them on a list in the sta_info struct.
> > 
> 
> A list for each TID, no ?

Right.

> To summarize a bit about the state/control information that mac80211 needs
> to maintain for an aggregation session:
> 
> * Block Ack state for each TID (sequence numbers, BA window etc.)
> * Maintain a list of buffers for each <RA,TID> (setup, teardown etc.)
> * Handle retransmission of unacked frames.
> 
> Forming an aggregate would involve the following.
> ( These might depend on HW caps as well as the recipient STA's caps)
> 
> * Aggregate length
> * Delimiters
> * Padding of sub-frames
> 
> TX control information will probably need to pass aggr. specific information
> (number of delimiters etc.)
> 
> The API for aggregation can extend the ampdu_action() callback.
> Adding a few more states can probably suffice initially.

Sounds good to me. If you need more space in TX control information...
Not sure what to do then. We could take out 'vif' and put that into the
tx() arguments instead, for example.

> We'll work on this and come up with an RFC.

Great!

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]