Re: [PATCH v2 01/10] cxl/region: Add decoder check to check_commit_order()

[Dave Jiang <dave.jiang@intel.com>]

On 5/20/25 4:14 AM, Jonathan Cameron wrote:
> On Tue, 6 May 2025 17:43:01 -0700
> Dave Jiang <dave.jiang@intel.com> wrote:
> 
>> check_commit_order() attempts to convert a device to a decoder without
>> making sure the device is a decoder. So far this has been working due
>> to pure luck. Issue discovered while doing deferred dport probing when
>> child ports are now in the midst of decoders due to ordering change
>> of child port additions. Add a check before attempting to do decoder
>> conversion.
>>
>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Thanks Jonathan
> 
> Stands on it's own so maybe queue this up even if later patches
> are still under discussion?
> 
> I'm keen to reduce what is floating around in a good state!

I originally submitted this stand alone and Dan said to include it with the series. The issue does not show up until we change the behavior of port enumeration.

DJ

> 
> Jonathan
> 
>> ---
>>  drivers/cxl/core/region.c | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
>> index c3f4dc244df7..a91d4eb061e4 100644
>> --- a/drivers/cxl/core/region.c
>> +++ b/drivers/cxl/core/region.c
>> @@ -788,7 +788,12 @@ static size_t show_targetN(struct cxl_region *cxlr, char *buf, int pos)
>>  
>>  static int check_commit_order(struct device *dev, void *data)
>>  {
>> -	struct cxl_decoder *cxld = to_cxl_decoder(dev);
>> +	struct cxl_decoder *cxld;
>> +
>> +	if (!is_switch_decoder(dev))
>> +		return 0;
>> +
>> +	cxld = to_cxl_decoder(dev);
>>  
>>  	/*
>>  	 * if port->commit_end is not the only free decoder, then out of
>>
>> base-commit: 3c746d4821f507304b08789e3c7c151554fc2356
>