Devicetree
 help / color / mirror / Atom feed
From: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, konrad.dybcio@oss.qualcomm.com,
	mani@kernel.org
Subject: [PATCH 25/34] arm64: dts: qcom: sdm845: Move PCIe phy and GPIOs to root port node
Date: Thu, 10 Sep 2026 18:59:14 +0530	[thread overview]
Message-ID: <20260910-root_port-v1-25-90a252ddbbfa@oss.qualcomm.com> (raw)
In-Reply-To: <20260910-root_port-v1-0-90a252ddbbfa@oss.qualcomm.com>

The PCIe phy reference and the perst/wake GPIO properties are
per root port and belong in the root port node (pcie@0), not in the
RC controller node. Move phys and phy-names from the controller to
pcie0_port0 and pcie1_port0, adding labels to these nodes to allow
board-level overrides. Move perst-gpios/wake-gpios from the
controller overrides to the respective port nodes in the board files,
renaming perst-gpios to reset-gpios to match the binding used in the
root port context.

Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 13 +++++++++----
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts    | 12 ++++++++----
 arch/arm64/boot/dts/qcom/sdm845.dtsi       | 14 ++++++--------
 3 files changed, 23 insertions(+), 16 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
index 3e636926231d..27a0b90d2b7a 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
@@ -618,15 +618,17 @@ &mss_pil {
 
 &pcie0 {
 	status = "okay";
-	perst-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
-	wake-gpios = <&tlmm 134 GPIO_ACTIVE_LOW>;
-
 	vddpe-3v3-supply = <&pcie0_3p3v_dual>;
 
 	pinctrl-names = "default";
 	pinctrl-0 = <&pcie0_default_state>;
 };
 
+&pcie0_port0 {
+	reset-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
+	wake-gpios = <&tlmm 134 GPIO_ACTIVE_LOW>;
+};
+
 &pcie0_phy {
 	status = "okay";
 
@@ -636,12 +638,15 @@ &pcie0_phy {
 
 &pcie1 {
 	status = "okay";
-	perst-gpios = <&tlmm 102 GPIO_ACTIVE_LOW>;
 
 	pinctrl-names = "default";
 	pinctrl-0 = <&pcie1_default_state>;
 };
 
+&pcie1_port0 {
+	reset-gpios = <&tlmm 102 GPIO_ACTIVE_LOW>;
+};
+
 &pcie1_phy {
 	status = "okay";
 
diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
index c66df45eee64..0080000a1839 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
@@ -508,14 +508,16 @@ &mss_pil {
 };
 
 &pcie0 {
-	perst-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
-
 	pinctrl-0 = <&pcie0_default_state>;
 	pinctrl-names = "default";
 
 	status = "okay";
 };
 
+&pcie0_port0 {
+	reset-gpios = <&tlmm 35 GPIO_ACTIVE_LOW>;
+};
+
 &pcie0_phy {
 	vdda-phy-supply = <&vreg_l1a_0p875>;
 	vdda-pll-supply = <&vreg_l26a_1p2>;
@@ -524,14 +526,16 @@ &pcie0_phy {
 };
 
 &pcie1 {
-	perst-gpios = <&tlmm 102 GPIO_ACTIVE_LOW>;
-
 	pinctrl-names = "default";
 	pinctrl-0 = <&pcie1_default_state>;
 
 	status = "okay";
 };
 
+&pcie1_port0 {
+	reset-gpios = <&tlmm 102 GPIO_ACTIVE_LOW>;
+};
+
 &pcie1_phy {
 	status = "okay";
 
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index b1f6782a3ad9..cb7f93b02b5a 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2395,16 +2395,15 @@ pcie0: pcie@1c00000 {
 
 			power-domains = <&gcc PCIE_0_GDSC>;
 
-			phys = <&pcie0_phy>;
-			phy-names = "pciephy";
-
 			status = "disabled";
 
-			pcie@0 {
+			pcie0_port0: pcie@0 {
 				device_type = "pci";
 				reg = <0x0 0x0 0x0 0x0 0x0>;
 				bus-range = <0x01 0xff>;
 
+				phys = <&pcie0_phy>;
+
 				#address-cells = <3>;
 				#size-cells = <2>;
 				ranges;
@@ -2525,16 +2524,15 @@ pcie1: pcie@1c08000 {
 
 			power-domains = <&gcc PCIE_1_GDSC>;
 
-			phys = <&pcie1_phy>;
-			phy-names = "pciephy";
-
 			status = "disabled";
 
-			pcie@0 {
+			pcie1_port0: pcie@0 {
 				device_type = "pci";
 				reg = <0x0 0x0 0x0 0x0 0x0>;
 				bus-range = <0x01 0xff>;
 
+				phys = <&pcie1_phy>;
+
 				#address-cells = <3>;
 				#size-cells = <2>;
 				ranges;

-- 
2.34.1


  parent reply	other threads:[~2026-09-10 13:30 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10 13:28 [PATCH 00/34] arm64: dts: qcom: Move PCIe phy/GPIOs to root port nodes and fix wake-gpios polarity Krishna Chaitanya Chundru
2026-09-10 13:28 ` [PATCH 01/34] ARM: dts: qcom: sdx55: Fix PCIe wake GPIO polarity Krishna Chaitanya Chundru
2026-09-11  4:58   ` Manivannan Sadhasivam
2026-09-10 13:28 ` [PATCH 02/34] arm64: dts: qcom: msm8996: " Krishna Chaitanya Chundru
2026-09-10 13:28 ` [PATCH 03/34] arm64: dts: qcom: sdm845: " Krishna Chaitanya Chundru
2026-09-10 13:28 ` [PATCH 04/34] arm64: dts: qcom: sc8180x: " Krishna Chaitanya Chundru
2026-09-10 13:28 ` [PATCH 05/34] arm64: dts: qcom: sm8150: " Krishna Chaitanya Chundru
2026-09-10 13:44   ` sashiko-bot
2026-09-10 13:28 ` [PATCH 06/34] arm64: dts: qcom: sm8250: " Krishna Chaitanya Chundru
2026-09-10 13:28 ` [PATCH 07/34] arm64: dts: qcom: sm8350: " Krishna Chaitanya Chundru
2026-09-10 13:28 ` [PATCH 08/34] arm64: dts: qcom: sm8450: " Krishna Chaitanya Chundru
2026-09-10 13:28 ` [PATCH 09/34] arm64: dts: qcom: sm8550: " Krishna Chaitanya Chundru
2026-09-10 13:28 ` [PATCH 10/34] arm64: dts: qcom: qcs8550-rb5gen2: Move PCIe phy and GPIOs to root port node Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 11/34] arm64: dts: qcom: sm8650: Fix PCIe wake GPIO polarity Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 12/34] arm64: dts: qcom: sm8750: " Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 13/34] arm64: dts: qcom: kaanapali: " Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 14/34] arm64: dts: qcom: sar2130p: " Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 15/34] arm64: dts: qcom: monaco: " Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 16/34] arm64: dts: qcom: lemans: " Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 17/34] arm64: dts: qcom: talos: " Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 18/34] arm64: dts: qcom: sa8540p-ride: " Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 19/34] arm64: dts: qcom: kodiak: " Krishna Chaitanya Chundru
2026-09-10 13:42   ` sashiko-bot
2026-09-10 13:29 ` [PATCH 20/34] arm64: dts: qcom: qcs6490-vicharak-axon-mini: Move PCIe phy and GPIOs to root port node Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 21/34] arm64: dts: qcom: msm8998: " Krishna Chaitanya Chundru
2026-09-10 13:49   ` sashiko-bot
2026-09-10 13:29 ` [PATCH 22/34] arm64: dts: qcom: qcs404: " Krishna Chaitanya Chundru
2026-09-10 13:47   ` sashiko-bot
2026-09-10 13:29 ` [PATCH 23/34] arm64: dts: qcom: sar2130p: " Krishna Chaitanya Chundru
2026-09-10 13:46   ` sashiko-bot
2026-09-10 13:29 ` [PATCH 24/34] arm64: dts: qcom: sc8180x: " Krishna Chaitanya Chundru
2026-09-10 13:48   ` sashiko-bot
2026-09-10 13:29 ` Krishna Chaitanya Chundru [this message]
2026-09-10 13:52   ` [PATCH 25/34] arm64: dts: qcom: sdm845: " sashiko-bot
2026-09-10 13:29 ` [PATCH 26/34] arm64: dts: qcom: sm8150: " Krishna Chaitanya Chundru
2026-09-10 13:51   ` sashiko-bot
2026-09-10 13:29 ` [PATCH 27/34] arm64: dts: qcom: sm8250: " Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 28/34] arm64: dts: qcom: sm8350: " Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 29/34] arm64: dts: qcom: sm8450: " Krishna Chaitanya Chundru
2026-09-10 13:37   ` Neil Armstrong
2026-09-10 13:54   ` sashiko-bot
2026-09-10 13:29 ` [PATCH 30/34] arm64: dts: qcom: talos: " Krishna Chaitanya Chundru
2026-09-10 13:57   ` sashiko-bot
2026-09-10 13:29 ` [PATCH 31/34] arm64: dts: qcom: sm8650: " Krishna Chaitanya Chundru
2026-09-10 13:36   ` Neil Armstrong
2026-09-10 13:59   ` sashiko-bot
2026-09-10 13:29 ` [PATCH 32/34] arm64: dts: qcom: msm8996: " Krishna Chaitanya Chundru
2026-09-10 13:58   ` sashiko-bot
2026-09-10 13:29 ` [PATCH 33/34] arm64: dts: qcom: lemans: " Krishna Chaitanya Chundru
2026-09-10 13:29 ` [PATCH 34/34] arm64: dts: qcom: sm8550: " Krishna Chaitanya Chundru
2026-09-10 13:37   ` Neil Armstrong
2026-09-10 14:01   ` sashiko-bot
2026-09-11  4:56 ` [PATCH 00/34] arm64: dts: qcom: Move PCIe phy/GPIOs to root port nodes and fix wake-gpios polarity Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260910-root_port-v1-25-90a252ddbbfa@oss.qualcomm.com \
    --to=krishna.chundru@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox